Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp83431pxt; Wed, 4 Aug 2021 06:28:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybxiUc1p/i12YotEUhHtiBae1HoDA0EtL+4BUcwCOUDJIx8pNxOs80LG9MKzdvu1EQD1CN X-Received: by 2002:a05:6638:c58:: with SMTP id g24mr24119252jal.63.1628083730499; Wed, 04 Aug 2021 06:28:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628083730; cv=none; d=google.com; s=arc-20160816; b=izlU8BZIeBGkw90akqdg/dzhjrTirdICM8bGcjU02acSe+jcp2cRgsW+XtzG3adX9x LyS5au27avtXygJ0nZjDG1IumXOVdw+KHLPTL2f6Si7Gw7FDzjdyrmt9oVbi0gacLpF4 1JO+GIXjZdC7sHthWYJNpNnevF2p0tqPxr/ypmXGUCZakDYSHfO9JWJXGUpGA8RvymZe AAFBB4vO/yCskLBLyRG+JvrYpXHi6Ze6lnL3M3XVJhc3PsgzAA92wvQleotPJM0ivIuC ju6uKwdgpt+1shAG8ZJvBfEjGhjCHdHF3do7wvF3HIYGByL3TyEGwMahSXe8XnEhXAqi OY3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=zWvy8sh/+lRbS7C72TP9P5YTqZkTi8RR/qpbQTwlVag=; b=wdzKQNppdv8erB2qWlFJdxOa6yae04sHTA/a7Kkwqp6HasiS5Xw+eLvfBBuAtMpdYs 229HHsxAH6b7UdYWKRx6a53g0ru9vASoF0ClH5+0d4Jpw/q5TIQX1oZhTPMDaW9QQFLy 4RnIpQLSRoJ/OYRq5H5jfaoZx8odb6Z5Ol2hFs4j2hz8ASULUWh6iIVCnNAjAx6ov3sc +8Ve6XZ+D6kCcBCA4VUnJ/TY5hIbXJQ9o+P2BB4m3oFNXXmI7XKyBdBJpgnbBBKACVN6 hQD4kCsPPwp+y8/1Nw6nuiUg6wdGhdyEGKPTQ8IN5eIGqZBKw11yjkg02W6XTgP5iDUN lJrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L8CPcLBL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si2451868ilv.68.2021.08.04.06.28.36; Wed, 04 Aug 2021 06:28:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L8CPcLBL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238207AbhHDMo6 (ORCPT + 99 others); Wed, 4 Aug 2021 08:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238177AbhHDMor (ORCPT ); Wed, 4 Aug 2021 08:44:47 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7FEDC0613D5 for ; Wed, 4 Aug 2021 05:44:34 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id p21so3299493edi.9 for ; Wed, 04 Aug 2021 05:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zWvy8sh/+lRbS7C72TP9P5YTqZkTi8RR/qpbQTwlVag=; b=L8CPcLBLfXrFwcb4XrQhaX62u6eGIqzHpEeaRRcOLVMygMXRcZkS2VhopsFWbJpRJU RNLuTOEJoz9lgbbucOd7iaoLZtgLZ/f3Sd0A/afoxBpoZv6gVjlUyyIRdfPDfFUttTVz HORx9g6juclSgD8FhRl9ECPwVnIn6rfCJFxNFZrorO2J2BPah8rMIjmw/nIF0LfTowW9 eL7YgG8ldd6Pm90HH7Av8A5hntUIpf0QOmQZe/apiHcmzxvuozEfHHzy+SRdQeBlE2jp y/jWYs0K5WrByOzc49GinBCXyILrf5OX6bUtFMc+juwS5mJhFuWPPlK65fvKo6cTYHn2 9yfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zWvy8sh/+lRbS7C72TP9P5YTqZkTi8RR/qpbQTwlVag=; b=qDoZSyNFB/w1Y2H2hqyCS4Zaq/OQoYNnNPCKrM88unn8LVcLaJ0R5UkZMsfnz7/fBc DGXi5KLrz9u+P8vxrfgm+uvm+Y6ulxIiCxWavNPXVLzK250G0p6plenZ3GZADte7S8/W ObS2rcd6wi67hbvw13VUU6PLAhR9TVuQw07Nc52PB6zz+M+Jkl0+lcoXzItY+hzeEHkv TTwKYzVpf/oMM0l5s+Fn0hDV5WC+eXCdIHzkQ0l85C3bqv5ASTjhwsajjzN79jDUwMOY +O8uUWc46N/iIbF5p6XWSgnrDbYAs1S+CjsXuOe2K9/eMMkcZf7SlI96Xs/AQpfmhLJQ phFw== X-Gm-Message-State: AOAM530eUkuu9ewBT2MHGcvUG0KWmGQWf719r9tRZ8DLlsRs4lcyJHYX PcrZDtiK582HfvDCoA6DkaOekTuKMCh5eUs3vWw= X-Received: by 2002:a05:6402:430b:: with SMTP id m11mr32140537edc.55.1628081073404; Wed, 04 Aug 2021 05:44:33 -0700 (PDT) MIME-Version: 1.0 References: <20210804090957.12393-1-Kuan-Ying.Lee@mediatek.com> <20210804090957.12393-3-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210804090957.12393-3-Kuan-Ying.Lee@mediatek.com> From: Andrey Konovalov Date: Wed, 4 Aug 2021 14:44:22 +0200 Message-ID: Subject: Re: [PATCH v3 2/2] kasan, slub: reset tag when printing address To: Kuan-Ying Lee Cc: Nicholas Tang , Andrew Yang , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Catalin Marinas , Chinwen Chang , Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Linux ARM , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 4, 2021 at 11:10 AM Kuan-Ying Lee wrote: > > The address still includes the tags when it is printed. > With hardware tag-based kasan enabled, we will get a > false positive KASAN issue when we access metadata. > > Reset the tag before we access the metadata. > > Fixes: aa1ef4d7b3f6 ("kasan, mm: reset tags when accessing metadata") > Signed-off-by: Kuan-Ying Lee > Reviewed-by: Marco Elver > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index b6c5205252eb..f77d8cd79ef7 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -576,8 +576,8 @@ static void print_section(char *level, char *text, u8 *addr, > unsigned int length) > { > metadata_access_enable(); > - print_hex_dump(level, kasan_reset_tag(text), DUMP_PREFIX_ADDRESS, > - 16, 1, addr, length, 1); > + print_hex_dump(level, text, DUMP_PREFIX_ADDRESS, > + 16, 1, kasan_reset_tag((void *)addr), length, 1); > metadata_access_disable(); > } > > -- > 2.18.0 Reviewed-by: Andrey Konovalov Thanks!