Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp101998pxt; Wed, 4 Aug 2021 06:55:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVK2xNOHT/GFw81m4o7GEfppkjRHBwTJen0yVGqsqGRn5hmpushh2UXD+k/9k3ryHjFQEH X-Received: by 2002:a17:906:2642:: with SMTP id i2mr26191586ejc.323.1628085351638; Wed, 04 Aug 2021 06:55:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628085351; cv=none; d=google.com; s=arc-20160816; b=D5DA61I8d0l2E7wiJxsRISSlyAOaA9rgrTI46/IqXn7QPaZJSE4LHC54Y14ImDtLXj 6U1JIcCFadDSipgQOk3AaD28Pg+ZvP4oM6KBX11/dewVxJVttsosybxVGDbBPK0oK+jb 2/rWvPHzpVtq0X1V9ZYvDagZK6liyDGC8TR3Hlbixc5cWVnoofOkoqZo6r54V91yfh89 pqWZt0nLI8ZmlOHunin3I4yH+bGNKCdnFXSZNGzEV3iHA8P5n9NN5LNPJs44ETFm5TYr Qf8FHD8P7QAu8OjNswR5IZRp+qnI0NYWZyXW7mPlG2/ihV/9UhsPbeK48Omcz7YWWEDS Ym4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sQHuzcjS6P96HYdRIf7uqQ4lnDNFAoSA8AvFOLfc/M4=; b=fBXsAOTSUouzxfh2Cbng9GuCs+Kav0c++kG5K/P54w9DwpVBLnBAGfuMdw87VpuoNj RInv4CquILYU7PXC+ysKu/sMBbUm48JMxB1QajjDahhxqL5zzRqIbQqcFcHNvi42DYhB 0sC6K3282SsdgaimtYwTecCthco7GGQBpWy3UNUz60I7swhW2xVmEp0+MeFslGiyPtfZ +LaANkFWWyK810NYlRl2cg/IKu+L25K+ZDb2tjeI41dT/2tiHJjIRdo7vtdK62Iad9wS E0LYsfmKylIBa4c9CxrZQxoAUFThNu+BfxageyBizwCoR/F5rexaQhTfCEaC6oRFfsPD sPGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="tewNok//"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si2090060ejk.740.2021.08.04.06.55.26; Wed, 04 Aug 2021 06:55:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="tewNok//"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237675AbhHDNxJ (ORCPT + 99 others); Wed, 4 Aug 2021 09:53:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237156AbhHDNxI (ORCPT ); Wed, 4 Aug 2021 09:53:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17F9AC0613D5 for ; Wed, 4 Aug 2021 06:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sQHuzcjS6P96HYdRIf7uqQ4lnDNFAoSA8AvFOLfc/M4=; b=tewNok//YUiPhUzswLRFPp3jXc PuQKMVAbnitnz6zWHQzh8f6a/RQc9KVm15hvF7mMIUaPZt/jrMllAsqYk4YTJHKNB1aUYp9c3Hidm Upeu+cPbKwVMygr0h+RzLCHAC+sONRLA/6CkStl0UZTuRxjrHM3HsJItd63qdoupvZCJT6BEgwrAC dd8mLHSVuiShgokS+uG1Fm6GAsRC7MuugPO+3QW53ogsr+OfrXzRIHA6u894yWnTn/2PDQsg1vVR3 i+/d/SXddJC4/Nc15pt2Iw3zncwB6dSBWBMks2GIEWXwrzVvQvg7iDB7Ga6EmnB2eEY+VqGTfWH3b 0ZN9VGOQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBHJU-005uPG-Qe; Wed, 04 Aug 2021 13:52:13 +0000 Date: Wed, 4 Aug 2021 14:52:04 +0100 From: Christoph Hellwig To: Chao Yu Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: Re: [PATCH] f2fs: introduce nosmall_discard mount option Message-ID: References: <20210730100530.4401-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210730100530.4401-1-chao@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2021 at 06:05:30PM +0800, Chao Yu wrote: > This patch introduces a new mountoption "nosmall_discard" to support > disabling small discard functionality, note that the mountoption can not > be removed by remount() due to related metadata should always be > initialized during mount(). Why does this need an option? It should be enable IFF and only IFF a SMR drive is detected.