Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Aug 2021 16:15:50 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     gregkh@linuxfoundation.org, phil@philpotter.co.uk,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: r8188eu: Remove wrappers for kalloc() and
 kzalloc()
Message-ID: <20210804131550.GL1931@kadam>
References: <20210802151546.31797-1-Larry.Finger@lwfinger.net>
 <20210802151546.31797-2-Larry.Finger@lwfinger.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210802151546.31797-2-Larry.Finger@lwfinger.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNXP275CA0016.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:19::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Wed, 4 Aug 2021 13:16:06 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f0ceb6cb-5310-4758-8a6a-08d9574a079c
X-MS-TrafficTypeDiagnostic: CO1PR10MB4483:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB448342A4F6A1F32D046593048EF19@CO1PR10MB4483.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RhXA5tj+gRItxFxL3a+JtEDnjDA+g7shO/80lDqo06sPjWJ0GUXTLbgWBHNDd77PdV8HOiktufTev9CrEFQ7NoqUgsqBP4F+I2O7hHV2RwWz0piogEqR+yFwMa3O14vt+oN+zBbdysSj02BZSq6JlAwSOHuzKoY18GOYCni0gt6+GUYIPTBYdyAiRklKgHk3aSeOtZvvtW9y+t1IzqMb41+zhpvJcfXG6hO0uERWqLFffksmt54ccI3lCQ3AoqNk2KBr+LCWeeRfb99X6P3OtvIZn1OahD9JJUuO0MHHg1JOSePweLTitC4qfTXbx4oOv8gF/HHUUk3ptstlqDZGKwWPGi5p+++SnKF6aYf8E8Pgu6BD6F6vciPXLIB8hsHCSsAJvUy6ACfVoSZbXkcHhofJ+ifLu+m4n6exnuKHHMafZeSlqNmZvaKTdoC0ubenL/L1KeMFhNaF1nBSrhRGjiwX8M6jwNCWyVp8QenGrGBnjo58z1ZN53jw65JOH91ywtFPTM0gGcg5HooWxCLgxhkFBwD1c2MAVZ7fON4VAWRiy77mKxkLI2wwxouTqrneobi0ZA4cuvRatkaFXdteMPNT20ocWqfedZSUatBGrCEeD7kKbprI7rdKNg/uxsevqbwzV+RNzMb607MGdXKh/McHDt9JyoG+ZpSAA/H/FuBMC7IU1zDyVVK7G2zSEX0L5dv8e6tPV2cM0RyWw0OVcA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(366004)(396003)(346002)(39860400002)(2906002)(55016002)(66556008)(6916009)(4744005)(83380400001)(66476007)(33656002)(8676002)(6666004)(956004)(478600001)(26005)(316002)(66946007)(1076003)(86362001)(52116002)(4326008)(33716001)(44832011)(8936002)(38100700002)(5660300002)(186003)(9576002)(38350700002)(9686003)(6496006);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iCc1qo6cSEZEoNew1nz8IUbbkiF+3kMaXb/TH9LsnC6rnnm1ow8spIKY1lIS?=
 =?us-ascii?Q?iTF7ECCtt29tqkhrygE3zb+AUx6UTMvmUVS34TvVjgH8O/YKKDCuZNgyOAxT?=
 =?us-ascii?Q?8CH/10JVUeToMK+B7B5Afl2Iv0Evy+ai9omH/DQTZX5LlNORP2qcEdI4jZHP?=
 =?us-ascii?Q?uU6z16xa3VQZW6Ha7lbOYwlrk3lapV8BrI7vUWTnN7UC/j72k5rX/J43+QIf?=
 =?us-ascii?Q?tDmYngFqCP6XtFCpRngPr670Ny+jk5zw4pX4LhQ+8JIhcMrnmXEiG9tbpobd?=
 =?us-ascii?Q?HIGjOQdjb7bUYz/xELyBhfH8FsfUqbb1kFhZZoNaMJcti9MyXv5a6v5EaiZM?=
 =?us-ascii?Q?s8oXbv3V6DdU9wKooT/M/Etr+67Wr/7Q/sQQ6lEMh52zHn0m/9UCF++Qhta9?=
 =?us-ascii?Q?GN4NQzm+sxL9+Jjv7sqEQO4I3Ta9Yu3xa58pDEVq0g6Lww5H9IzAHJuJ7zpO?=
 =?us-ascii?Q?PHastDwkTZdKhUk3hCyL5M+lS/BAlH/thT/lIKFI7j8L77X8wtzRdWZRP1hT?=
 =?us-ascii?Q?qJOIH8jxWTtE01EDmGtytp9z9mKSkR21zx2fxwt0/VQIuvrvOrkdvGwoUoqJ?=
 =?us-ascii?Q?vBtQLNl8A/tbFj5uDH44j+PsLmIMzL5CgkTU0C8E94Tq95TNPaoozDVWqKuU?=
 =?us-ascii?Q?iRYGOsDeinZv5s0N9CoV1wuS4Sq5BSJMVUrlZ7Bg0ZlrA5ponDa8agrGQXhN?=
 =?us-ascii?Q?vkeD+FpjAsodvrzjiW3yGZzOVPJUyHjghq6oQ7cBcoYvVhexrF4dS+9Ut2d1?=
 =?us-ascii?Q?9UOmYbbbXZfguIP0Dmv7n3HG75PiqArbmrg0Lov5q7AHkDzCoJVNTa3fb5a+?=
 =?us-ascii?Q?ZcD0gO9XbZHjol4/FJT53xt1zDDA0JQsiDgeGBdJzW4XmjQfs12LrY2D5a1k?=
 =?us-ascii?Q?ZPaCbYPZsdKqYqDBQ10l9YcrS6gNtOcJ9HE8iN2kee+2noQG7h443BDjaCrM?=
 =?us-ascii?Q?aaUbLYTsOqFhN/Ifq+JvYgLnV1tMP+5+OjUpQm1LalBjPcto4rc8xxAVxqoO?=
 =?us-ascii?Q?8ogdxFUyfvFYa7Vb6Q53EdepQoi/EJ3vdF44jXgp0yTkLWj+M3tzbCUCGX58?=
 =?us-ascii?Q?OLTqG0ZGkIXfGt1/mA6lg6WoPc1DydhNNpYMugsNiplCjei1D953S+wf+vEi?=
 =?us-ascii?Q?hzVb8caWQeGxo5yuJV0p0RgZeJowDjYAhfaOszG5mgPxb4kjJnGaXJZJATwq?=
 =?us-ascii?Q?EPDA6CIulwsSSDhrbzfPHgoQMJhQXUcwm/7kuM3fFegMxyS9VyjJP51eUk9c?=
 =?us-ascii?Q?vwHGzfDZYgTYO7EDUsJUeft81LiJmxYEkrs5pUzyrAsPJI76ddMfxey8GRNw?=
 =?us-ascii?Q?aa2EY51qRxKnU3XuLWqFEgf3?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0ceb6cb-5310-4758-8a6a-08d9574a079c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 13:16:12.1079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DvVdrnv135l878YHJhkFAXVxQJC93W1L1J0AW4rfZjCDXwQ9jMABXqCTtarGZur06Ky5jAPM3+WFz6sQAxzX21Pjqi/yNahH0ty6T1f03/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4483
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10065 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108040071
X-Proofpoint-GUID: QZbDr-jmSgqbrVgZtmM72giSkcx_-qzu
X-Proofpoint-ORIG-GUID: QZbDr-jmSgqbrVgZtmM72giSkcx_-qzu
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 02, 2021 at 10:15:41AM -0500, Larry Finger wrote:
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c.rej b/drivers/staging/r8188eu/core/rtw_br_ext.c.rej
> new file mode 100644
> index 000000000000..18113389acce
> --- /dev/null
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c.rej
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

;)  Something went wrong.

(I'm not going to review the rest of this series.)

> @@ -0,0 +1,11 @@
> +--- drivers/staging/r8188eu/core/rtw_br_ext.c
> ++++ drivers/staging/r8188eu/core/rtw_br_ext.c
> +@@ -420,7 +420,7 @@ static void __nat25_db_network_insert(st
> + 		}
> + 		db = db->next_hash;
> + 	}
> +-	db = (struct nat25_network_db_entry *) rtw_malloc(sizeof(*db));
> ++	db = kmalloc(sizeof(*db), GFP_KERNEL);
> + 	if (db == NULL) {
> + 		spin_unlock_bh(&priv->br_ext_lock);
> + 		return;

regards,
dan carpenter