Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp140942pxt; Wed, 4 Aug 2021 07:44:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJ+tw7dYOZUIGeyUszqdtcnjISNW+m/6Qk10QOriCdXObJmUewGF3dCFw7R02SJIqTZYEN X-Received: by 2002:a17:906:3948:: with SMTP id g8mr25703822eje.282.1628088271837; Wed, 04 Aug 2021 07:44:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628088271; cv=none; d=google.com; s=arc-20160816; b=rSmUl3IcWdJC2YYKw+/slM0Mj9j+Y8UkoKvVB0moO09ebeFu1115O0UBnylr918/0u nuNLxPI1lc+7DKY07R9ed9WzwQ5/5wfvAwPN8Urvw/6v5zFAjGHTPqRGrp/AqujeCJDA KGmaBmQXl/1cu5Lwu8hdIC4f4DFlcNU7mnHAF9MWax2wupqgwlWoWoRoUmqMpJPQ4SG3 nt7ml6a09ua4YDKoOOHb5dKMIfxo6AkJ8H7X/1ci3YyrSSDHph4Xw6vE3VXAZWzExj6E meIQ/nb8Z8/++pDq8Lui7k+68Vq7S7fRnVMOIlHBeCi6AHPpfHYtUyBZ/SBN/deCuIox jh8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=WeUoY1BHE+khzOxO4tMhyAM2qkxkuANqFKZ4FQX1bL4=; b=x9YNnJX6MVtthyr/pcw55DWKuTuXrYmuIQPH8FvOsCdFlwPHrJIYPLnLo3R1j4mwDI 9CMGIrOh5yz9ISO9zrLhM6YjY4q0+DE+/OBGYYLC5UlrGzIVZh62R07fjubUvRwgojUZ cAlpcCzlQwJ/2AW7IVaGib+RWvnzilmu7eS+ptxS2dxz5aZV0C3JwWU64kZ75ZMyK5n1 7Fi+cGhBdCEyIrYUrO34MkNlqF+GKsRE+2WzsEb4JtnInYoORAf97AXs7ovUNJO/BIsC eZGDgwReU3mo9b97iFyNe/yi+WSLkXilaWBmg50FxuAILi7rXMrf13qwo2PzR8YgjSQ+ SdRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GqW+Ix8b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si2647679edd.167.2021.08.04.07.44.07; Wed, 04 Aug 2021 07:44:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GqW+Ix8b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238680AbhHDOUa (ORCPT + 99 others); Wed, 4 Aug 2021 10:20:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:45122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238677AbhHDOUC (ORCPT ); Wed, 4 Aug 2021 10:20:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9BFC260F25 for ; Wed, 4 Aug 2021 14:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628086789; bh=UhV/SQfdLBYTc9D9nBIqPDxNpUescq5pja8sCC7bUhg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GqW+Ix8bE9Xpa1PchSe10rwy9phm1XMd4MtWpBN7X3eojLy8JN6KQp9n/43TFtwni 80y7yvlPbt9DWFp/kScILAMs5dZoVWsxp5peA10/x5cfZa5vObdwIDWpX0jkQFvYaT 2MgpL23FyoaDUNhgSS2nyNLYahv0fdWor9n5QSwmUSsJLUvt7JoCZyDZ33EVspregL jDwdyiYhAt5flGpgHfIHdpgTM1ACwW61TYHC6twk5Khz9kuXn/Gp2H4ZEQb28P8yN1 FPN6Bs7CKtVW8/Ig8CE1Yf1LpEy2t7/uIkXgk1gg65UZJGajHvq52xvBjKFLdOLOay vieUvKuAW7pSw== Received: by mail-wr1-f47.google.com with SMTP id l18so2460729wrv.5 for ; Wed, 04 Aug 2021 07:19:49 -0700 (PDT) X-Gm-Message-State: AOAM531zr1zDMgQC4yOe1lMn6VqX56TXtOXuqmk9/ljgL7TAcmrI4n/k uy0KebWAVi5vY9KC8YDcpqrtZZRIPTtylDzdhG0= X-Received: by 2002:adf:e107:: with SMTP id t7mr29131713wrz.165.1628086788270; Wed, 04 Aug 2021 07:19:48 -0700 (PDT) MIME-Version: 1.0 References: <20210804141049.499767-1-kherbst@redhat.com> In-Reply-To: <20210804141049.499767-1-kherbst@redhat.com> From: Arnd Bergmann Date: Wed, 4 Aug 2021 16:19:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices To: Karol Herbst Cc: Linux Kernel Mailing List , Lyude Paul , Ben Skeggs , Randy Dunlap , Daniel Vetter , ML nouveau , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > playing around a little bit with this, I think the original "select > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > drivers selecting and others depending on it. We could of course convert > everything over to depend, and break those cycling dependency issues with > this. > > Anyway this change on top of my initial patch is enough to make Kconfig > happy and has the advantage of not having to mess with the deps of nouveau > too much. Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE option itself 'default FB || DRM' though, to ensure that defconfigs keep working. Arnd