Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210719111737.47891-1-liuqi115@huawei.com> <41661d60-d8ef-9d50-57eb-8964c6f6eef8@huawei.com>
In-Reply-To: <41661d60-d8ef-9d50-57eb-8964c6f6eef8@huawei.com>
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
Date:   Wed, 4 Aug 2021 08:31:13 -0600
Message-ID: <CANLsYky2+D8cwquyX3iXgJtu6vND0gZZBtCL_vBobJ8pBwwvfA@mail.gmail.com>
Subject: Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory
 Buffer device
To:     "liuqi (BA)" <liuqi115@huawei.com>
Cc:     Linuxarm <linuxarm@huawei.com>,
        "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Coresight ML <coresight@lists.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 4 Aug 2021 at 02:05, liuqi (BA) <liuqi115@huawei.com> wrote:
>
> Gentle ping...
> Hi Mathieu and Suzuki, can you have a look at this patchset? thanks.
>

On August 2nd I got back to you privately saying I won't be able to
review this patchset before the last week of August or the first week
of September.  Pinging me again on it won't change that reality.

> On 2021/7/19 19:17, Qi Liu wrote:
> > This patchset add support for SMB(System Memory Buffer) device, SMB
> > obtains CPU instructions from Coresight ETM device and stores these
> > messages in system memory.
> > SMB is developed by Ultrasoc technology, which is acquired by Siemens,
> > and we still use "Ultrasoc" to name document and driver.
> >
> > Change since RFC:
> > - Move ultrasoc driver to drivers/hwtracing/coresight.
> > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
> >    basic tracing function.
> > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
> > - Address the comments from Mathieu and Suzuki.
> > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html
> >
> > Qi Liu (2):
> >    Documentation: tracing: Documentation for ultrasoc SMB drivers
> >    coresight: ultrasoc: Add System Memory Buffer driver
> >
> >   .../trace/coresight/ultrasoc-trace.rst        | 193 +++++
> >   MAINTAINERS                                   |   7 +
> >   drivers/hwtracing/coresight/Kconfig           |   3 +
> >   drivers/hwtracing/coresight/Makefile          |   2 +
> >   drivers/hwtracing/coresight/ultrasoc/Kconfig  |  12 +
> >   drivers/hwtracing/coresight/ultrasoc/Makefile |   6 +
> >   .../coresight/ultrasoc/ultrasoc-smb.c         | 722 ++++++++++++++++++
> >   .../coresight/ultrasoc/ultrasoc-smb.h         | 142 ++++
> >   8 files changed, 1087 insertions(+)
> >   create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
> >   create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
> >   create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
> >   create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
> >   create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h
> >
>