Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp257176pxt; Wed, 4 Aug 2021 10:18:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyG25MZoYrAh/RAZWY4svEmId7pr93AonkbTlJyr8FqGrsTshPt+TnAFFKWeZHIlpUb2TgZ X-Received: by 2002:a5e:8c19:: with SMTP id n25mr309364ioj.155.1628097527665; Wed, 04 Aug 2021 10:18:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628097527; cv=none; d=google.com; s=arc-20160816; b=XXNSCeZm9P+qgpw2Lpkt5cupuVPTQNpwHvqgq4IY6d0s7HwxI/VWotYOKO56Ai4aQz VZedhGsKm8daJZXkRCDpWFPXEd0alZx6GIO82EgPc6HvfO2zS31uCkU3QsVWs8uqA9Nh Ryy8kqzeVxik/CPpsEcglOs4oVZys3WROl124e01aOHLI2aCXzM1UmZDM+2ehq4Mg3MN yp7a1udM45uZ5Ihae8If2wqtt8Ebl5hFYv7jXFGWqw5x45pYc424i15HSCxGsNZ0Ik/I w4U6CihQe53Od+cSAc8w7S1zgSRs6wHUBOsVZCDMDctTFWpNlXcIP4anwdN3AJdGKSu+ iEqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CaFz/IDwaIRJoXlDsiXImSBbgXXC2Bl6JTD7oIlQAUg=; b=fKynHt4spMG1e44UZ7wQsT8gDLynOVKPK2Veh8R3jVnNE+90uc8lcKkD1yT4730M93 beAs6Hj7r7ab9ebIzVnpeosIvrNV6jvSJ1ALwaCINJKIxFl11aEnEIduVEZGi1IAQRGl Pc0uQ0w/Re46TMlg79Vk5KhD3qu4pbWuyoWg+RheGXVsYM/FV+InktpqemPXnIU3nnb9 tUXNt9DOyfzLAKqZ/ETCq6CLNE8I5lTf3+SXnCLlQoyjsyVkcZzXKPbqmN1/Pzld5esd ZbxzilyRdmAS7St9fVk26OL0eJYwq/ufP2kKP+WVV5ysW3FjIz/jsVTNPxEnIp0wRLhd fi/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g14si3067367jat.28.2021.08.04.10.18.36; Wed, 04 Aug 2021 10:18:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240007AbhHDRR3 (ORCPT + 99 others); Wed, 4 Aug 2021 13:17:29 -0400 Received: from foss.arm.com ([217.140.110.172]:35248 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239927AbhHDRRF (ORCPT ); Wed, 4 Aug 2021 13:17:05 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F2B2143B; Wed, 4 Aug 2021 10:16:52 -0700 (PDT) Received: from 010265703453.arm.com (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4026B3F66F; Wed, 4 Aug 2021 10:16:50 -0700 (PDT) From: Robin Murphy To: joro@8bytes.org, will@kernel.org Cc: iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, john.garry@huawei.com, dianders@chromium.org, rajatja@google.com, chenxiang66@hisilicon.com, Sai Praneeth Prakhya Subject: [PATCH v3 21/25] iommu: Expose DMA domain strictness via sysfs Date: Wed, 4 Aug 2021 18:15:49 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sysfs interface for default domain types exists primarily so users can choose the performance/security tradeoff relevant to their own workload. As such, the choice between the policies for DMA domains fits perfectly as an additional point on that scale - downgrading a particular device from a strict default to non-strict may be enough to let it reach the desired level of performance, while still retaining more peace of mind than with a wide-open identity domain. Now that we've abstracted non-strict mode as a distinct type of DMA domain, allow it to be chosen through the user interface as well. CC: Sai Praneeth Prakhya Reviewed-by: Lu Baolu Reviewed-by: John Garry Signed-off-by: Robin Murphy --- v3: Summarise the implications in the documentation for completeness --- Documentation/ABI/testing/sysfs-kernel-iommu_groups | 6 +++++- drivers/iommu/iommu.c | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-kernel-iommu_groups b/Documentation/ABI/testing/sysfs-kernel-iommu_groups index eae2f1c1e11e..b15af6a5bc08 100644 --- a/Documentation/ABI/testing/sysfs-kernel-iommu_groups +++ b/Documentation/ABI/testing/sysfs-kernel-iommu_groups @@ -42,8 +42,12 @@ Description: /sys/kernel/iommu_groups//type shows the type of default ======== ====================================================== DMA All the DMA transactions from the device in this group are translated by the iommu. + DMA-FQ As above, but using batched invalidation to lazily + remove translations after use. This may offer reduced + overhead at the cost of reduced memory protection. identity All the DMA transactions from the device in this group - are not translated by the iommu. + are not translated by the iommu. Maximum performance + but zero protection. auto Change to the type the device was booted with. ======== ====================================================== diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 55ca5bf3cafc..b141161d5bbc 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -3267,6 +3267,8 @@ static ssize_t iommu_group_store_type(struct iommu_group *group, req_type = IOMMU_DOMAIN_IDENTITY; else if (sysfs_streq(buf, "DMA")) req_type = IOMMU_DOMAIN_DMA; + else if (sysfs_streq(buf, "DMA-FQ")) + req_type = IOMMU_DOMAIN_DMA_FQ; else if (sysfs_streq(buf, "auto")) req_type = 0; else -- 2.25.1