Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp294115pxt; Wed, 4 Aug 2021 11:16:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOsW9/MbvV6Jz6gWMRGPBHLSfokjfq6rv5Qdp5cFiReWFTgr3RQUSeUOxmIssW6iao3/wm X-Received: by 2002:a05:6402:386:: with SMTP id o6mr1246340edv.294.1628101007960; Wed, 04 Aug 2021 11:16:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628101007; cv=none; d=google.com; s=arc-20160816; b=dwzkRoxq96VFAdorLR2vzsn198fVnI25z4mjlfgbzwZzMsLVpTyDwtt8Rm4t0emdMy Ol9I/RaIQomqyEymMYs3jGzH8L+EfOIfWl4jjNxstaKF3lXqEzkDypks94Gq8ZjJ/gYS bEYkR9XmJGOHQ9Mx2vPydih1gACN2oAJJ8/OEoGleTcMGdgndnaZPj5Tx7OE755TbhGR ON5Yx4kcqpmy7cJGjv4HBhvQOCiTbBEbYPPjIaLhAezsXp2J77+p89iAOA8MAA7yNmsG 0z7j42a4HEQJLgKedg1rMZaDC/dbTZZJxH6U3vy0at8ExhKQT0munmbADLSS2ePvUh+m itNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=YuW4ooVz490oOIDkjwxKhui8zvuzPIbvxJ13wfdvZ3Q=; b=QRdTpm/NVAhl1NMGFX60PU3Ghn5wETtot50CxbIVUB/eXd/OlfCUnhqXBBYfupGJcs hkTgtzfzMiUitdN193+DlvzcYdsiKjO7UwwTRX81HroM9drXmnSnuMJNcl9ZFgXxwtkV FnFnotwjUqrqTcB3KdHJbvN0SuuUycE25GAWs4K6KKPRuv+vhWqI3G94v44qPujNW3eI CqmYE9AUQ2NQTh0XlArbN81r7LGiqJL/z/1gd/u2pZdwDoEtcouJTL1Lcm3XoMXayOUk /lQBWyp62lWLNNjiZFZ3V4btxslVHMAwmEmOhqfhS6b0omF1G3+uz4mpva5PSTyeVi9b rEqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp41si3172270ejc.645.2021.08.04.11.16.23; Wed, 04 Aug 2021 11:16:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236698AbhHDOdF (ORCPT + 99 others); Wed, 4 Aug 2021 10:33:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236321AbhHDO3C (ORCPT ); Wed, 4 Aug 2021 10:29:02 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8342C0617A3; Wed, 4 Aug 2021 07:27:52 -0700 (PDT) Received: from guri.fritz.box (unknown [IPv6:2a02:810a:880:f54:adf4:1f5e:19c9:b75f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1321D1F43A34; Wed, 4 Aug 2021 15:27:51 +0100 (BST) From: Dafna Hirschfeld To: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: dafna.hirschfeld@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, mchehab@kernel.org, tfiga@chromium.org, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, hsinyi@chromium.org, maoguang.meng@mediatek.com, irui.wang@mediatek.com, acourbot@chromium.org, Yunfei.Dong@mediatek.com, yong.wu@mediatek.com, eizan@chromium.org Subject: [PATCH 5/5] media: mtk-vcodec: venc: Fail if a msg sent to VPU was not signaled Date: Wed, 4 Aug 2021 16:27:29 +0200 Message-Id: <20210804142729.7231-6-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210804142729.7231-1-dafna.hirschfeld@collabora.com> References: <20210804142729.7231-1-dafna.hirschfeld@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each message sent to the VPU should raise a signal. The signal handler sets vpu->signaled. Test the field and fail if it is 0. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/mtk-vcodec/venc_vpu_if.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/venc_vpu_if.c b/drivers/media/platform/mtk-vcodec/venc_vpu_if.c index 234705ba7cd6..8331b1bd1971 100644 --- a/drivers/media/platform/mtk-vcodec/venc_vpu_if.c +++ b/drivers/media/platform/mtk-vcodec/venc_vpu_if.c @@ -92,6 +92,7 @@ static int vpu_enc_send_msg(struct venc_vpu_inst *vpu, void *msg, { int status; + vpu->signaled = 0; mtk_vcodec_debug_enter(vpu); if (!vpu->ctx->dev->fw_handler) { @@ -106,6 +107,8 @@ static int vpu_enc_send_msg(struct venc_vpu_inst *vpu, void *msg, *(uint32_t *)msg, len, status); return -EINVAL; } + if (!vpu->signaled) + return -EINVAL; if (vpu->failure) return -EINVAL; @@ -122,7 +125,6 @@ int vpu_enc_init(struct venc_vpu_inst *vpu) mtk_vcodec_debug_enter(vpu); init_waitqueue_head(&vpu->wq_hd); - vpu->signaled = 0; vpu->failure = 0; status = mtk_vcodec_fw_ipi_register(vpu->ctx->dev->fw_handler, vpu->id, -- 2.17.1