Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp306016pxt; Wed, 4 Aug 2021 11:35:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQTTPiBbTbVSGAYsQsFOS/z7XLIqlMW3Wwl97zblGfOySPu9HRxsizW9ZgGVdwG6BFctcB X-Received: by 2002:a05:6638:306:: with SMTP id w6mr759471jap.132.1628102149172; Wed, 04 Aug 2021 11:35:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628102149; cv=none; d=google.com; s=arc-20160816; b=fDz3gNJAP9XN+rhVj0Cf+OdsqmIPpuCxBr8m+XvtQuW4PI7tuXQGryZVwto4myxg8Z ot7qCCle4ws99LKCfRn/heiIICoh8gpXZRkx6u3yrIQpdXaPtaO6ARkoQekuktWSdzPc Kc1lTWItRovDoFrjczexXmR0kVLO6iLQmvnd0QRleLhd17UNlbKCn3otpZEJX3cLr752 ygCA8G3YYXuWiEpgCK988HFUi+2kd9doX7utwSE7t/B/M6tUqWQQWOwOOz21crKPsAFy QPghG+WAFO3FzC3an5mnGj2TekPcYC3XsT+IO+7F1wePwca5DXu+Na4GoztIzo8kktQ0 +jKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=p13G5hjB0lh2ez0MhD0uRbutjU+B23xRd3QHmGNBmWA=; b=sQKJYtjc8/DK2DcEIvkbDLnXVsJcxo6VMmfBdAS5EwI6+1Z5l/av218VxEvU8OVigH t521F524uz8NHAgyoPAHvrB6tGmsoKOMQGZU7OtcZoD9ivXbg6srTD4GY5LMLYMgK5rJ taEKSlpyvwu6BW/rqcKwNZ0Umxw659MiPJJs8fvkZ/0jlsthoLRHSL/ud7rZRCnUarjc N2GOgRaa90FDJnI7FDLvghpKfh4KH96hSpRaoL4AoUr3y5cwySBt+piVardUyseUZg1z RmB98dKifOrjRFruNz9keR0Z0vZZoSiMP3I+Yixkr1V8SheZ63jBh4mpQQ3rcaXNPIZh sGhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si3077798ilj.118.2021.08.04.11.35.14; Wed, 04 Aug 2021 11:35:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238919AbhHDObS (ORCPT + 99 others); Wed, 4 Aug 2021 10:31:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238806AbhHDO24 (ORCPT ); Wed, 4 Aug 2021 10:28:56 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1269DC0617A0; Wed, 4 Aug 2021 07:27:50 -0700 (PDT) Received: from guri.fritz.box (unknown [IPv6:2a02:810a:880:f54:adf4:1f5e:19c9:b75f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 57E691F43A26; Wed, 4 Aug 2021 15:27:43 +0100 (BST) From: Dafna Hirschfeld To: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: dafna.hirschfeld@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, mchehab@kernel.org, tfiga@chromium.org, tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, hsinyi@chromium.org, maoguang.meng@mediatek.com, irui.wang@mediatek.com, acourbot@chromium.org, Yunfei.Dong@mediatek.com, yong.wu@mediatek.com, eizan@chromium.org Subject: [PATCH 1/5] media: mtk-vcodec: enter ABORT state if encoding failed Date: Wed, 4 Aug 2021 16:27:25 +0200 Message-Id: <20210804142729.7231-2-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210804142729.7231-1-dafna.hirschfeld@collabora.com> References: <20210804142729.7231-1-dafna.hirschfeld@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case the encoding failed, we should set ctx->state = MTK_STATE_ABORT, since this indicates a fatal error and there is no point to continue trying to encode in that case. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c index 416f356af363..1678c31bc9aa 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c @@ -1109,6 +1109,7 @@ static void mtk_venc_worker(struct work_struct *work) dst_buf->vb2_buf.planes[0].bytesused = 0; v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_ERROR); mtk_v4l2_err("venc_if_encode failed=%d", ret); + ctx->state = MTK_STATE_ABORT; } else { v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); dst_buf->vb2_buf.planes[0].bytesused = enc_result.bs_size; -- 2.17.1