Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH][next[next]] scsi: qla2xxx: Remove redundant
 initialization of variable num_cnt
To:     Colin King <colin.king@canonical.com>,
        Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210804131344.112635-1-colin.king@canonical.com>
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle
Message-ID: <7ac5f319-fd4c-f2e0-e318-71a4d7661693@oracle.com>
Date:   Wed, 4 Aug 2021 10:08:04 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20210804131344.112635-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.28] (70.114.128.235) by SN4PR0501CA0149.namprd05.prod.outlook.com (2603:10b6:803:2c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.5 via Frontend Transport; Wed, 4 Aug 2021 15:08:06 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 88a4768f-0d3c-4788-d327-08d95759aa11
X-MS-TrafficTypeDiagnostic: SN4PR10MB5542:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SN4PR10MB5542D7AE56B2B20240C673A1E6F19@SN4PR10MB5542.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UvD/ChHuhFUGt8Cl0qP5lfxwXivn2Hud+JieP4kHZZgDTGwRp0Ck91pMzoYN4C7H2VRt9FbAf5oxm+Fx2KkQZ6lCmxwx2JA5nbpG7g7aGhWmlbqQC0hUUJraPWvXURSDdABIlQGhyVoWQEmWiQNz1ME4YJMdBIBg04LLTGkTSU4m/PVXKc3OqOvV/R+LA33kmDi4cWDSXdNGhoo1kGdqdzKrJMItSwgMWRl9oIH2Zx85j0EBJDmuFqYgXx8Prrvx+8MeWPEDG0rc2YUJ2Ju1NDoh6Au1sg94X8KY18ES/IPvByyexs/b2MITFeikWczoFuP5oT/8Vkazsg4GX6SOxPzvTOWaeZ2yzOcPHI9VanIaNhaYnpWM96XoQbtEVMiPySWA7wKHNkaerr4jbh7yxaHW/4KQPMFB7/4PfxZPAndXcrOUhErCWgUhJSsPfvuJTHM2qDvQ127eJElBHVgpaBSJsRUk8X4BxoVnzgnNQIYONMdO0sRxnERXKZDjQZ6cBOminXy8zWbJ771wuXXDLwwxrXcRY5QrKKQaoyEga2YTaqqtzVwO1zzqwq8o0ty7QSqLhSj7UsdMf5nLU+GgbYNUaAi4bJ+vIEXwvwzBMe2Wpi3jybTr3CgRWHhgcRyp1wqR7fkP6YY4MPR3wz8Yy7vVaHyxJAaTEGeKCuFF9NjNv62kpXm0eCNZVhZ/3b/Rj07j3bjnWdnjZ7It9yCiDkfjltiYf+zTBqxXvsBj/lc=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB2943.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(39860400002)(396003)(366004)(376002)(16576012)(26005)(5660300002)(8676002)(956004)(31696002)(2616005)(86362001)(31686004)(66556008)(66476007)(186003)(6486002)(53546011)(478600001)(316002)(66946007)(4326008)(36756003)(8936002)(83380400001)(2906002)(38100700002)(44832011)(36916002)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGpnQWFMUDlJVDdkZ1Fkb3E0aFZBMVNubnZlcnB2QnFYYnh2S1A0Q29DNC9L?=
 =?utf-8?B?VjQxTG90Y2NveitPMDBrT3M1bTFIV2daNGFRTk5HdjZLR3N5K0ZCRzBQNExZ?=
 =?utf-8?B?M3B3WW9GVkxmK3V1ekFvdW9VeTdhQWttc1R1L1FZc20xUE11WnV6aXp0SFpx?=
 =?utf-8?B?V1FwazJVWW9YVlEzOFRHUmlzQWcrL0J5M3FhN1dOSm9YVlFpK0paY1VCZkNS?=
 =?utf-8?B?bDlIYjdMbXZyZThwWklUdW4yZHMxVFIySmsycDhRNDN5dE1XUEsvY2U0QVV1?=
 =?utf-8?B?S0VwbG1sVzVyM1AxSkczSTIxTkdMZDlRUWFHU3piNVFmV3M5ZWJKaXF0aFhE?=
 =?utf-8?B?bTF6czdJTFpIYWtNbnFXN2l6a3o3cERCRzRPTk1FTUg4Qk8xaVFBTWRuSXVt?=
 =?utf-8?B?VmE2L3d4OHQxdmpBNUdPVC9XcldtakF5U1dyUGk0dTNBeWk0dGN0dGI0OUkw?=
 =?utf-8?B?M0hwcGRxeFJxYmFvMm5ra3dPWWo1bi9iRmx1TnFOampnQUdZM1hQNkdhT0N5?=
 =?utf-8?B?MXM0ZUNucHNLT0VEb3ZlYmZzK1pza3NCdXVnTjljaG1IVkhiOFd0VHZXckVF?=
 =?utf-8?B?QTk3YkwrbWRYVm5XN2dnakJISHVyZ3BXK05tSEJFRmFhdlFRQ2d0bWg1M0xp?=
 =?utf-8?B?NGpGam9hcHFTU2NBVUtPdXZPTnBqY2ZQb0REcms4ZC9DN0paV1orVzBJcVdx?=
 =?utf-8?B?cnByU2h3ME9JVXlUOVIwRU5HVjkwSUxwNkFTanlqWWNzUXpNc3hRL1JWQnpy?=
 =?utf-8?B?OGhNd0pTaFMzSXY5dTkwWWVoeUhnSjRLNGExQkE0a0d4VFZCb2ZlNUQ0UzJQ?=
 =?utf-8?B?a253Uk9YZjVjZHh0YmZhOTUzSWJBQ1BJVUZtYVpVZllicHBybHZ2RWRRNVNm?=
 =?utf-8?B?RUFWTGJLWVNJK003T0VuSyt4eUgyVEV3cHhTRkJiVkxyWDE0MndkSi9FODlX?=
 =?utf-8?B?TUl5U3BUTUxxUUJaWnZndU14c0NRcjdzZ2tuU25HK0IzQkZIOGJxZnJIQ09F?=
 =?utf-8?B?TnVhbFRHcGIzblJIdndsSmQxM3owejVxZDlGVmQrNVJ2aWxMKzR1UDB5ck9V?=
 =?utf-8?B?NVA3Mmd6MnpwZVdHZXdLSHU4Z1Q3SUdoWWNNcTN1cFV3R0xPbjJGTUN5Mndq?=
 =?utf-8?B?SlNlY0xzT2pRNDdSUDJKMFRkZGR4YURwTVM1NEN6b3NnTlVLdjByY053dERU?=
 =?utf-8?B?SS9VLy8rWFdham1WVll4OFBaQmVLQUJPMy9acTl6dGRQaTVPSGg0a3Q0ZU5E?=
 =?utf-8?B?akdmWVFwMTdCUXpYcTdrTzJCTTY1NlQ2dm85MGhGZGxZbDhWYmtrTk9LQXY4?=
 =?utf-8?B?WWkwV1F3OHpVdXhDSTdGd2xKNVZhR0RodXhmei9KbGNXZUFjc0tmaFJNSzhW?=
 =?utf-8?B?V3llQzNEdTdORjBFUFBES3I2Vnp0c2lSd0tjQVNSZDgwTElQVWZ6N25tZzdx?=
 =?utf-8?B?K0I5cmNjeDVmUXIwczlFZk15b3g4MlBKTlJYR1UvWjl0OHB6NTZpMlo2a3Ns?=
 =?utf-8?B?NEJ1VzdEZXAvOVRNcXplblVKM2tXRDlhN2c2MHFSZDliN0ljM0lZSFc3bDl1?=
 =?utf-8?B?V2JRcFJuZ0h1UDZSKy8xck9lK2Y2dUdUSWVTU0F6Y2Jid0l3OXNQYWozWk1M?=
 =?utf-8?B?Ly9ZYUt3VWgrY3pVcU9pQnFYMGpESTJjNkZzV0MrVDRLbFp2eFlEUGNuOVQy?=
 =?utf-8?B?cnpadFRENC9JaXV3bW5CRlN2SVZLaUNuZW9VejJka1dja2taaW8veDhIOGx2?=
 =?utf-8?Q?sfuO15NQVJ+D3c6dUUoSrGL19lwi6//nWw180aZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88a4768f-0d3c-4788-d327-08d95759aa11
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 15:08:06.7895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U6Q2zt21zAa0b57E1Ao5m6b8QfV3sydBTAJpEd8Zvs68zZm3ZENZY0VQmeTNp8jV0vwUDrCbQirelMP9ZKSp4xLYdyt/xs7QAJvg61mc+nU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5542
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10065 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108040085
X-Proofpoint-ORIG-GUID: 19BxwP8XN50X5Lqz0RC9iXA0l6WC3AEF
X-Proofpoint-GUID: 19BxwP8XN50X5Lqz0RC9iXA0l6WC3AEF
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/4/21 8:13 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable num_cnt is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/scsi/qla2xxx/qla_edif.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
> index fde410989c03..2db954a7aaf1 100644
> --- a/drivers/scsi/qla2xxx/qla_edif.c
> +++ b/drivers/scsi/qla2xxx/qla_edif.c
> @@ -875,7 +875,7 @@ static int
>   qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
>   {
>   	int32_t			rval = 0;
> -	int32_t			num_cnt = 1;
> +	int32_t			num_cnt;
>   	struct fc_bsg_reply	*bsg_reply = bsg_job->reply;
>   	struct app_pinfo_req	app_req;
>   	struct app_pinfo_reply	*app_reply;
> 

Looks Good.

(I am curious if that extra "next" in patch subject was a typo or some 
workflow added that)

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering