Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp330777pxt; Wed, 4 Aug 2021 12:16:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCb30dXqbtAA74ZYkRmf6z7bO1DDsqepCBGobnN8R/F4IZ57LlqybqQOzAbaz9wRekJnj+ X-Received: by 2002:a6b:5d18:: with SMTP id r24mr727507iob.156.1628104608578; Wed, 04 Aug 2021 12:16:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628104608; cv=none; d=google.com; s=arc-20160816; b=k0x/5Vnc4pS+oHKr0dFuDiTMxIycvg0eAIfhBS9pVAhqX3sRjCcCM9bW2llEiA+CPk DneSlt5/1/p8Tt1kwhXg+/Nf+Qm04lqM4X9z/uJMb4yA4IMf8tB9pt63aNhuzBhWTwqV CDGVN8ZZSBy8n/MitxHFvOklD7BZi9+8pe91jc7ayoRPO4nM3zsTb6isZ/3IrZ660OG/ OtMu+XGsqOCMti8CIDxJpV7LRcUEgTtup8myfR96DO99+515PsO4vtAaBo42Y83VsQUj eDJwGoH5Z8pJRkdxT0PdPDyCoSWITpGfrFYygW8eusKBc817VEaa7Eyw1OimXvjDfo0w WxfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cBbGhANhkqMj3CLCTOt58CTUN/lC+y0kzjIEzA86Sgc=; b=HEDLdOvtB2WRcWFcxgZnu7VZgoBWj5BVCOOtCrO0NwrgNd+P3Bo1ey28996CICKYgx jVZ8KDH05qHglbTveIHHP91vbxdU4M4GVgQUBkcpIKCxlOfOXa9qIxH1c49TWNm+Llcl LREi8pfEYCjMnZAP8CNKADrwkyuMKziKxoT1mjIk0K5RtPaAhBdgXO2V1gqeEj06l2Tq 8k4wreg3Ef6cqu3inCP/vEVkKT5XlfV7aES0+hD2Tq2XH8HtO6dQw2y1MaNrLbETwxTY 58CKFQps1xnvV4dUHq2JqfdDvGm5xfgQuL9uF72BOJkn0U1hh/7/yguze+Dqsazr+eVt M8fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si3251506jat.15.2021.08.04.12.16.34; Wed, 04 Aug 2021 12:16:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239581AbhHDPwh (ORCPT + 99 others); Wed, 4 Aug 2021 11:52:37 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:38684 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239206AbhHDPwg (ORCPT ); Wed, 4 Aug 2021 11:52:36 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C331D1C0B7A; Wed, 4 Aug 2021 17:52:22 +0200 (CEST) Date: Wed, 4 Aug 2021 17:52:21 +0200 From: Pavel Machek To: Hermes Zhang Cc: Dan Murphy , kernel@axis.com, Hermes Zhang , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v3] leds: leds-multi-gpio: Add multiple GPIOs LED driver Message-ID: <20210804155221.GB25072@amd> References: <20210329055847.13293-1-chenhui.zhang@axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ftEhullJWpWg/VHq" Content-Disposition: inline In-Reply-To: <20210329055847.13293-1-chenhui.zhang@axis.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ftEhullJWpWg/VHq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Hermes Zhang >=20 > Introduce a new multiple GPIOs LED driver. This LED will made of > multiple GPIOs (up to 8) and will map different brightness to different > GPIOs states which defined in dts file. >=20 > Signed-off-by: Hermes Zhang Thank you, it looks simple and mostly ok. Acked-by: Pavel Machek But it really needs to go in with devicetree documentation changes, and they need to be acked by devicetree maintainers. If you have that, please send it in series. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --ftEhullJWpWg/VHq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmEKt7UACgkQMOfwapXb+vLJywCgiemcjYUjxfA4EdkBgJQdrtR0 HRoAn1xk+ExD8HSuIE0ahTIgAQ2IWYnd =tLaS -----END PGP SIGNATURE----- --ftEhullJWpWg/VHq--