Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp56637pxt; Wed, 4 Aug 2021 15:40:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGemBL2IPjokpbnKHT8qOXpR6XqIZ8FcSyU20l3qq3W3kmM08pEwDkYUTsTWw38mq+Ttmg X-Received: by 2002:a17:906:8a66:: with SMTP id hy6mr1338882ejc.309.1628116804428; Wed, 04 Aug 2021 15:40:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628116804; cv=none; d=google.com; s=arc-20160816; b=MeJlNYLeUKJFd6u13OUhjpCAi3SBYNx1NlDFwNUn9k5bGq8j3wF3uWiIU7jlFaLyTu yzBKleYalugjzubZ7s/bOR8DaqMQsLe9Cv50Q3KFKa01FU8DcVHzwOV3ZqQiDdwArTFc ZKiMgtfXZVXDQrW2vwZAmj3XidHg4p+5NAsHyZji0gnArrm4NQEAkQTtBBKr4hENWA2f YIk+LCJtfqkdTd0J8ReqDwHhBVJMTJ9EMspRHczwz4XsjLO6kviJHolKQaZNA+FWVLN2 Q4EoXTBdKav7bY6AWCxsXRXWvgbAT4yQwYvpA7/zAnZPTPGchY/8BsxDUnnLrjqsT2MA sv2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :dkim-signature; bh=Pb12EbU06/c4uVcHA6PnZi5HH8DX1Z5yrhOe7RMfqqs=; b=WgK2hbbKAg8a3EKDaHQRciJIxkUc+/+5Y2xxoaqmoydb7RDHbfTPzslM0oToQjgpor uwNeRT9elEB1Gnh3fimu/LCpb0hnSp4rnf5UC477Q2mZfcjyqY6wu9w5J+w86JOVSizp 6HyQjj6AWLCDxwd4MVb3Zyd+WmdbVogQVlDOHkkr7Q6c5pa7e6All+M/UY3+QEsFGySw afYW7aZI/Wq5Fig7EDreftma6ziVXDw7zXFBiE4AMgPWgWQCfIOgS+XG7+kGhuXj6ctd az9WF7UNs9hUNacxa+u6gRzygWYycEHpY0JgbbdDA9k4+/dGoPTIrA4MrZgMQq0xGkTe AEKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=rVcP18G6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk18si3228231edb.28.2021.08.04.15.39.41; Wed, 04 Aug 2021 15:40:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=rVcP18G6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231893AbhHDVnx (ORCPT + 99 others); Wed, 4 Aug 2021 17:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbhHDVnw (ORCPT ); Wed, 4 Aug 2021 17:43:52 -0400 Received: from mail-qk1-x749.google.com (mail-qk1-x749.google.com [IPv6:2607:f8b0:4864:20::749]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B4AAC0613D5 for ; Wed, 4 Aug 2021 14:43:39 -0700 (PDT) Received: by mail-qk1-x749.google.com with SMTP id e11-20020a05620a208bb02903b854c43335so2868383qka.21 for ; Wed, 04 Aug 2021 14:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=Pb12EbU06/c4uVcHA6PnZi5HH8DX1Z5yrhOe7RMfqqs=; b=rVcP18G61i62cfcA5J1OwAZ5xcfbbwinKlYYRIG0v+c+YMvnKA1w6xawMCCJV5CS7p 4p053u+v5L+Kra5xP+9qUWJ64eL0hrUP9YqUh8UVdOVoTVcSKpiA6EnC5JYyw/pMzOBC YkP1Rb8ve0dLLAe/aUSEHKQX8Mv7dYWy8WQmD0Kc+C5wQs9uIXPhEUaAMGyY2bGq+bXw pqTZgC5QcokVFPC6/oyGnhyouTwHsWY+GZgPeMxB6PMQg4E9SWkyGGl0zpUA6KX5HwdG 5BJuw8uEeN1nfmdZ1fbP6qYK9JIS4HAIh1Eopsg2YotgR84XuazpdacrfSoRFT5DJL6s 8ByA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Pb12EbU06/c4uVcHA6PnZi5HH8DX1Z5yrhOe7RMfqqs=; b=F4lA++u+B0rKKSq+jv5tfgQJnOL0AIDIzQ5S++O7jWS5XwCoPZGP/qxHbP9HL3J0RU 15ohB9o/Im2cDDlO7AV/dWhmWD/4Jb/JqdJNxB3Yr2pJMUsrNyi+rQIUsydm1MUaT9Y/ ZyncArAZhjE2Xs+2x5ZpB05rU3i/ejuYM6Nwg+ejqx22TIBTy5eLY8m2I891GZBy+gcT g+9ZEa04PJiVQWFrBf+F8MCq0ErOpcQidkxmX+AJOucZyFpgHq3XRpFsZY+AWPlbjthq oYDTP575LGsD/C/p3EvL7KVefhaf0x3DGu1XkxhZtVrCa0T0kpJrnqET2zqguV4y7ExA RAbw== X-Gm-Message-State: AOAM532+QQYqS5hfswappV6O6SaoFbUYGBmWaBep6JMX/uxCMQKaM39w F0t+7VLIjpAolkvP+9Jbjr3pmDpiy1hlg04= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:ffe5:1245:526e:3189]) (user=saravanak job=sendgmr) by 2002:a0c:f807:: with SMTP id r7mr1741921qvn.14.1628113418097; Wed, 04 Aug 2021 14:43:38 -0700 (PDT) Date: Wed, 4 Aug 2021 14:43:29 -0700 Message-Id: <20210804214333.927985-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.32.0.554.ge1b32706d8-goog Subject: [PATCH v1 0/3] Clean up and fix error handling in mdio_mux_init() From: Saravana Kannan To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski Cc: Saravana Kannan , Marc Zyngier , Neil Armstrong , Kevin Hilman , kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series was started due to -EPROBE_DEFER not being handled correctly in mdio_mux_init() and causing issues [1]. While at it, I also did some more error handling fixes and clean ups. The -EPROBE_DEFER fix is the last patch. Ideally, in the last patch we'd treat any error similar to -EPROBE_DEFER but I'm not sure if it'll break any board/platforms where some child mdiobus never successfully registers. If we treated all errors similar to -EPROBE_DEFER, then none of the child mdiobus will work and that might be a regression. If people are sure this is not a real case, then I can fix up the last patch to always fail the entire mdio-mux init if any of the child mdiobus registration fails. Cc: Marc Zyngier Cc: Neil Armstrong Cc: Kevin Hilman [1] - https://lore.kernel.org/lkml/CAGETcx95kHrv8wA-O+-JtfH7H9biJEGJtijuPVN0V5dUKUAB3A@mail.gmail.com/#t Saravana Kannan (3): net: mdio-mux: Delete unnecessary devm_kfree net: mdio-mux: Don't ignore memory allocation errors net: mdio-mux: Handle -EPROBE_DEFER correctly drivers/net/mdio/mdio-mux.c | 37 ++++++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 13 deletions(-) -- 2.32.0.554.ge1b32706d8-goog