Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 04 Aug 2021 21:33:22 -0400
From:   "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Subject: [PATCH] pipe: increase minimum default pipe size to 2 pages
To:     linux-kernel@vger.kernel.org
References: <20210805000435.10833-1-alex_y_xu.ref@yahoo.ca>
        <20210805000435.10833-1-alex_y_xu@yahoo.ca>
In-Reply-To: <20210805000435.10833-1-alex_y_xu@yahoo.ca>
MIME-Version: 1.0
Message-Id: <1628127094.lxxn016tj7.none@localhost>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Length: 2488
Precedence: bulk

Before this patch, the following program prints 4096 and hangs.
Afterwards, it prints 8192 and exits successfully. Note that you may
need to increase your RLIMIT_NOFILE before running the program.

int main() {
    int pipefd[2];
    for (int i =3D 0; i < 1025; i++)
        if (pipe(pipefd) =3D=3D -1)
            return 1;
    size_t bufsz =3D fcntl(pipefd[1], F_GETPIPE_SZ);
    printf("%zd\n", bufsz);
    char *buf =3D calloc(bufsz, 1);
    write(pipefd[1], buf, bufsz);
    read(pipefd[0], buf, bufsz-1);
    write(pipefd[1], buf, 1);
}

Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
---

See discussion at https://lore.kernel.org/lkml/1628086770.5rn8p04n6j.none@l=
ocalhost/.

Patch resend to linux-kernel@vger.kernel.org (typoed email last time).=20
Sorry if this messes up your mail clients.

 fs/pipe.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/fs/pipe.c b/fs/pipe.c
index 9ef4231cce61..8e6ef62aeb1c 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -31,6 +31,21 @@
=20
 #include "internal.h"
=20
+/*
+ * New pipe buffers will be restricted to this size while the user is exce=
eding
+ * their pipe buffer quota. The general pipe use case needs at least two
+ * buffers: one for data yet to be read, and one for new data. If this is =
less
+ * than two, then a write to a non-empty pipe may block even if the pipe i=
s not
+ * full. This can occur with GNU make jobserver or similar uses of pipes a=
s
+ * semaphores: multiple processes may be waiting to write tokens back to t=
he
+ * pipe before reading tokens: https://lore.kernel.org/lkml/1628086770.5rn=
8p04n6j.none@localhost/.
+ *
+ * Users can reduce their pipe buffers with F_SETPIPE_SZ below this at the=
ir
+ * own risk, namely: pipe writes to non-full pipes may block until the pip=
e is
+ * emptied.
+ */
+#define PIPE_MIN_DEF_BUFFERS 2
+
 /*
  * The max size that a non-root user is allowed to grow the pipe. Can
  * be set by root in /proc/sys/fs/pipe-max-size
@@ -781,8 +796,8 @@ struct pipe_inode_info *alloc_pipe_info(void)
 	user_bufs =3D account_pipe_buffers(user, 0, pipe_bufs);
=20
 	if (too_many_pipe_buffers_soft(user_bufs) && pipe_is_unprivileged_user())=
 {
-		user_bufs =3D account_pipe_buffers(user, pipe_bufs, 1);
-		pipe_bufs =3D 1;
+		user_bufs =3D account_pipe_buffers(user, pipe_bufs, PIPE_MIN_DEF_BUFFERS=
);
+		pipe_bufs =3D PIPE_MIN_DEF_BUFFERS;
 	}
=20
 	if (too_many_pipe_buffers_hard(user_bufs) && pipe_is_unprivileged_user())
--=20
2.32.0