Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Qin, Chao" <chao.qin@intel.com>
To:     John Ogness <john.ogness@linutronix.de>,
        Joe Perches <joe@perches.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
        "bigeasy@linutronix.de" <bigeasy@linutronix.de>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>
CC:     "mgross@linux.intel.com" <mgross@linux.intel.com>,
        "Mei, Paul" <paul.mei@intel.com>, "Li, Lili" <lili.li@intel.com>,
        "Qin, Chao" <chao.qin@intel.com>
Subject: RE: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep
 in pr_flush()
Thread-Topic: [PREEMPT_RT][PATCH] printk: Enhance the condition check of
 msleep in pr_flush()
Thread-Index: AQHXfEaHiU7PgYfePkWUMKzzHnOuTatLw7eAgAAjuoCAGGuFwA==
Date:   Thu, 5 Aug 2021 03:01:20 +0000
Message-ID: <DM6PR11MB380275B5125531E8EB9D019B92F29@DM6PR11MB3802.namprd11.prod.outlook.com>
References: <20210719022649.3444072-1-chao.qin@intel.com>
 <ea6c6a2b5482d62038d7d0a1d46b87665051222f.camel@perches.com>
 <87o8axm6ae.fsf@jogness.linutronix.de>
In-Reply-To: <87o8axm6ae.fsf@jogness.linutronix.de>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/xU5gUlnqw49f2xsS99SKxmAA7UdRjp6Hem6mIJ8jbFWesNzExnOyNfwtWwT?=
 =?us-ascii?Q?QBtiluMyTZub1uiVnSLAs/fmksbdCnx7wxLVhTIo6iL+v1AVj64db2l9vehH?=
 =?us-ascii?Q?jxWKsI61yn33YTTLuMp/SmBkglfmhfcMK36Z0ErkRujVR87iu+kCiLIql7JC?=
 =?us-ascii?Q?GFp9WVLtboFXeqtq0wd8N1qjVRnER6f87ZrNSUuokMwI0Xeh+1sIc+f5YvW8?=
 =?us-ascii?Q?ia5q7ISbvAt4sWGhoMIodc3NLeLE8XUhMCyOeuzeGW+lUnLaA0txFOylJDj7?=
 =?us-ascii?Q?BcwxOpdpEKLY1tOw0xIKBmAwNf35MrI4cWiOg57gTHi4PPaw28JQ7GO9e2aZ?=
 =?us-ascii?Q?wQbSKnnVQoCxevHeVlwGupR5ABIk8EMDAXpX9pL07l6uqWY7C3FIGsraT+td?=
 =?us-ascii?Q?Nsx0ywTmc0pnO2YX3d3UfNxHyObebw7onSXE2hiRivtyHzfM/zWpb+gKnhnf?=
 =?us-ascii?Q?IvyTuB8LwlzUCEa5LQnCf3+0shAii14mNK+TFfN2pzZu+askv0rtAYFqhdQK?=
 =?us-ascii?Q?Wc2ivoSa/mrhAw2B2vHWgw4NtrU75mGkwpIOUkVrvAvEMOMkFS+czV2voqIO?=
 =?us-ascii?Q?w2d+TyT31+3yaHJWlbQ9/Lj2pA7Ifxn2rhNQ47jrY4HsHmo9jLPmF/KnczvK?=
 =?us-ascii?Q?d8wATbKjh0hCaD55xxpfkAsBw9GZQPBgt/P7oKLnRM7N+2IsGGHpqMFz82yV?=
 =?us-ascii?Q?J8bzn6jIZOPCWF+BUZlUN0VzhD3yvTzulhZgtRCIV8JFIHbsFqdpoqiP2reB?=
 =?us-ascii?Q?0wiKy7UqTSqs4xUEx9swsFuEcmnAyKE8+c4zvYeSVMKnlbhIx+9FJ31U7HQk?=
 =?us-ascii?Q?ZzhZTjnbkrn2etTIQbZI3H0ShrC/Ve0HcDc+s5KswZejfeB6qhYJHRQcdBxB?=
 =?us-ascii?Q?aYhBLI/SZd1XTYfgQl/LKBg2VPeUs3FFANawHB1lvRwEez+IcE0vF7uEnxVD?=
 =?us-ascii?Q?r8/emeEW8WmS7mB0kYeCRlrbSHtbxy947Qn99jv88sWqKOLqjeevW0S/fKuk?=
 =?us-ascii?Q?tcgB20kdLNnOkPCG9u73UflT/2VV8dq+kdYAusfu5Eu1a7wR5uq0SWv2LPt7?=
 =?us-ascii?Q?JXBtyy9A2sJ5QgPEqY2+XqDtBoszDM12fdihtZ6F/Ixr/SZRMGHBDeOLFUWv?=
 =?us-ascii?Q?8XgDWLwiAGEMHCW/3zbrCgT+HF95aFWN9QS/v3HyEzhEUiW8LqSxILgrn+bC?=
 =?us-ascii?Q?jRaMQnQbXOZnHT5vxSXQy/pyLM1EY7TDW1I7YeJR36bXo9eqUIjK0Y+EOoAv?=
 =?us-ascii?Q?cXup232ShFl8fwaXCi/Qlije2MsOTCY+XbDJ2NfDF9qg8Pk+CdhaJ+nInXeb?=
 =?us-ascii?Q?Dp4adhnp6gov7uDgnX60a6fb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3802.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 863588b2-53f7-40a5-96a1-08d957bd4d4c
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 03:01:20.6086
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ok4DBoFdW5shgRJWK9XnNw9y4MPBxIW+ykrIn9BRnHVP6l+laAA3TstwDxhzAquHfbhzGISEBQiCu35Y8I7k+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1963
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi John Ogness,

Do you have plan to backport this fix into v5.10.y-rt kernel?

Thanks,
Qin Chao.

-----Original Message-----
From: John Ogness <john.ogness@linutronix.de>=20
Sent: Tuesday, July 20, 2021 10:03 PM
To: Joe Perches <joe@perches.com>; Qin, Chao <chao.qin@intel.com>; linux-ke=
rnel@vger.kernel.org; linux-rt-users@vger.kernel.org; bigeasy@linutronix.de=
; tglx@linutronix.de; rostedt@goodmis.org
Cc: mgross@linux.intel.com; Mei, Paul <paul.mei@intel.com>; Li, Lili <lili.=
li@intel.com>
Subject: Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msl=
eep in pr_flush()

On 2021-07-20, Joe Perches <joe@perches.com> wrote:
> Logic continuations are typically at the end of the previous line.
> And there are few too many parentheses for my taste.
>
> Maybe exceed 80 columns in a single line
>
> 	may_sleep =3D preemptible() && !in_softirq() && system_state >=3D=20
> SYSTEM_RUNNING;
>
> or align the continuation
>
> 	may_sleep =3D (preemptible() && !in_softirq() &&
> 		     system_state >=3D SYSTEM_RUNNING);
>
> or use individual lines
>
> 	may_sleep =3D (preemptible() &&
> 		     !in_softirq() &&
> 		     system_state >=3D SYSTEM_RUNNING);

The kernel now has a 100-column policy, but I decided to go with this third=
 variant for easy reading.

Chao Qin, your patch will be part of the next PREEMPT_RT release. Thank you=
.

John Ogness