Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] perf vendor events: Add metrics for Icelake Server
To:     Ian Rogers <irogers@google.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
References: <20210721070702.2075-1-yao.jin@linux.intel.com>
 <2811bea3-4589-2f76-83b4-83b91f4db1c6@linux.intel.com>
 <85e07b9a-c826-b4cc-188a-4e735d7342bc@linux.intel.com>
 <CAP-5=fUGzso7f2rGG5_YkuOr72qY5EmkckDsayb47vLHxhJ9FQ@mail.gmail.com>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <1838b532-19b4-6f92-0057-d71bfa740a3c@linux.intel.com>
Date:   Thu, 5 Aug 2021 13:42:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <CAP-5=fUGzso7f2rGG5_YkuOr72qY5EmkckDsayb47vLHxhJ9FQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Ian,

On 8/5/2021 1:09 PM, Ian Rogers wrote:
> Hi,
> 
> I'm not sure what's happening but when I generate this using:
> https://github.com/intel/event-converter-for-linux-perf
> 
> I see here:
>          "MetricExpr": "1 / IPC",
> 
> There are various other differences and so I've included the generated file.
> 
> Thanks,
> Ian

Please see following commit in event-converter-for-linux-perf repo.

commit b2265b953d57130a2ad8255d126bb69cf8552898
Author: Jin Yao <yao.jin@linux.intel.com>
Date:   Thu Jun 3 09:57:01 2021 +0800

     Don't expand inner metric if possible

     Before:

         {
             "MetricExpr": "1 / (INST_RETIRED.ANY / CPU_CLK_UNHALTED.THREAD)",
             "BriefDescription": "Cycles Per Instruction (per Logical Processor)",
             "MetricGroup": "Pipeline",
             "MetricName": "CPI"
         },

     After:

         {
             "MetricExpr": "1 / IPC",
             "BriefDescription": "Cycles Per Instruction (per Logical Processor)",
             "MetricGroup": "Pipeline",
             "MetricName": "CPI"
         },

     We also provide a new option '--expr-events' for checking if it's a complex
     metric. For a simple metric, we probablly don't need to reuse the inner
     metric. For a complex metric, it's useful to reuse the inner metric.

I enable the option '--expr-events' when generating the metrics JSON. Since CPI is a simple metric, 
so the inner metric is still expanded.

For cstate metrics, only Core C1/C6 and Package C2/C6 are supported for ICX. The cstate metrics are 
appended manually right now.

Thanks
Jin Yao