Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp296556pxt; Wed, 4 Aug 2021 23:20:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZhWw82ZV9jeKD4xhauI1D8NjKrgmjS9/580JN7BdAMpfmrAu7BvD3/+jXpo4Nr6O+D6rO X-Received: by 2002:a05:6402:1202:: with SMTP id c2mr4387915edw.216.1628144399851; Wed, 04 Aug 2021 23:19:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628144399; cv=none; d=google.com; s=arc-20160816; b=oHpIlg2Pm949yzvtlGMvOhOU6HYDzkX/CPRGAJYxwffNktvcoU3pZi6Jzk4EWoONks rBntiBKLcKwCrGC/qakZBpBfCqeJDJKBJgtv1ukFbLMuEmNZEmYmjAyFBnhb+5bdexiX nH7FegjCnTabzFpDd5vX7OY6n6pLWZnlOpTm/FN5XPHj0nB6H6ivro5yYm+MToFANejb 7otb6R0a2FWdM8qihhGqZJbLNmZU+Y2gcYjykNUuIGHUmbVo6Pu3Hu1TAuGk/jUHXuJn CktNY18FWemYvgt9aqmFnIiL8Z1yvWucwzHZKsc06cn/Wg62OGSsCN0DDKezPZmeNneO ZjpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=83ejBFxG6PpaqEIAxOQakS7CpkA8CGMBWmlvjt7MCsA=; b=moFU8g3iA2wUqtI2KwgzF8+VMDT3sH1SKnWPkA80jeIeN+dnLKmT/frDzJP3qPb+MH bp/OpmL+n/4+/o3pDFQJWhj3Z16ZdnoeMegEphPXICOyTsTCII2+hLO6Ey4UtnoZso1J s6H22ytyUHTi2BrwaCMJEeMTw0cy7u6yNp0oxrgA/Z6oQkRCGvCgQCpkTShsvzO6Lzl+ VBgoDp3TXbYl7wHdvwv0H7kqjtYyrlV3x1uh2lCYYcQtYCzWu06PVGPB8hJ21pu43idG EAyAo7h7z2+ql2pj97yttuF9XsWOQhhwL0AqI+qpQuPxzDke6Gk6LWTQiBn8O47eNhZb s2bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=dfQCdwfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si5059066edx.8.2021.08.04.23.19.34; Wed, 04 Aug 2021 23:19:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=dfQCdwfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbhHED1k (ORCPT + 99 others); Wed, 4 Aug 2021 23:27:40 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:54669 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238476AbhHED1k (ORCPT ); Wed, 4 Aug 2021 23:27:40 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1628134046; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=83ejBFxG6PpaqEIAxOQakS7CpkA8CGMBWmlvjt7MCsA=; b=dfQCdwfCH7R9COxYwJ+Lj1oOxwFBbB6B0zudcs1COFvGvDwuja3DTqq8yatBuxa276hFUwKI wGSkCvkY1rlp+6JPew2NJmNbnX/6BUgBoDwj1HM+5pNXpKReMUzUHq+8+zXXvqPxjEs8MmsC iWkzmw9dVCW7+ZeOyvK6SDLHf4M= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 610b5a9e041a739c46268661 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 05 Aug 2021 03:27:26 GMT Sender: rnayak=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5129CC4360C; Thu, 5 Aug 2021 03:27:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.1.102] (unknown [49.207.220.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rnayak) by smtp.codeaurora.org (Postfix) with ESMTPSA id 62504C433F1; Thu, 5 Aug 2021 03:27:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 62504C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=rnayak@codeaurora.org Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2 To: Konrad Dybcio , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, skakit@codeaurora.org, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org References: <1628082199-17002-1-git-send-email-rnayak@codeaurora.org> <1628082199-17002-3-git-send-email-rnayak@codeaurora.org> <0cb8bf79-697c-ff16-e37e-d1c783f8a207@somainline.org> From: Rajendra Nayak Message-ID: <8aaef1a2-269d-1077-7996-793045a04f7c@codeaurora.org> Date: Thu, 5 Aug 2021 08:57:18 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <0cb8bf79-697c-ff16-e37e-d1c783f8a207@somainline.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/2021 1:17 AM, Konrad Dybcio wrote: > > On 04.08.2021 15:03, Rajendra Nayak wrote: >> Move all the common device tree bits for both sc7280 IDPs into a >> sc7280-idp.dtsi and create 2 different dts files (sc7280-idp.dts >> and sc7280-idp2.dts) in order to manage differences across the >> IDP SKU1 and SKU2 Boards. >> PMR735A is present on IDP board only and is not present on IDP2. >> >> Signed-off-by: Rajendra Nayak >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 328 +-------------------- > > I'm still for calling this sc7280-idp-sku1/2.dts, but other than that it looks good. sure, I'll just wait for others to chime in, and if that's the consensus I would be happy to re-spin. > Reviewed-by: Konrad Dybcio Thanks. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation