Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp302193pxt; Wed, 4 Aug 2021 23:30:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwANybGWlL/JG1AJ5XMxttMe7JedKSB/RafPmA4DV2x8shGjfagxrrhAE8Qur1V8c34r+TB X-Received: by 2002:a92:c781:: with SMTP id c1mr711042ilk.234.1628145051349; Wed, 04 Aug 2021 23:30:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628145051; cv=none; d=google.com; s=arc-20160816; b=k2lNOMJ93nAzmD+1o/bnWJobjnsEaw/amqKi9VwVM/mhADyRjGJSc9zq6LQfrEqTyC KkvRe398xY2IvUCzYQ/wqf3DMWZEbNiQn7bKMMvzf5lRbxBZxvmhbndoD0TvqElmZ0eP Os85JvzPgt72OPHKvk/a6b+G3iYdZKSj7+wKRNCvUHfZ8ex4efi8/7l+W2SsCrL6SCip 4jgNpzZxVDddXF4Oxyeyn23Q0vHybhFCdoHUnXq1tfUvtUuhpJlCDp8RAfbq1XeQTSMG 39JvuE6IiC6hkDALpbzM7Pf3uHPpx41pqtODjtpjT1j5eeObzjDuZS0DHi12VBA9pRDg mNOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=a016iCZyUrTnnDBSIOMmZ2Kon/VUjPjdJI8cm3KZEoA=; b=SwVqHeMJ7rglfMu0UBLEo1InzRsQEbxIj4CTrjcVM16Rm/qZBbmTQmin0B9brPwxVi f4j+7KEg74SQjk/oE/vdtcaMG5YJ/SoYn60MvOXmUdF09DMxCQlasEPGFZkR4yeg+6D5 IGa9lwAQ++5+rW0waa9RoC6kgqk5iZ+kvX2r2OUm+gI0S7y7zjS+4y3C3CG4wgAZfphH vx5K+nh5Ef8lIsQGoBYtIqBrTklVQwHqGoCDtImqpryiezampOQ70PW/FEAl1pn4Arw6 9cva4WBtdnx8hC3U8kMkJ7MbS3o/hYKpnOmxDf6LTIr/GL8VInX6XS7JyJ4cYyPKcHpu gszA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g6si4164547ioc.2.2021.08.04.23.30.37; Wed, 04 Aug 2021 23:30:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235417AbhHDWu4 (ORCPT + 99 others); Wed, 4 Aug 2021 18:50:56 -0400 Received: from www62.your-server.de ([213.133.104.62]:46792 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235323AbhHDWuy (ORCPT ); Wed, 4 Aug 2021 18:50:54 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mBPia-000Gcu-Dn; Thu, 05 Aug 2021 00:50:32 +0200 Received: from [85.5.47.65] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBPia-0004r6-3I; Thu, 05 Aug 2021 00:50:32 +0200 Subject: Re: [PATCH bpf-next] samples/bpf: xdp_redirect_cpu: Add mprog-disable to optstring. To: Matt Cover , Kumar Kartikeya Dwivedi Cc: Alexei Starovoitov , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Lorenzo Bianconi , Matthew Cover , netdev , bpf , LKML References: <20210731005632.13228-1-matthew.cover@stackpath.com> <20210731152523.22syukzew6c7njjh@apollo.localdomain> From: Daniel Borkmann Message-ID: <4922e491-46c2-fa85-e10c-79b0ffe476c7@iogearbox.net> Date: Thu, 5 Aug 2021 00:50:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.2/26253/Wed Aug 4 10:20:49 2021) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/21 7:57 PM, Matt Cover wrote: > On Sat, Jul 31, 2021 at 8:25 AM Kumar Kartikeya Dwivedi > wrote: >> >> On Sat, Jul 31, 2021 at 06:26:32AM IST, Matthew Cover wrote: >>> Commit ce4dade7f12a ("samples/bpf: xdp_redirect_cpu: Load a eBPF program >>> on cpumap") added the following option, but missed adding it to optstring: >>> - mprog-disable: disable loading XDP program on cpumap entries >>> >>> Add the missing option character. >> >> I made some changes in this area in [0], since the support was primarily to do >> redirection from the cpumap prog, so by default we don't install anything now >> and only do so if a redirection interface is specified (and use devmap instead). >> So this option won't be used anyway going forward (since we don't install a >> dummy XDP_PASS program anymore) if it gets accepted. >> >> [0]: https://lore.kernel.org/bpf/20210728165552.435050-1-memxor@gmail.com >> >> PS: I can restore it again if this is something really used beyond redirecting >> to another device (i.e. with custom BPF programs). Any feedback would be helpful. > > Hey Kartikeya. I happened to be looking through this code to get a > feel for using CPUMAP for custom steering (e.g. RSS on encapsulated > packets) in XDP and noticed the missing option character. Figured it > was worth doing a quick patch and test. > > Unfortunately, I'm not able to say much on your changes as I'm still > getting familiarized with this code. It looks like your submission is > in need of a rebase; v3 has been marked "Changes Requested" in > patchwork [0]. As I see things, It'd be good to get this fix in there > for now, whether or not the code is removed later. Yeap, given this fix in here is tiny & valid either way, I took it in for now, and when Kartikeya's rework eventually drops the whole option, so be it. ;) Applied, thanks!