Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757945AbWK1Xai (ORCPT ); Tue, 28 Nov 2006 18:30:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757955AbWK1Xah (ORCPT ); Tue, 28 Nov 2006 18:30:37 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:40661 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S1757945AbWK1Xag (ORCPT ); Tue, 28 Nov 2006 18:30:36 -0500 Subject: Re: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal From: Mingming Cao Reply-To: cmm@us.ibm.com To: Hugh Dickins Cc: Andrew Morton , Mel Gorman , "Martin J. Bligh" , linux-kernel@vger.kernel.org, "linux-ext4@vger.kernel.org" In-Reply-To: References: <20061114014125.dd315fff.akpm@osdl.org> <20061114184919.GA16020@skynet.ie> <20061114113120.d4c22b02.akpm@osdl.org> <20061115214534.72e6f2e8.akpm@osdl.org> <455C0B6F.7000201@us.ibm.com> <20061115232228.afaf42f2.akpm@osdl.org> <1163666960.4310.40.camel@localhost.localdomain> <20061116011351.1401a00f.akpm@osdl.org> <1163708116.3737.12.camel@dyn9047017103.beaverton.ibm.com> <20061116132724.1882b122.akpm@osdl.org> <1164073652.20900.34.camel@dyn9047017103.beaverton.ibm.com> <1164156193.3804.48.camel@dyn9047017103.beaverton.ibm.com> Content-Type: text/plain Organization: IBM LTC Date: Tue, 28 Nov 2006 15:30:32 -0800 Message-Id: <1164756632.6538.4.camel@dyn9047017103.beaverton.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 42 On Tue, 2006-11-28 at 17:42 +0000, Hugh Dickins wrote: > grp_goal 0 is a genuine goal (unlike -1), > so ext2_try_to_allocate_with_rsv should treat it as such. > > Signed-off-by: Hugh Dickins Acked. Thanks, Mingming > --- > > fs/ext2/balloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-11-24 08:18:02.000000000 +0000 > +++ linux/fs/ext2/balloc.c 2006-11-27 19:28:41.000000000 +0000 > @@ -1053,7 +1053,7 @@ ext2_try_to_allocate_with_rsv(struct sup > } > /* > * grp_goal is a group relative block number (if there is a goal) > - * 0 < grp_goal < EXT2_BLOCKS_PER_GROUP(sb) > + * 0 <= grp_goal < EXT2_BLOCKS_PER_GROUP(sb) > * first block is a filesystem wide block number > * first block is the block number of the first block in this group > */ > @@ -1089,7 +1089,7 @@ ext2_try_to_allocate_with_rsv(struct sup > if (!goal_in_my_reservation(&my_rsv->rsv_window, > grp_goal, group, sb)) > grp_goal = -1; > - } else if (grp_goal > 0) { > + } else if (grp_goal >= 0) { > int curr = my_rsv->rsv_end - > (grp_goal + group_first_block) + 1; > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/