Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/2] scsi: ufs: Add L2P entry swap quirk for Micron UFS
 in HPB READ command
Thread-Topic: [PATCH v1 1/2] scsi: ufs: Add L2P entry swap quirk for Micron
 UFS in HPB READ command
Thread-Index: AQHXiV2V2+N3YA8RXkihQlAMhvC5z6tkdIGQ
Date:   Thu, 5 Aug 2021 06:34:22 +0000
Message-ID: <DM6PR04MB6575F7580C428373EAAA33B4FCF29@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210804182128.458356-1-huobean@gmail.com>
 <20210804182128.458356-2-huobean@gmail.com>
In-Reply-To: <20210804182128.458356-2-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zk5Qz1DEWoOhbOdDLKWym1EgiQ003HotQJg99zY7HWFbvKGSSx9soH6TTUEz?=
 =?us-ascii?Q?jPogp020pSriKmMY6w1lf0L+WCU1SqNHXWSJbklufgwD5d1WyOi2D1umDk8v?=
 =?us-ascii?Q?L2aWlGdI2GdSemnQ8R/5Nfm0wdK+aU3cz1v7qdrGuyTBzmpOJBuwSBclsFEy?=
 =?us-ascii?Q?ThpWC79P5Wvg7mRm8I6/1Op5HnqOxCCQkzAW7HRolq49XsSIGwCEZm+8/sSy?=
 =?us-ascii?Q?EitL4vnJtRA7WSOou4QpP2KAPXPIQTXIvEKCI7ij4EaodAwBO1U1LuEfJCLa?=
 =?us-ascii?Q?b2IohQuS8GIxla6DVJdzV8HiaGjPfgkyraN/cJHnKHQ2SU+TI5fwg9a13Ytd?=
 =?us-ascii?Q?3nNqWL7dGYMANFMGeqEjQgoOLqj31iGHJYw7/xveGHMWaVPSpv3D2vKB2K7N?=
 =?us-ascii?Q?s04Jl6kRnVXSEGwnPb+GrSHjpMRTD3iQYYxA8SO0zjHZCVg5ri9aT1UlLXpt?=
 =?us-ascii?Q?2Gg5bPghV6q/zeWlHXrZbApUZoUYQd7xb53XhzkbeCpLEBKfCsNSAlWmvXa4?=
 =?us-ascii?Q?7Kok6vKs/IDXcb8s0DSNoOhYpwXO0u4NDIki0J7NTADb0+pyFFfhtF/kJjge?=
 =?us-ascii?Q?NLZSF4rrp3mPYsn6M/jUc1OdHwjgyP44IPanWhNclVUgFb6Cs4eh3Ky+K/7N?=
 =?us-ascii?Q?hJwON/ucE4ZEKNcIZ2UkJF/nvVqSUM3NjJ6CxcPjSpTmf7mhCJ5OGsMLhfFI?=
 =?us-ascii?Q?viyFHDuQsz7i2VnJYBZ9vjO8L290CkM1RvITQ3nzo3duOql+jwu2ZjgrN8ip?=
 =?us-ascii?Q?jFZoM/ujhe0sbeIgs0iDbwjwZP5Klj8Gmy1l8XgnINsYLUyvKPl0rpKUQ8Iu?=
 =?us-ascii?Q?IFS1VKwvGfGFaJLCmIQs4qUazhDaxZksujZcXg53wdQkM3r7Tx1XwgFqthIt?=
 =?us-ascii?Q?4OoMTBme71URNXloBC2ZkvlWekLQ20BuWxLWNDhbiFkYQt1uf+VmIgKuJAsG?=
 =?us-ascii?Q?Kw6FO/GRl2XUlDcJh+AiMVh5mMFQSSYlvMP8MENHJK/CjxskN6d4oq4wB6z0?=
 =?us-ascii?Q?gf124df4KkWTBl+lHRSk/uGv7WVvqhs2RRCcaetwaeiT3ULEZ0zv5pmFW2LR?=
 =?us-ascii?Q?La1IzyxkIOX9hwjX84azsCCr7mAoGYIKWrbi4mPdg9EyLM7ir4bu7CGkP++3?=
 =?us-ascii?Q?Z0L5O1CJ/6V3+H+9CedAG0ey9zbgNgiD91h27FgQAoZ/ceVOnEglxxrUwKnU?=
 =?us-ascii?Q?jcGa0gGjJL2UERAs+yN4VB+hXivHMAnw0SIRaLuL4IwqP5KtmJHtd864Sbr3?=
 =?us-ascii?Q?tdgCuJvJv+pcLC5c9CIzDTs4G6B2QZ8TbLvJx7NIZxBSL7/96PrI53InBBBl?=
 =?us-ascii?Q?rCnf6jd5IoVyVwRh6j1GksRR?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d07693a-e302-4c81-3fc3-08d957db0fd3
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 06:34:22.3995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: InZr69G+l2V7GBrib6B49XsKSK8BMKNNFi2xofNjw0MTIPAUU33tq3UvLAf+vm33uMMXChCXzRUZwwEi0HdOkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1132
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Bean Huo <beanhuo@micron.com>
>=20
> For the Micron UFS, L2P entry need to be swapped in HPB READ command
> before sending HPB READ command to the UFS device. Add this quirk
> UFS_DEVICE_QUIRK_SWAP_L2P_ENTRY_FOR_HPB_READ to fix this
> inconsistency.
>=20
> Fixes: 2fff76f87542 ("scsi: ufs: ufshpb: Prepare HPB read for cached sub-
> region")
Not really needed - the patch is fine.

> Signed-off-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/scsi/ufs/ufs_quirks.h |  6 ++++++
>  drivers/scsi/ufs/ufshcd.c     |  3 ++-
>  drivers/scsi/ufs/ufshpb.c     | 15 ++++++++++-----
>  3 files changed, 18 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufs_quirks.h b/drivers/scsi/ufs/ufs_quirks.=
h
> index 07f559ac5883..35ec9ea79869 100644
> --- a/drivers/scsi/ufs/ufs_quirks.h
> +++ b/drivers/scsi/ufs/ufs_quirks.h
> @@ -116,4 +116,10 @@ struct ufs_dev_fix {
>   */
>  #define UFS_DEVICE_QUIRK_DELAY_AFTER_LPM        (1 << 11)
>=20
> +/*
> + * Some UFS devices require L2P entry should be swapped before being sen=
t to
> the
> + * UFS device for HPB READ command.
> + */
> +#define UFS_DEVICE_QUIRK_SWAP_L2P_ENTRY_FOR_HPB_READ (1 << 12)
> +
>  #endif /* UFS_QUIRKS_H_ */
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 47a5085f16a9..c3a14d3b0030 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -199,7 +199,8 @@ ufs_get_desired_pm_lvl_for_dev_link_state(enum
> ufs_dev_pwr_mode dev_state,
>  static struct ufs_dev_fix ufs_fixups[] =3D {
>         /* UFS cards deviations table */
>         UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
> -               UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> +               UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
> +               UFS_DEVICE_QUIRK_SWAP_L2P_ENTRY_FOR_HPB_READ),
>         UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
>                 UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
>                 UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE |
> diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> index 54e8e019bdbe..d0eb14be47a3 100644
> --- a/drivers/scsi/ufs/ufshpb.c
> +++ b/drivers/scsi/ufs/ufshpb.c
> @@ -323,15 +323,19 @@ ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb,
> unsigned long lpn, int *rgn_idx,
>  }
>=20
>  static void
> -ufshpb_set_hpb_read_to_upiu(struct ufshpb_lu *hpb, struct ufshcd_lrb *lr=
bp,
> -                           u32 lpn, __be64 ppn, u8 transfer_len, int rea=
d_id)
> +ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
> +                           struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
> +                           u8 transfer_len, int read_id)
>  {
>         unsigned char *cdb =3D lrbp->cmd->cmnd;
> -
> +       __be64 ppn_tmp =3D ppn;
>         cdb[0] =3D UFSHPB_READ;
>=20
> +       if (hba->dev_quirks &
> UFS_DEVICE_QUIRK_SWAP_L2P_ENTRY_FOR_HPB_READ)
> +               ppn_tmp =3D swab64(ppn);
> +
>         /* ppn value is stored as big-endian in the host memory */
> -       memcpy(&cdb[6], &ppn, sizeof(__be64));
> +       memcpy(&cdb[6], &ppn_tmp, sizeof(__be64));
>         cdb[14] =3D transfer_len;
>         cdb[15] =3D read_id;
>=20
> @@ -689,7 +693,8 @@ int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lr=
b
> *lrbp)
>                 }
>         }
>=20
> -       ufshpb_set_hpb_read_to_upiu(hpb, lrbp, lpn, ppn, transfer_len, re=
ad_id);
> +       ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_le=
n,
> +                                   read_id);
>=20
>         hpb->stats.hit_cnt++;
>         return 0;
> --
> 2.25.1