Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 5 Aug 2021 09:26:20 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Alistair Francis <alistair23@gmail.com>
Cc:     Alistair Francis <alistair@alistair23.me>,
        Rob Herring <robh+dt@kernel.org>, lgirdwood@gmail.com,
        Mark Brown <broonie@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Sascha Hauer <kernel@pengutronix.de>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 09/11] ARM: dts: imx7d: remarkable2: Enable
 silergy,sy7636a
Message-ID: <YQugrBPkiSTfh8qB@google.com>
References: <20210803084456.198-1-alistair@alistair23.me>
 <20210803084456.198-9-alistair@alistair23.me>
 <YQqLiAtAtREWTvD7@google.com>
 <CAKmqyKO_QeNTRZx9P9vhX7DQoBfE6igOtJroTEer-OKoVO-RGQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKmqyKO_QeNTRZx9P9vhX7DQoBfE6igOtJroTEer-OKoVO-RGQ@mail.gmail.com>
Precedence: bulk

On Thu, 05 Aug 2021, Alistair Francis wrote:

> On Wed, Aug 4, 2021 at 10:43 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Tue, 03 Aug 2021, Alistair Francis wrote:
> >
> > > Enable the silergy,sy7636a and silergy,sy7636a-regulator on the
> > > reMarkable2.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > ---
> > >  arch/arm/boot/dts/imx7d-remarkable2.dts | 42 +++++++++++++++++++++++++
> > >  1 file changed, 42 insertions(+)
> >
> > I don't see the DT documentation for this device.
> 
> Which device?
> 
> The imx7d-remarkable2 is in current master and there is a single line
> at `Documentation/devicetree/bindings/arm/fsl.yaml`
> 
> The silergy,sy7636a-regulator is also already in master, but it isn't

I think this is currently in -next.

It won't land in Mainline (what I believe you're calling "master")
until the next merge window, which is about a month.

> exposed to device tree and the compatible string shouldn't be included
> in this patch. I'll fix that.

Okay, this is essentially what I was getting at.

The node should really be documented and Acked by the DT guys.

..

Anyway, I have a new toy for you to play with.

I'll Cc you on the patch.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog