Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210803084456.198-1-alistair@alistair23.me> <20210803084456.198-9-alistair@alistair23.me>
 <YQqLiAtAtREWTvD7@google.com> <CAKmqyKO_QeNTRZx9P9vhX7DQoBfE6igOtJroTEer-OKoVO-RGQ@mail.gmail.com>
 <YQugrBPkiSTfh8qB@google.com>
In-Reply-To: <YQugrBPkiSTfh8qB@google.com>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Thu, 5 Aug 2021 18:37:09 +1000
Message-ID: <CAKmqyKMT6mDZuczsSbztiSVQsfYX1MNr6VsO_Y_3LEZ+w+YzcA@mail.gmail.com>
Subject: Re: [PATCH v8 09/11] ARM: dts: imx7d: remarkable2: Enable silergy,sy7636a
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Alistair Francis <alistair@alistair23.me>,
        Rob Herring <robh+dt@kernel.org>, lgirdwood@gmail.com,
        Mark Brown <broonie@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Sascha Hauer <kernel@pengutronix.de>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 5, 2021 at 6:26 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Thu, 05 Aug 2021, Alistair Francis wrote:
>
> > On Wed, Aug 4, 2021 at 10:43 PM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Tue, 03 Aug 2021, Alistair Francis wrote:
> > >
> > > > Enable the silergy,sy7636a and silergy,sy7636a-regulator on the
> > > > reMarkable2.
> > > >
> > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > > ---
> > > >  arch/arm/boot/dts/imx7d-remarkable2.dts | 42 +++++++++++++++++++++=
++++
> > > >  1 file changed, 42 insertions(+)
> > >
> > > I don't see the DT documentation for this device.
> >
> > Which device?
> >
> > The imx7d-remarkable2 is in current master and there is a single line
> > at `Documentation/devicetree/bindings/arm/fsl.yaml`
> >
> > The silergy,sy7636a-regulator is also already in master, but it isn't
>
> I think this is currently in -next.

Sorry, I thought it was in mainline at this point.

>
> It won't land in Mainline (what I believe you're calling "master")
> until the next merge window, which is about a month.

Ah, yep. I meant to say mainline. Every project has different terminology.

>
> > exposed to device tree and the compatible string shouldn't be included
> > in this patch. I'll fix that.
>
> Okay, this is essentially what I was getting at.
>
> The node should really be documented and Acked by the DT guys.

Should the regulator have it's own DT binding documentation? From what
I could tell just including it in mfd bindings was enough.

>
> ..
>
> Anyway, I have a new toy for you to play with.
>
> I'll Cc you on the patch.

I'll keep a look out!

Alistair

>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Senior Technical Lead - Developer Services
> Linaro.org =E2=94=82 Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog