Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/2] Revert "media: device property: Call
 fwnode_graph_get_endpoint_by_id() for fwnode->secondary"
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, rafael@kernel.org,
        andriy.shevchenko@linux.intel.com,
        laurent.pinchart@ideasonboard.com
References: <20210804230313.78238-1-djrscally@gmail.com>
 <20210804230313.78238-3-djrscally@gmail.com> <YQujbIj0ynE43vw9@kroah.com>
From:   Daniel Scally <djrscally@gmail.com>
Message-ID: <384a39d3-6817-7e42-60cc-43615a4e4ae8@gmail.com>
Date:   Thu, 5 Aug 2021 09:59:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YQujbIj0ynE43vw9@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 05/08/2021 09:38, Greg KH wrote:
> On Thu, Aug 05, 2021 at 12:03:13AM +0100, Daniel Scally wrote:
>> This reverts commit acd418bfcfc415cf5e6414b6d1c6acfec850f290. Checking for
>> endpoints against fwnode->secondary in fwnode_graph_get_next_endpoint() is
>> a better way to do this since that function is also used in a bunch of
>> other places, for instance sensor drivers checking that they do have an
>> endpoint connected during probe.
>>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Signed-off-by: Daniel Scally <djrscally@gmail.com>
>> ---
>>  drivers/base/property.c | 9 +--------
>>  1 file changed, 1 insertion(+), 8 deletions(-)
> This can only be reverted due to your 1/2 change, right?


Yes, that's correct.

> If so, you
> might want to make that explicit here...


Fair point - thanks, I'll do that.

>
> thanks,
>
> greg k-h