Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Waiman Long <llong@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Will Deacon <will@kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: [patch 15/63] locking: Add base code for RT rw_semaphore and
 rwlock
In-Reply-To: <710fff58-1db3-d0c2-21db-b1837d37bfee@redhat.com>
References: <20210730135007.155909613@linutronix.de>
 <20210730135206.018846923@linutronix.de>
 <710fff58-1db3-d0c2-21db-b1837d37bfee@redhat.com>
Date:   Thu, 05 Aug 2021 11:04:27 +0200
Message-ID: <87o8ac1cv8.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Aug 04 2021 at 15:37, Waiman Long wrote:
> On 7/30/21 9:50 AM, Thomas Gleixner wrote:
>> +static int __sched rwbase_write_lock(struct rwbase_rt *rwb,
>> +				     unsigned int state)
>> +{
>> +	struct rt_mutex_base *rtm = &rwb->rtmutex;
>> +	unsigned long flags;
>> +
>> +	/* Take the rtmutex as a first step */
>> +	if (rwbase_rtmutex_lock_state(rtm, state))
>
> This function is used here before it was defined in next patch (patch 16).

Correct and there are more I think. But that's a hen and egg
problem:

The base code cannot be compiled without the actual implementation for
either rw_semaphore or rw_lock substitutions. The implementations cannot
be compiled without the base code.

So I chose to split it up so the base logic is separate.

Thanks,

        tglx