Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
        "'Rob Herring'" <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc:     "'Chanwoo Choi'" <cw00.choi@samsung.com>,
        "'Pankaj Dubey'" <pankaj.dubey@samsung.com>,
        "'Sam Protsenko'" <semen.protsenko@linaro.org>,
        "'Marc Zyngier'" <maz@kernel.org>
In-Reply-To: <b0d6ff2a-24af-96c1-62a1-8b920c63e05a@canonical.com>
Subject: RE: [PATCH] arm64: dts: exynos: correct GIC CPU interfaces address
 range on Exynos7
Date:   Thu, 5 Aug 2021 14:56:14 +0530
Message-ID: <03d701d789db$f275d290$d76177b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGqCsm6I7l6cIRsiJEa3ZtJxO0jtAJYiPTmAtVSVZirljKmUA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20210805072110.4730-1-krzysztof.kozlowski@canonical.com>
        <CGME20210805073653epcas5p21b4c2358b7de2b3c21dbc357af957137@epcas5p2.samsung.com>
        <b0d6ff2a-24af-96c1-62a1-8b920c63e05a@canonical.com>
Precedence: bulk

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40canonical.com>
> Sent: 05 August 2021 13:07
> To: Rob Herring <robh+dt=40kernel.org>; devicetree=40vger.kernel.org; lin=
ux-
> arm-kernel=40lists.infradead.org; linux-samsung-soc=40vger.kernel.org; li=
nux-
> kernel=40vger.kernel.org
> Cc: Alim Akhtar <alim.akhtar=40samsung.com>; Chanwoo Choi
> <cw00.choi=40samsung.com>; Pankaj Dubey <pankaj.dubey=40samsung.com>;
> Sam Protsenko <semen.protsenko=40linaro.org>; Marc Zyngier
> <maz=40kernel.org>
> Subject: Re: =5BPATCH=5D arm64: dts: exynos: correct GIC CPU interfaces a=
ddress
> range on Exynos7
>=20
> On 05/08/2021 09:21, Krzysztof Kozlowski wrote:
> > The GIC-400 CPU interfaces address range is defined as 0x2000-0x3FFF
> > (by ARM).
> >
>=20
Looking at DDI0471B_gic400_r0p1_trm.pdf, CPU interface range is 0x0000 =7E =
0x10000

> I underestimated the issue - this is actually bug as there is a GICC_DIR
> register at offset 0x1000. Therefore:
>=20
Looking at the exynos7 and exynos5433 UMs looks like GICC_DIR is at offset =
0x2100 (from 0x1100_0000 GIC base)
It is possible for you to cross check once?

> Fixes: b9024cbc937d (=22arm64: dts: Add initial device tree support for
> exynos7=22)
>=20
> > Reported-by: Sam Protsenko <semen.protsenko=40linaro.org>
> > Reported-by: Marc Zyngier <maz=40kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski=40canonical.com=
>
> > ---
> >  arch/arm64/boot/dts/exynos/exynos7.dtsi =7C 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > index 8b06397ba6e7..c73a597ca66e 100644
> > --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> > =40=40 -137,7 +137,7 =40=40 gic: interrupt-controller=4011001000 =7B
> >  			=23address-cells =3D <0>;
> >  			interrupt-controller;
> >  			reg =3D	<0x11001000 0x1000>,
> > -				<0x11002000 0x1000>,
> > +				<0x11002000 0x2000>,
> >  				<0x11004000 0x2000>,
> >  				<0x11006000 0x2000>;
> >  		=7D;
> >
>=20
>=20
> Best regards,
> Krzysztof