Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 5 Aug 2021 13:43:53 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Andy Whitcroft <apw@canonical.com>
Cc:     Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] checkpatch: prefer = {} initializations to = {0}
Message-ID: <20210805104353.GD26417@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kili (102.222.70.252) by FR3P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.5 via Frontend Transport; Thu, 5 Aug 2021 10:44:01 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5cd918f0-6a61-4cc2-c61e-08d957fdf1e8
X-MS-TrafficTypeDiagnostic: CO1PR10MB4484:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB44844FB971B036718509BAE58EF29@CO1PR10MB4484.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: qlM17hpCx0X13xSCzVs1wk8VfKp8t4pFbxXQLfS1wmMB4aHkW2wqYdjC66v6eW4WO5gSMpeLc5uFPrdBbThU6NqSdD5Kfd7mKc5hh9EEHXlRmxmhEvR4skuAhaRi/Sq+O7XnbKW/8Bx65i4nW2y62/RcUYcwpIEU94flDDxeob1dUHIHcjlvoMu1XCx40Lu9uJy9plsG0mLjlxXLHDWIvtmPmAGMf+vQDsKy8+d13hdfZEfeOhv7Zl44HAb5bTnUeBL9pxtlHCnRmlljsTsUVVLBkiUwI7Vx5qLu7jMjkCDv4ZYcdLvrcXtOIvRxe1a69SXiqddvMvbaRo3xAeD52GlGsNyI60IdyFTfmQnDiedIa4yF3rILTyFnNEtBu7/QAxaGIO417dG0pzYS8OD3m8OMjrPV5fTWDRzB6Q1kNd/fSO4Kg5IsTnfXKY6cc4ueaIJ0utlIKN0/SGFaHW1WDmV+O+NqsF9Cz+lLAXWATR4xXG74epj4VodaGL3ZccfeBc6lqV5WP5ZsK2/bKGLRZw57XFlfOFVqN81qDyt+fRaDzuobQ8y0Mrg2k3/LOUB9T99tmPOmHFAxno1vQMukCJyk3TaGmhPBiP50zbMn96zxKIcOGt8n3oIMncmYQtaEvRytZ9+EZFy+IOrCXLkWuPf2/2ejUF6Cfy1zvyjVsbeYPmFx/ajsJ1LuMW8kvlYr/1gF0ESG5yMeZKWPx09jdiS/MudxpmKirAeVOdPc/9c=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(346002)(136003)(376002)(366004)(9576002)(8936002)(33716001)(86362001)(66946007)(66476007)(9686003)(6496006)(83380400001)(316002)(8676002)(66556008)(33656002)(55016002)(54906003)(6666004)(26005)(186003)(478600001)(956004)(44832011)(2906002)(1076003)(38350700002)(52116002)(5660300002)(38100700002)(6916009)(4326008)(125773002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y20rNEb5jmtkMk7RyxXOw9zQd4g5+13VqQGozPDcQzGhGbTN6+CTP6o/XqwK?=
 =?us-ascii?Q?MST6zzN1hMIC7/OZLeaaIuAPiD8LpPSVnqd+IkFreCrbTBchTH1UKWDsrHe+?=
 =?us-ascii?Q?fsan2tVXkkIC0TN0QT1AtqmoVn/ihOLW7QM7PJeUwBkif1PovMYgXWNH/1P3?=
 =?us-ascii?Q?DTfy9HlVHipIgXh5r6eGZOCv4++4npa+W0WgthJg6xSM5UR8X1Qnn0tI+3z8?=
 =?us-ascii?Q?WkE0f2tB0bT4FMd2ULWZb5nLAwgSmg/AGOQFoGVUj05b2oWMmYpLqov3O1F4?=
 =?us-ascii?Q?vHrRjId2BtJYC6TpCiKttyPYTuagnbBXPEOWem9pwSlP5ayBwBx+l7g/8hBM?=
 =?us-ascii?Q?3cu5lsrHoRWN4uXyQkSSn10/JyZIx7b6QHQ4eI84m7ZqUfRyBxUSHf1+D/9x?=
 =?us-ascii?Q?EVs2XISqhLCFEKO/Vm2+bNpsBH6WTKLvQi7mJ7Dhqug9Tz1ZsSioL7KdYN+Y?=
 =?us-ascii?Q?IZprdO+upUYz+CXYDIDgpNq9K3KzZIVl1FokJWdDtGoEJYJv+OcavxVKIPBl?=
 =?us-ascii?Q?PVO8o/z7OAWPm4JT7+Iy6vos8DoTDFT0WiIVbZOIEto3DiyqPYw3EukTj4Hp?=
 =?us-ascii?Q?FSw7KhnYGtwkm2pZsn3jmR4ee1COf3JAyCMzbIHmeWQMWY09Q2ICQCrfJ4ZQ?=
 =?us-ascii?Q?o7pkB+wFK3oO6MdVZfdDla83WVV8H9NwuJy+xRw5qNZrD+MPQwDgD9PJrBGY?=
 =?us-ascii?Q?YJMtyG1WdCeqrx1VfVv0gykxh42Ny0pe0ES7/W8twDvfT0KItNzXGTo2F9Rk?=
 =?us-ascii?Q?jk2+vfWd+ATmCvH39xG9ptjPgtNFU4Oj8VjFPQ72zhOT+jEbSmUgEEunwlVo?=
 =?us-ascii?Q?y3OvwP1sJaKsQht9He64c4WUjxObQqg3qikAq16FhWjoyWaynBpx9cXjerdd?=
 =?us-ascii?Q?NQZsK+MOp07nVyANvok+9amJ4oFQUDDmALaBQ8hnu6JcvzAvSnLxALOT7jKl?=
 =?us-ascii?Q?QE1Rj1HESWFe51aGVbhX57H4nZHu13iZlDXTlCxoTQhaAngcFE9rYoYQaTLO?=
 =?us-ascii?Q?IMfMK2NnyKcSW18er2XrDLeexyLcXdfKu7FQ3s2OBa/GHErGfNbVEHfrkH1l?=
 =?us-ascii?Q?Y7j/DIQ/syJr4Anoy6itsX6QY+DTNYYcxh2oc3l9Jq6SancTYxXOUIwJqzxC?=
 =?us-ascii?Q?hBDYgbtQsb7XlgO6XBfHOrlx3juEg5yr0HKRedhZ0a5GORf3ggbWp3wJNlIA?=
 =?us-ascii?Q?yIiyqyyvd50947rBVj9AID/tTlKduRprU7nixDHlfsDZ3EmeWYcgJNP80pIJ?=
 =?us-ascii?Q?289n6Hurt3GiG2leJ2s1+uJ3K2AMggrK0AqSnWOSzuCHsV2C5Qk90jOx6Sxf?=
 =?us-ascii?Q?2UqwTdOoDypWG48qECQmPGYl?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cd918f0-6a61-4cc2-c61e-08d957fdf1e8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 10:44:04.7891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TY/lRmrewA/VNqHX8JAbZ7oW4cYwuqaR0OtrVXlU30cSyKgp+q2e7XjkV6PROB6sWMfPy7jJMnwNMqMxuKkyBPAyJQ5k+zb6MkxRIH7n23s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4484
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10066 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108050063
X-Proofpoint-GUID: XXqL1JBlzRnxN0iZoeQ8w1mxQwwtJQYa
X-Proofpoint-ORIG-GUID: XXqL1JBlzRnxN0iZoeQ8w1mxQwwtJQYa
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The "= {};" style empty struct initializer is preferred over = {0}.
It avoids the situation where the first struct member is a pointer and
that generates a Sparse warning about assigning using zero instead of
NULL.  Also it's just nicer to look at.

Some people complain that {} is less portable but the kernel has
different portability requirements from userspace so this is not a
issue that we care about.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 461d4221e4a4..32c8a0ca6fd0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4029,6 +4029,12 @@ sub process {
 			     "Using $1 is unnecessary\n" . $herecurr);
 		}
 
+# prefer = {}; to = {0};
+		if ($line =~ /= \{ *0 *\}/) {
+			WARN("ZERO_INITIALIZER",
+			     "= {} is preferred over = {0}\n" . $herecurr);
+		}
+
 # Check for potential 'bare' types
 		my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
 		    $realline_next);
-- 
2.30.2