Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp467506pxt; Thu, 5 Aug 2021 04:18:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOvjjbSndae+bltAd9gLKm4GNy4X+MyyyDdhiapsHV3oY+IpLzcpJNnWrmQ5getfrpkuJ/ X-Received: by 2002:a02:7f12:: with SMTP id r18mr4103998jac.50.1628162328660; Thu, 05 Aug 2021 04:18:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628162328; cv=none; d=google.com; s=arc-20160816; b=RcVwBHsgu0ZOtp/9s3LvkyPBmw8UlREq9i/9fMlrzBXkASRgavICQjGz7mGzHw+OR3 2IrMe3bH2bm4kf6vMnByGbBhShVbGm1txG2uv9Bv2WOrjPyAtQQaoiVsc+6tSdW2zm6t UolNdpy6XLf3lnVy2QURAd86924n1XCAIvGP81avyrMCWl+QS0vsFF3y6lYf3BxUdns5 DU87nmfChbmypjYGRfkD9VHyW5zaNtFG8DUDw0gAN6YOzXkb8HgH7I+lgW+uKgis0u3/ uJKBzgGE3UOmVMJJRns8p88tKUACyFiR2D11Q6t+hHDhzNofllPoxqpGwROSV/8qER7y i+aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tzUPU1lrZD95ilD0B5HXPFFCkMB+scFsgh2oNvsji5w=; b=jGe3rCcdIaabEvYJXVCjh+S7fJ1HNhWuI/qNLdlBLfdCZXadE4OAM2ei58CAWYuYvN TdLDiPLiZ1g1ttcqUDpubJZN/EEgIeDfyIP2iHEOLQgSLByCDKzXpU5sR6kw80oMvfH5 dak3zzQmDI9pE8jcnSehxlVfPkaZBJBIg2pU2PEkznTmoies9efj+KKRiipqKUPMxVU5 ZJwW5EnsuNymHA4F1Ug6Xsm+v/PwPfuQjJwLnzGissHURW5cR1jyBVlkIY1KRRQFlnO1 VVKU4qVPtwyeBQIOlqDwIhPMfJKRUswh4yvJ+WyGQkzPm0vmXcTWbPmNLzuDOl6ZeTDK yU4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jcAzjAPr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v20si2192501jas.98.2021.08.05.04.18.36; Thu, 05 Aug 2021 04:18:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jcAzjAPr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240920AbhHELSE (ORCPT + 99 others); Thu, 5 Aug 2021 07:18:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:39320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232896AbhHELSD (ORCPT ); Thu, 5 Aug 2021 07:18:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 01ED2600EF; Thu, 5 Aug 2021 11:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628162269; bh=AsV/wDbpXC+UOCKSfs8l5fzQWjjqdm3HA4mMajue9/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jcAzjAPrg3YBlPkj1H7r6YAfJXoCH1Ndh5cB22qa4K4rV3uuq5NbbafmcItCgLpO7 YgEAAt/Yk2A07O9Y3RqHm8KPmqL0S+EgcwGr27LI9ajPA3QbCaFdcOypiy7fu7vMTw TwHj1njGqqru3KEW8Iqwc/5ks7zg9IP2YPOuYd8E= Date: Thu, 5 Aug 2021 13:17:47 +0200 From: Greg KH To: Jhih-Ming Huang Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, maqianga@uniontech.com, marcocesati@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v7] rtw_security: fix cast to restricted __le32 Message-ID: References: <20210801155152.242089-1-fbihjmeric@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210801155152.242089-1-fbihjmeric@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 01, 2021 at 11:51:52PM +0800, Jhih-Ming Huang wrote: > This patch fixes the sparse warning of fix cast to restricted __le32. > > There was a change for replacing private CRC-32 routines with in kernel > ones. > However, the author used le32_to_cpu to convert crc32_le(), and we > should use cpu_to_le32. > > Reported-by: kernel test robot > Signed-off-by: Jhih-Ming Huang > --- > changes from v6: > using get_unaligned_le32 to get the value and comparing it with crc, > instead of using memcmp with raw pointers. > > drivers/staging/rtl8723bs/core/rtw_security.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) Does not apply to the tree :(