Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp511493pxt; Thu, 5 Aug 2021 05:19:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRCezE2E8ehb1HOqCkglcqq9wI0jHhwh2Qipuc+yBQ90pzHXGBPmiL4DE7xfqV+x4Ekm4v X-Received: by 2002:a50:f1d8:: with SMTP id y24mr6139440edl.275.1628165952373; Thu, 05 Aug 2021 05:19:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628165952; cv=none; d=google.com; s=arc-20160816; b=nWdjRipQHtmtX9xIMUoSXoG4RHKNaI180VlxeSXTY66ItRGDJgfdcxBW02Ktocj+e3 Jig6GsXykyrHgbBqYWeTNPfu21nsTSBT6VbkIaJA0ga7Q/tXJHsXvq0QUgXxA3KxL21q NbTJwkWtmesa3SpF7fwPZt4/aeOeYXDFtEBLcVkWqJtLj4gje9/PpOoCBNeMOZoAIZIv KNLjwXHUdWXNdYEut6Jj4gN0nZjkBIZ2vmvOSbxkQCVOhDvbE+FOnQIdPbJpILxBB2zH 67gGfGvPImWH8PQkCSEXlJPYUyD1HLYGkZ5Jgr2Ub65mms3IckbAIfNaJeREx4rykB6i pLjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rA3HzN9LGTjGmyUMEN/X5JZ38mbKsExANiZxFjFWlGw=; b=GjvXD/QHqJaeMMewCwAeR+Bw2bNBgPnSK7q7M+73GBDwLkp29j8Tl/8whgkCyHp6ly KRFw06yCZ+X2AiAWqagFwKj5BZ/detjMOXg+DwA7BVFBlTW9YGkIhng+bC/UYTafJFsi EgppblOxV8ds2+4WNZKyoXzSA3QqI6nP8FlbCInOExfoAU/tGXAtrsoogxfsj4q4yphq FGo2GK+5lMlYUbFAC3t7w8gpSNvHaYICetNfmBlVWahASBYDl0PcTVkT/2q0vYHZks4I ayvIesKNbGBhwOVUufKXXQj3MSUmSshzv71WduLBF2EL6DTKDcpYjoCMwA42UV1rDJwl P0JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BqDsRlAD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s4si5611567ejv.565.2021.08.05.05.18.48; Thu, 05 Aug 2021 05:19:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BqDsRlAD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239486AbhHEIie (ORCPT + 99 others); Thu, 5 Aug 2021 04:38:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:57670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237891AbhHEIid (ORCPT ); Thu, 5 Aug 2021 04:38:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C301610A8; Thu, 5 Aug 2021 08:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628152699; bh=LuDDhiurEknBQTcWpVTvvZaAFwzvJtxw/M1UF5YJNbc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BqDsRlADw62BzjyGcsDDjoaZ2UKjsTdZRoYZssSMjKM9oyMMMEuGwiR3Ej9sl/vLK 8Ph+YsozxHS0eHzou8FC0iW8y1YhKyWaqEn6VjRkDXCSuB2P3R2nVfnOflEZKJfB3Z KEP2zE4UFfjr8M4AK9l9vVwnWg+/MePT8sddzOhc= Date: Thu, 5 Aug 2021 10:38:04 +0200 From: Greg KH To: Daniel Scally Cc: linux-kernel@vger.kernel.org, rafael@kernel.org, andriy.shevchenko@linux.intel.com, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH v2 2/2] Revert "media: device property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary" Message-ID: References: <20210804230313.78238-1-djrscally@gmail.com> <20210804230313.78238-3-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804230313.78238-3-djrscally@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 05, 2021 at 12:03:13AM +0100, Daniel Scally wrote: > This reverts commit acd418bfcfc415cf5e6414b6d1c6acfec850f290. Checking for > endpoints against fwnode->secondary in fwnode_graph_get_next_endpoint() is > a better way to do this since that function is also used in a bunch of > other places, for instance sensor drivers checking that they do have an > endpoint connected during probe. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Daniel Scally > --- > drivers/base/property.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) This can only be reverted due to your 1/2 change, right? If so, you might want to make that explicit here... thanks, greg k-h