Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp548979pxt; Thu, 5 Aug 2021 06:10:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnWfLfrSxzi7Tm8zyrc5+fnWBw4QhIylTbEQzT6j4OyXacZCDHPgponLe0s3usHFJ2Utnm X-Received: by 2002:a5d:97cc:: with SMTP id k12mr87446ios.4.1628169041768; Thu, 05 Aug 2021 06:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628169041; cv=none; d=google.com; s=arc-20160816; b=Ak4GO55cbfa1SaxkJK8QrAFrqdL3DucUrDFg9OKSq1ObUHVYkob72WSpkH+bFSeJt0 Ya6XgsBWJrEupinQKG9lYD8gHSRZYP2X0ALIXdLxzi+LLn7F50eSwnp427xdjfLAEIND Ruh62Xif7qrV36vzU+pSmGsa2g6BzvTz7kMqXCgFWA02vISXQpSr80O4HAlT33X01H0w 0DrDKTJOK6+pAL7pFJBV9RMXiLHGqfXCjuH6qKXWCRrlFjilouk2HU+aF5jP31kAtYsh JI+QKhpoPsYHtHK7JP9sTAqGJRVv4QD02EfnsfTMDHm0/H9FfWbJ1L/LKKei1WKgBGRO R10Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4F3p1qZod1eEHT74DWW+Q7WEnMPGtiaT/p3Hj6p8VCA=; b=bRXBUO3tJkM8DuXDLgf6achHD7fOD+jlDbjlwsvQbmYI1BWHS3LY4l/9x9HmjE3kq+ jNHSrrJEILppXSdCxnJNrdp6S7ti/FKRPYgkxGKh5bDcdgvoIc0oWjGxzZvFTNNOK/rk WEB659y7dOHI4jbnSqxlO4ncjrbRskqMMdm0pJ4W3mluH4lSmaR1dRF1tJuRq/+3nP8E XdBLoCERrUtUBmSbq2au8ACEtF6V9zLZG+SVpcehpHzTdmA1JnZHl8IwRWA14C7LpmD/ Mc42Mq4fkhYFTrMYXFBvnxGL3W7aWbea0y9DBAfkF4LCra/4k/58G+A/Je0CvQCTPBli cJcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VgV4jVsd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n12si5536884ilm.119.2021.08.05.06.10.28; Thu, 05 Aug 2021 06:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VgV4jVsd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240771AbhHELI1 (ORCPT + 99 others); Thu, 5 Aug 2021 07:08:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:59778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240738AbhHELIZ (ORCPT ); Thu, 5 Aug 2021 07:08:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0377460F22; Thu, 5 Aug 2021 11:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628161691; bh=RnT92SYGhIXN6hiGQaaRNCG7tySLmSwCS/xmeQhHUFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VgV4jVsdJM70+IBj4940m2mPNjfXTckt4k+3FQufmbq+1RHziKfLwFl1WPBkc2VvD rOLw+BJYv1zMbSVx9FQjgjGHAo1tFn0I2ibyuq74Xv2U+qx7M91W9B26+mIig2YEAP HpfWKSpDqfRi5Mtdk8d8/pTqeC63lKpNae+QSPB8= Date: Thu, 5 Aug 2021 13:08:08 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: r8188eu: remove RT_TRACE and DBG_88E prints from ioctl_linux.c Message-ID: References: <20210802073917.8647-1-martin@kaiser.cx> <20210804141916.13832-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804141916.13832-1-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 04:19:16PM +0200, Martin Kaiser wrote: > We should use the standard mechanism for debug prints. Remove the > prints that use driver-specific macros. > > Remove all "IOL tests" from rtw_dbg_port as these tests don't make sense > without a success/fail print at the end. (The rtl8723bs driver removed > the tests as well.) > > Signed-off-by: Martin Kaiser > --- > v2: > - remove IOL tests > > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 851 +------------------ > 1 file changed, 33 insertions(+), 818 deletions(-) Can you add this to the other series you are going to resend so I know what is the latest to review? thanks, greg k-h