Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp553852pxt; Thu, 5 Aug 2021 06:16:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGtecDmlakdWHiasuftdhjeOf5rfJVdAqDoOnI+fcfN4k4x+ZYIy4O8AWNn0hgysSHk5JM X-Received: by 2002:a05:6402:54f:: with SMTP id i15mr6655037edx.24.1628169397268; Thu, 05 Aug 2021 06:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628169397; cv=none; d=google.com; s=arc-20160816; b=mT/iNLo82PJ02qYux/m2k4LAh2TnQdtH4BYxThr/sQXZ4IFwhJQP7aEr3qxbDENfz3 63/WRK/FMsMAJvIT6j70rLsF8rkG/tX/xMHoX3s0UEB+BxAGFYP2oLKbdbZgoVKjsyDM lzmB7yMWFgxfkv8yB3/fXDHCBvsmJQ3/3vmUhg6ah4n4t+L31m9pTb2G42Ym2NZZ4TnV qJ+hLT0oviuPyowuXEJFtqB24e5hlAoEmEaWYBSFx2AKKyv2KXyDjCpwIdBF4RvZZ+/M EsKZvKDoMXul/H+uOitYoi0+HzN+wm5ywKwC5tvLZvQvRc8cxoYDwkwP25/10wkxYIv9 LTaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CEkaXS8CJwOn/dvNiek0A+AHmVU4nGYsIkF+LIAJo0Y=; b=wF06Bgww3WxUj+Po6sxDigOoF01DabsenVtkNWtwBCTX2yqzeI6jp3Dv4db1DOFvf8 V2hZzm1BgqlaHyJjwXNyeWjC1+LtkPC6wU3lnYZ/Aab/nviyk/PnTsAmnh0ef4KncBYJ mb6vzjIS4EnxflQ0m2TpKRPnDs6EOsekOrKzJ74KWGS3mSggkkFy4kbmBCNQYp9JhCw+ ohrZquV4a+/q/A0a2HqOJXSe9F8DIh/a5ErKW4PRhHLDMdgAOQT+voQ0l1hjNPNTHfiC TiKnXpg+7U/9EumNYjdNSnry32QCTFmgA4Db9INLlQPW13vs21aMmHzWtKST8id8LWqD 8URw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si5651956edt.374.2021.08.05.06.16.11; Thu, 05 Aug 2021 06:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240452AbhHEKni (ORCPT + 99 others); Thu, 5 Aug 2021 06:43:38 -0400 Received: from foss.arm.com ([217.140.110.172]:42568 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240388AbhHEKng (ORCPT ); Thu, 5 Aug 2021 06:43:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C06E81FB; Thu, 5 Aug 2021 03:43:21 -0700 (PDT) Received: from e123427-lin.arm.com (unknown [10.57.41.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 438F63F719; Thu, 5 Aug 2021 03:43:20 -0700 (PDT) From: Lorenzo Pieralisi To: bhelgaas@google.com, Christophe JAILLET , jonathanh@nvidia.com, thierry.reding@gmail.com, robh@kernel.org Cc: Lorenzo Pieralisi , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] PCI: tegra: Fix OF node reference leak Date: Thu, 5 Aug 2021 11:43:14 +0100 Message-Id: <162816017970.17991.9169417632084960512.b4-ty@arm.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <55b11e9a7fa2987fbc0869d68ae59888954d65e2.1620148539.git.christophe.jaillet@wanadoo.fr> References: <55b11e9a7fa2987fbc0869d68ae59888954d65e2.1620148539.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 May 2021 19:17:42 +0200, Christophe JAILLET wrote: > Commit 9e38e690ace3 ("PCI: tegra: Fix OF node reference leak") has fixed > some node reference leaks in this function but missed some of them. > > In fact, having 'port' referenced in the 'rp' structure is not enough to > prevent the leak, until 'rp' is actually added in the 'pcie->ports' list. > > Add the missing 'goto err_node_put' accordingly. Applied to pci/tegra, thanks! [1/3] PCI: tegra: Fix OF node reference leak https://git.kernel.org/lpieralisi/pci/c/eff21f5da3 [2/3] PCI: tegra: Use 'seq_puts' instead of 'seq_printf' https://git.kernel.org/lpieralisi/pci/c/804b2b6f2a [3/3] PCI: tegra: make const array err_msg static https://git.kernel.org/lpieralisi/pci/c/fd44e8efcc Thanks, Lorenzo