Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210705053258.1614177-1-acourbot@chromium.org>
 <20210705053258.1614177-12-acourbot@chromium.org> <8929c97f-b105-ee35-d882-1cd218edcfd1@xs4all.nl>
In-Reply-To: <8929c97f-b105-ee35-d882-1cd218edcfd1@xs4all.nl>
From:   Tzung-Bi Shih <tzungbi@google.com>
Date:   Thu, 5 Aug 2021 19:51:34 +0800
Message-ID: <CA+Px+wWARA-TF66x3k8nY+TNqNo90Cn2Q_c73a66JUXWkY0dsg@mail.gmail.com>
Subject: Re: [PATCH v6 11/14] media: mtk-vcodec: vdec: support stateless H.264 decoding
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc:     Alexandre Courbot <acourbot@chromium.org>,
        Tiffany Lin <tiffany.lin@mediatek.com>,
        Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
        Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
        Yunfei Dong <Yunfei.Dong@mediatek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 20, 2021 at 6:52 PM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
> Several new structs do not have any field documentation, but they do start with /**,
> so I get complaints about missing field docs.
>
> After manually changing this to /*, I still get a few remaining warnings:
Will fix in next version.

> mtk-vcodec/vdec/vdec_h264_req_if.c:189: warning: Function parameter or member 'h264_slice_params' not described in 'vdec_h264_vsi'
> mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'h264_slice_param' not described in 'vdec_h264_slice_inst'
> mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'dpb' not described in 'vdec_h264_slice_inst'
>
> Can you fix this?
Will fix in next version.

> I also want to take this patch series at the same time:
>
> https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@mediatek.com/
>
> Can you verify that this would not cause any problems with your series? As far as
> I can see it is fine, but a second pair of eyeballs wouldn't hurt.
Series [1] shouldn't cause any problems with this series.

However, series [1] doesn't apply after this series (conflicted with
[2]).  It needs to rebase and send another version after fixing the
typo anyway.

[1]: https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@mediatek.com/
[2]: https://patchwork.linuxtv.org/project/linux-media/patch/20210630085247.27554-3-irui.wang@mediatek.com/