Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933172AbWK2FES (ORCPT ); Wed, 29 Nov 2006 00:04:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933709AbWK2FES (ORCPT ); Wed, 29 Nov 2006 00:04:18 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50618 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S933172AbWK2FER (ORCPT ); Wed, 29 Nov 2006 00:04:17 -0500 Date: Tue, 28 Nov 2006 21:04:16 -0800 (PST) Message-Id: <20061128.210416.59658806.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: kaber@trash.net, khc@pm.waw.pl, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org Subject: Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function From: David Miller In-Reply-To: References: <20061128.204440.39160464.davem@davemloft.net> X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 20 From: Herbert Xu Date: Wed, 29 Nov 2006 15:56:57 +1100 > David Miller wrote: > > > > Longer term this is really messy, we should handle this some > > other way. > > Definitely. I'm not sure whether 48 is enough even for recursive > tunnels. This should really just be a hint. It's OK to spend a > bit of time reallocating skb's if it's too small, but it's not OK > to die. The recursive tunnel case is handled by the PMTU reductions in the route, isn't it? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/