Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp836742pxt; Thu, 5 Aug 2021 12:57:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWvuWHa8mEJp7wCZD3GSSgqiXJw3H38oVgHMDH3rwX7mEhxw1+4dPIsQJ8s70VU4kktLHx X-Received: by 2002:aa7:d593:: with SMTP id r19mr8623918edq.372.1628193420862; Thu, 05 Aug 2021 12:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628193420; cv=none; d=google.com; s=arc-20160816; b=qmN3NrrmOC8cffM8EdhJQwXZSKjKa1wymRmNwzPUKmeOPFHxtdihWNOCeuoxgT6pq3 lC/ylHPoiGeucwAkBw5Xx1BkaLn4KAHoHuKgIq6NxKvR2IJ6Pj+96qAkUkyuQUagYCE0 fX3Lnzi9ywp1pKROwrpaYB0oEDc9bDYNr6CCC8Fvu/FyhK7bOvo4B8MNNjnW3a7/3njp iBgDH+asJJrB8frRq8hy/V6EiEjdLulcUFGPokMJuSPVVaVQSrJuSbIbPiDuIFKJ5vII HoTfesnYwP/yv0XakRcLoKyIHaioUqLNpKW5v51Y5lrQYf/ETwfEBGXLizQZTGiB+nw3 C7SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fWyxiv/pErQ7N+6xbY6u4M/aM7fPaX8/Z0/dByjtInw=; b=y6F37eNcsVGV6vX2XEDzNF8l55QbKHwH+jmRtMrd5fcVUfSeLVlLb2osVXC0NvtLBJ H8obiiC6BXpQZrjtcB7hyFEMFJiO+Dw3yAzDZy3Z5zaIhqRW/M6hKOdPf92iXTO7yWGq GKjFaUo/XxiAB/ZkKpPvmdcJ/XPez4skFvYQBhRdx1BHw4OPUBCGLS4Gz30VIejFZ5HL dT9TsO5ME/BLsay1NIqqKkzoOC95g6/vn8vIquse9iaW/ikwOOSBudYhoz0G4/FqPhc7 +gNQh1piVL45LdnJdFCrNPh7TUqTS9aFA3L/2H8VkuvXjtNK06ePg47Eu04Gq91skPWO lKuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si6884856ejv.123.2021.08.05.12.56.37; Thu, 05 Aug 2021 12:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240614AbhHERoC (ORCPT + 99 others); Thu, 5 Aug 2021 13:44:02 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:44080 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240726AbhHERn4 (ORCPT ); Thu, 5 Aug 2021 13:43:56 -0400 Received: from localhost.localdomain ([217.128.214.245]) by mwinf5d63 with ME id dtje250085JEng903tjfsu; Thu, 05 Aug 2021 19:43:39 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 05 Aug 2021 19:43:39 +0200 X-ME-IP: 217.128.214.245 From: Christophe JAILLET To: haris.iqbal@ionos.com, jinpu.wang@ionos.com, dledford@redhat.com, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] RDMA/rtrs: Remove a useless kfree Date: Thu, 5 Aug 2021 19:43:36 +0200 Message-Id: <9a57c9f837fa2c6f0070578a1bc4840688f62962.1628185335.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing it. It is just a no-op. Remove the useless kfree. Signed-off-by: Christophe JAILLET --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c index ece3205531b8..fc440a08e112 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c @@ -1844,7 +1844,6 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con, } if (!sess->rbufs) { - kfree(sess->rbufs); sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs), GFP_KERNEL); if (!sess->rbufs) -- 2.30.2