Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Shannon Nelson <snelson@pensando.io>,
        Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>,
        "Claudiu Manoil" <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
Subject: RE: [PATCH net-next v5] ethernet: fix PTP_1588_CLOCK dependencies
Thread-Topic: [PATCH net-next v5] ethernet: fix PTP_1588_CLOCK dependencies
Thread-Index: AQHXif7rGSsHV68jEkSarT7sgNvVuqtlLnOQ
Date:   Thu, 5 Aug 2021 17:43:22 +0000
Message-ID: <CO1PR11MB50892BAC1A4F74EBFF6D9C21D6F29@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20210805133615.1637246-1-arnd@kernel.org>
In-Reply-To: <20210805133615.1637246-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yoHsMzKK84nzJMGeVXBYr3lguG2DZw+tnpqNqkfa48PapEXzWtf5Fqq4L5hh?=
 =?us-ascii?Q?1euPAhaG29BcRUSeIvV4mDLnqmaBEkKNYpwrbbEcg831GowEjGgCoBDyqL2K?=
 =?us-ascii?Q?seEZZ8UUxcIiNsC7qz2cm4zJoqfLNc9Eej3sCSbR9sRj4Mp0449UvdA/RBmV?=
 =?us-ascii?Q?8ky4DXWaGNDUL9OZbzeRsRa8+Ctz6DgTRLxavwcd/IKV3QBYNbMpdVieTMMi?=
 =?us-ascii?Q?vPxThQCUi/zhNsYCIT8+hj3nICFXdYXooQhznnrCsSu2fFOYyC4AC06W17di?=
 =?us-ascii?Q?i4pDs8LRiOzq9UNi3ER7EpY36a8jHXkkGzvv69zXcumu3EnrWr6Pztqliiug?=
 =?us-ascii?Q?VdoLAfgfhDy3Lszqig4hs5ufPq5erH1BCiWaq+Ezmdg/Ihkeob9BKWxMq3e8?=
 =?us-ascii?Q?GUGGNp1VPABlpWTNkawzYY261r1hyZ0Eq/ssPKmXob/wHaM16YfQnGecMteB?=
 =?us-ascii?Q?5G67CflVNYRyncKcc2aSb0w51pptUhXeLmWQ/tIwUya8bmwUNdtoaf9tC5dG?=
 =?us-ascii?Q?PGrgPh+KkQz9szZ8CBHoGxCcG4OfQi5jZoZh876eYCS1lzZXjL4tJTPtZv/k?=
 =?us-ascii?Q?M9VH+N1hSfFrFlk3jC20zIkJuKvguJy/57qn9xz/BoS8hXQuoLVQ2dvIX9am?=
 =?us-ascii?Q?pZs0U8KJ3E009kxpktx7EguWVqVdoBvT4Uod0WkYluqxTypYMAIZA36OgMYC?=
 =?us-ascii?Q?vyl7JJtPskwtBBMpy3LLl5MBqZzKq11pKj6mK6qB1bddoAeqY+A3jpcd5MCB?=
 =?us-ascii?Q?LU/ERAtm4GTrMVdNDSMyYAVebpD7bQW0F97qy8PUed7tYqWiEzK1uNawwMeK?=
 =?us-ascii?Q?gtf5DVeDsMD4O55OXeeWL5wOo6zPCMl+Ab5X1Dl+pzYR0Uc7XPqsUhPjagvt?=
 =?us-ascii?Q?1GDW3AhIGYmogCeyiBrE2ItRMLHJR5k1Vbfl/oJpsCVt4TY4DoeIOO/q8MzE?=
 =?us-ascii?Q?1xL2Lm5486kzKqnJ6PIHdYTXKqqZihvPIrqub7ZwOqlFY+qHZIGLxQtkWEa+?=
 =?us-ascii?Q?FVppgL+Y7ZX5pB/9dFsZK7jyDGGTGLQUttNkfsuhFCoQmqjnnUxHqoK5kM4C?=
 =?us-ascii?Q?2sub8nIX44NuqCSaH4KF2YQc2EanOor4n5ZZD1kGh2tLcsVjOzyDR0pF2aox?=
 =?us-ascii?Q?1pYoy83t2/9gkS7PS2bXBkhEUrW4L09zPwwbHuZOs05mSbdb7LcLCKSiVJ1e?=
 =?us-ascii?Q?KyyLVq+6zVk/AIGD0C6MMpn8g/9Q2JWlzBDmgAomgA0APouT+HDVvgIJcu8p?=
 =?us-ascii?Q?Q2RPblFq4bw9X0PYbDQfuVwTw6npd3EUTsBO+52m4IPLYFuNvQybqfe8/Uvg?=
 =?us-ascii?Q?6HU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a81ddc6b-1738-4fe8-8670-08d958388529
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 17:43:22.4014
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oFLGFS+CIetJHQkT/pweotqFmxo//x1+GANfYyahOP0jCFd8sr/mQzXRrwsahpLkHed+ehCsljFhGOYfk4fqGqmJmWrsTVGriTKCygk2jmE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4571
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Thursday, August 05, 2021 6:32 AM
> To: David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.or=
g>;
> Richard Cochran <richardcochran@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; Shannon Nelson
> <snelson@pensando.io>; Keller, Jacob E <jacob.e.keller@intel.com>; Andrew
> Lunn <andrew@lunn.ch>; Vladimir Oltean <olteanv@gmail.com>; Claudiu Manoi=
l
> <claudiu.manoil@nxp.com>; Alexandre Belloni
> <alexandre.belloni@bootlin.com>; Yisen Zhuang <yisen.zhuang@huawei.com>;
> Brandeburg, Jesse <jesse.brandeburg@intel.com>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Subject: [PATCH net-next v5] ethernet: fix PTP_1588_CLOCK dependencies
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The 'imply' keyword does not do what most people think it does, it only
> politely asks Kconfig to turn on another symbol, but does not prevent
> it from being disabled manually or built as a loadable module when the
> user is built-in. In the ICE driver, the latter now causes a link failure=
:
>=20
> aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function
> `ice_eth_ioctl':
> ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'
> ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `ice_ptp_get_ts_config'
> aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to
> `ice_ptp_set_ts_config'
> ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `ice_ptp_set_ts_config'
> aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function
> `ice_prepare_for_reset':
> ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'
> ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 =
against
> undefined symbol `ice_ptp_release'
> aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function
> `ice_rebuild':
>=20
> This is a recurring problem in many drivers, and we have discussed
> it several times befores, without reaching a consensus. I'm providing
> a link to the previous email thread for reference, which discusses
> some related problems.
>=20
> To solve the dependency issue better than the 'imply' keyword, introduce =
a
> separate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any driver
> can depend on if it is able to use PTP support when available, but works
> fine without it. Whenever CONFIG_PTP_1588_CLOCK=3Dm, those drivers are
> then prevented from being built-in, the same way as with a 'depends on
> PTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,
> but that can be rather confusing when you first see it.
>=20
> Since this should cover the dependencies correctly, the IS_REACHABLE()
> hack in the header is no longer needed now, and can be turned back
> into a normal IS_ENABLED() check. Any driver that gets the dependency
> wrong will now cause a link time failure rather than being unable to use
> PTP support when that is in a loadable module.
>=20
> However, the two recently added ptp_get_vclocks_index() and
> ptp_convert_timestamp() interfaces are only called from builtin code with
> ethtool and socket timestamps, so keep the current behavior by stubbing
> those out completely when PTP is in a loadable module. This should be
> addressed properly in a follow-up.
>=20
> As Richard suggested, we may want to actually turn PTP support into a
> 'bool' option later on, preventing it from being a loadable module
> altogether, which would be one way to solve the problem with the ethtool
> interface.
>=20
> Fixes: 06c16d89d2cb ("ice: register 1588 PTP clock device object for E810=
 devices")
> Link: https://lore.kernel.org/netdev/20210804121318.337276-1-
> arnd@kernel.org/
> Link:
> https://lore.kernel.org/netdev/CAK8P3a06enZOf=3DXyZ+zcAwBczv41UuCTz+=3D0F=
Mf
> 2gBz1_cOnZQ@mail.gmail.com/
> Link: https://lore.kernel.org/netdev/CAK8P3a3=3DeOxE-K25754+fB_-
> i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/
> Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-
> arnd@kernel.org/
> Acked-by: Shannon Nelson <snelson@pensando.io>
> Acked-by: Jacob Keller <jacob.e.keller@intel.com>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


v5 looks great to me.

Thanks,
Jake