Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp882427pxt; Thu, 5 Aug 2021 14:13:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpVO3C8byGI7lEQhaCrfldPPPwFExrvYPLk0WtFj+ib+qodOLGuk5PI4j7FlG+WSyV6voq X-Received: by 2002:a92:d70f:: with SMTP id m15mr25960iln.162.1628198008695; Thu, 05 Aug 2021 14:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628198008; cv=none; d=google.com; s=arc-20160816; b=ajBThOj8yTTEk87yt4NFyDxZZ7Yoaxnq0+l4/DD5m1xSAFMlDwlFLAuRqwXTvEmaLz U7R6B+FLW/z5Q6vwa63XG9//yxCsfAa3iO9I9FUfGKlFDHQnDEmx44GkWZSO86pmRago a2hhEbebX/1F+oU/dtQLIxRmsMoGUMLDPJg+M6HfoccJqZXKlt9WojBEFuXfD/9oNklB QXcQ/2/mccQWjEB45RC6JMtrFjz6rArK5wEwqcjr0B0rywDwf+hp5xJP+L4v92YHC/GB xCARLeUj4rjRZ53+vihn5sAgARVLH5QtlgS8G8WjGerxbScQ9LW5OrwtfxAh9r3kS993 I6aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=bKuk/upnvvKRRXqeDy5iCdghukFiyhnIoM4qRaCEosw=; b=IL+61N4bqA+fsR7ZiqEjJv29D+3x5UP3r4amz2wNjBQ/n+W74UG8vwZ857ZxnXBjGG JZ7Pv+8ClM2CmkO50C1B082v2EbkjgNonHe1wfFPBpKmtO+WjI0j7J66Ql710fMY6JsT czoNKsFPMD+Yv6nSuaiL4ytayRJuEsh0lGhpR2hLSDeWBrNJCofde9l9YRLX6bEKcyaW WHbu5hjJh49o04c6U0la8UAdqR8v5ATNsvr/LlrzfZoCLbwzGZ36XSNvK3UZQjaWZI7q OHhWCcwESwv0A7YrFmF81TtPoSPT4HkqWvHFYkgGdGGhD7tcgoA4AmJN4q49BXZdZ05v TlNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si6705675jap.106.2021.08.05.14.13.16; Thu, 05 Aug 2021 14:13:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242280AbhHETJM (ORCPT + 99 others); Thu, 5 Aug 2021 15:09:12 -0400 Received: from mga09.intel.com ([134.134.136.24]:64685 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242274AbhHETJL (ORCPT ); Thu, 5 Aug 2021 15:09:11 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="214215896" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="214215896" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 12:08:55 -0700 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="512904115" Received: from dkdean-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.209.157.53]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 12:08:54 -0700 Subject: Re: [PATCH v1] driver: base: Add driver filter support To: Dan Williams , Andi Kleen Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Jonathan Corbet , Kuppuswamy Sathyanarayanan , Linux Kernel Mailing List , Linux Doc Mailing List References: <20210804174322.2898409-1-sathyanarayanan.kuppuswamy@linux.intel.com> <21db8884-5aa1-3971-79ef-f173a0a95bef@linux.intel.com> <1e0967ee-c41e-fd5d-f553-e4d7ab88838c@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <179a8351-5541-a4f0-bbb2-5d4f398e2476@linux.intel.com> Date: Thu, 5 Aug 2021 12:08:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/21 12:01 PM, Dan Williams wrote: > What's wrong with the generic authorized proposal? The core can > default to deauthorizing devices on the platform bus, or any bus, > unless on an allow list. It's a bit more work to uplevel the local > "authorized" implementations from USB and Thunderbolt to the core, but > it's functionally identical to the "filter" approach in terms of > protection, i.e. avoiding probe of unnecessary unvetted drivers. I have not yet read about the "authorized" model in USB and Thunderbolt. So bear with me if my question is basic or obvious. In the case USB authorized model, who maintains the allow list? kernel or userspace? If we are clubbing it with the driver filter model, I think allow list in kernel should take precedence. Agree? -- Sathyanarayanan Kuppuswamy Linux Kernel Developer