Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210804112053.263887-1-sergio@lony.xyz> <296a3a38-2e9c-f3f2-66a8-70f52eaff2eb@gmail.com>
In-Reply-To: <296a3a38-2e9c-f3f2-66a8-70f52eaff2eb@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 5 Aug 2021 15:40:50 -0400
Message-ID: <CADnq5_PcfoQijtu86BKDjGNEE3JxmsrvigMaO_mBrWQrBtmR3Q@mail.gmail.com>
Subject: Re: [PATCH] DRM: gpu: radeon: Fixed coding style issues
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc:     =?UTF-8?Q?Sergio_Migu=C3=A9ns_Iglesias?= <lonyelon@gmail.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        xinhui pan <Xinhui.Pan@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Sergio_Migu=C3=A9ns_Iglesias?= <sergio@lony.xyz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Aug 5, 2021 at 8:33 AM Christian K=C3=B6nig
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 04.08.21 um 13:20 schrieb Sergio Migu=C3=A9ns Iglesias:
> > Fixed braces, an unnecessary if statement and added a missing space.
> >
> > Signed-off-by: Sergio Migu=C3=A9ns Iglesias <sergio@lony.xyz>
>
> Normally we see patches which just fixes coding style as unnecessary
> churn, but the "if (rbo) {}" is really ugly here.
>
> So Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>.
>
> Thanks,
> Christian.
>
> > ---
> >   drivers/gpu/drm/radeon/radeon_fb.c | 7 ++-----
> >   1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeo=
n/radeon_fb.c
> > index 0b206b052972..6640b7c947fe 100644
> > --- a/drivers/gpu/drm/radeon/radeon_fb.c
> > +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> > @@ -54,6 +54,7 @@ radeonfb_open(struct fb_info *info, int user)
> >       struct radeon_fbdev *rfbdev =3D info->par;
> >       struct radeon_device *rdev =3D rfbdev->rdev;
> >       int ret =3D pm_runtime_get_sync(rdev->ddev->dev);
> > +
> >       if (ret < 0 && ret !=3D -EACCES) {
> >               pm_runtime_mark_last_busy(rdev->ddev->dev);
> >               pm_runtime_put_autosuspend(rdev->ddev->dev);
> > @@ -196,9 +197,8 @@ static int radeonfb_create_pinned_object(struct rad=
eon_fbdev *rfbdev,
> >               radeon_bo_check_tiling(rbo, 0, 0);
> >       ret =3D radeon_bo_kmap(rbo, NULL);
> >       radeon_bo_unreserve(rbo);
> > -     if (ret) {
> > +     if (ret)
> >               goto out_unref;
> > -     }
> >
> >       *gobj_p =3D gobj;
> >       return 0;
> > @@ -294,9 +294,6 @@ static int radeonfb_create(struct drm_fb_helper *he=
lper,
> >       return 0;
> >
> >   out:
> > -     if (rbo) {
> > -
> > -     }
> >       if (fb && ret) {
> >               drm_gem_object_put(gobj);
> >               drm_framebuffer_unregister_private(fb);
>