Subject: Re: [patch] Mark rdtsc as sync only for netburst, not for core2
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Arjan van de Ven <arjan@linux.intel.com>, Andi Kleen <ak@suse.de>,
       linux-kernel@vger.kernel.org, akpm@osdl.org
In-Reply-To: <456D3F52.6040308@yahoo.com.au>
References: <1164709708.3276.72.camel@laptopd505.fenrus.org>
	 <200611281136.29066.ak@suse.de> <1164774239.15257.5.camel@ymzhang>
	 <456D372C.9080800@linux.intel.com>  <456D3F52.6040308@yahoo.com.au>
Content-Type: text/plain
Date: Wed, 29 Nov 2006 17:04:59 +0800
Message-Id: <1164791099.2873.3.camel@ymzhang>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1522
Lines: 40

On Wed, 2006-11-29 at 19:05 +1100, Nick Piggin wrote:
> Arjan van de Ven wrote:
> > Zhang, Yanmin wrote:
> > 
> >> If it's a single processor, the go backwards issue doesn't exist. 
> >> Below is
> >> my patch based on Arjan's. It's against 2.6.19-rc5-mm2.
> > 
> > Hi,
> > 
> > this patch is incorrect
> > 
> >> --- linux-2.6.19-rc5-mm2_arjan/arch/x86_64/kernel/setup.c    
> >> 2006-11-29 10:41:21.000000000 +0800
> >> +++ linux-2.6.19-rc5-mm2_arjan_fix/arch/x86_64/kernel/setup.c    
> >> 2006-11-29 10:42:28.000000000 +0800
> >> @@ -861,7 +861,7 @@ static void __cpuinit init_intel(struct          
> >> set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability);
> >>      if (c->x86 == 6)
> >>          set_bit(X86_FEATURE_REP_GOOD, &c->x86_capability);
> >> -    if (c->x86 == 15)
> >> +    if (c->x86 == 15 && num_possible_cpus() != 1)
> >>          set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
> > 
> > 
> > first of all, you probably meant "|| num_possible_cpus() == 1"
> > 
> > but second of all, the core2 cpus are dual core so.. .what does it bring 
> > you at all?
> 
> I guess you could boot with a UP kernel or maxcpus=1?
Yes, with the new patch. My reply email to Arjan was lost in LKML because
my email client was crazy to set the email as HTML format.

> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/