Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210805151317.19054-1-guang.zeng@intel.com> <20210805151317.19054-4-guang.zeng@intel.com>
 <YQxns0wQ74d4X5VD@google.com>
In-Reply-To: <YQxns0wQ74d4X5VD@google.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Thu, 5 Aug 2021 15:41:15 -0700
Message-ID: <CALMp9eQ-ZQQ36F9ffTL7Y=r_2k-wzFjade--3TKBwC2vomH2YQ@mail.gmail.com>
Subject: Re: [PATCH v3 3/6] KVM: VMX: Detect Tertiary VM-Execution control
 when setup VMCS config
To:     Sean Christopherson <seanjc@google.com>
Cc:     Zeng Guang <guang.zeng@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Jethro Beekman <jethro@fortanix.com>,
        Kai Huang <kai.huang@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Robert Hu <robert.hu@intel.com>,
        Gao Chao <chao.gao@intel.com>,
        Robert Hoo <robert.hu@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 5, 2021 at 3:35 PM Sean Christopherson <seanjc@google.com> wrote:
>
> On Thu, Aug 05, 2021, Zeng Guang wrote:
> > +u64 vmx_tertiary_exec_control(struct vcpu_vmx *vmx)
>
> Make this static and drop the declaration from vmx.h, there's no nested user (yet),

I assume that this feature isn't actually virtualizable, since it's
based on posted interrupts, which are not virtualizable.