Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 5 Aug 2021 18:41:48 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Alex Elder <elder@linaro.org>
Cc:     davem@davemloft.net, bjorn.andersson@linaro.org,
        evgreen@chromium.org, cpratapa@codeaurora.org,
        subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/6] net: ipa: reorder netdev pointer
 assignments
Message-ID: <20210805184148.46bc33e9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210805182712.4f071aa8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20210804153626.1549001-1-elder@linaro.org>
        <20210804153626.1549001-3-elder@linaro.org>
        <20210805182712.4f071aa8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 5 Aug 2021 18:27:12 -0700 Jakub Kicinski wrote:
> On Wed,  4 Aug 2021 10:36:22 -0500 Alex Elder wrote:
> > Assign the ipa->modem_netdev and endpoint->netdev pointers *before*
> > registering the network device.  As soon as the device is
> > registered it can be opened, and by that time we'll want those
> > pointers valid.
> > 
> > Similarly, don't make those pointers NULL until *after* the modem
> > network device is unregistered in ipa_modem_stop().
> > 
> > Signed-off-by: Alex Elder <elder@linaro.org>  
> 
> This one seems like a pretty legit race, net would be better if you
> don't mind.

Ah, this set was already applied, don't mind me :)