Date: Wed, 29 Nov 2006 11:46:44 +0100
From: =?ISO-8859-1?Q?S=E9bastien_Dugu=E9?= <sebastien.dugue@bull.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       linux-aio <linux-aio@kvack.org>, Andrew Morton <akpm@osdl.org>,
       Suparna Bhattacharya <suparna@in.ibm.com>,
       Christoph Hellwig <hch@infradead.org>,
       Zach Brown <zach.brown@oracle.com>,
       Badari Pulavarty <pbadari@us.ibm.com>,
       Ulrich Drepper <drepper@redhat.com>,
       Jean Pierre Dion <jean-pierre.dion@bull.net>
Subject: Re: [PATCH -mm 3/5][AIO] - export good_sigevent()
Message-ID: <20061129114644.2b027be2@frecb000686>
In-Reply-To: <20061129103825.GA1773@infradead.org>
References: <20061129112441.745351c9@frecb000686>
	<20061129113234.38c12911@frecb000686>
	<20061129103825.GA1773@infradead.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 823
Lines: 27

On Wed, 29 Nov 2006 10:38:25 +0000
Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Nov 29, 2006 at 11:32:34AM +0100, S?bastien Dugu? wrote:
> > 
> >                       Export good_sigevent()
> > 
> > 
> >   Move good_sigevent() from posix-timers.c to signal.c where it belongs,
> > and export it so that it can be used by other subsystems.
> 
> A little nitpick about the subject: we usually use the term 'export' when
> adding an EXPORT_SYMBOL.  What would better describe your patch is
> 
> 'make good_sigevent non-static'
> 

  No problem.

  Thanks,

  S?bastien.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/