Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Fri, 06 Aug 2021 09:13:21 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   yajun.deng@linux.dev
Message-ID: <a9ed105aa609b619492044da3e22ff65@linux.dev>
Subject: Re: [PATCH net-next] net: Remove redundant if statements
To:     "Matthieu Baerts" <matthieu.baerts@tessares.net>,
        davem@davemloft.net, kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <4b175501-50c1-fedf-1eaf-05c0de67c3c8@tessares.net>
References: <4b175501-50c1-fedf-1eaf-05c0de67c3c8@tessares.net>
 <20210806063847.21639-1-yajun.deng@linux.dev>
Precedence: bulk

August 6, 2021 4:58 PM, "Matthieu Baerts" <matthieu.baerts@tessares.net> =
wrote:=0A=0A> Hi Yajun,=0A> =0A> Thank you for sharing this patch.=0A> =
=0A> On 06/08/2021 08:38, Yajun Deng wrote:=0A> =0A>> The if statement al=
ready move into sock_{put , hold},=0A>> just remove it.=0A> =0A> I was wo=
ndering in which subtree you had 'sock_put' checking the socket=0A> point=
er but then I realised you sent another patch just before adding=0A> this=
 check: "net: sock: add the case if sk is NULL"=0A> =0A> Please next time=
 send them in the same series to clearly indicate that=0A> this is the 2n=
d patch (2/2) and it depends on patch 1/2.=0A> =0AOK, Thank you for your =
advice.=0A=0A> Related to the modification in MPTCP part: it looks OK but=
 we do a few=0A> other calls to 'sock_put()' where we don't need to check=
 if the socket=0A> is NULL or not.=0A> =0A> In other words, if your patch=
 "net: sock: add the case if sk is NULL" is=0A> accepted, then the modifi=
cation in "net/mptcp/subflow.c" is OK for us.=0A> =0A> Cheers,=0A> Matt=
=0A> --=0A> Tessares | Belgium | Hybrid Access Solutions=0A> www.tessares=
.net