Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp299384pxt; Fri, 6 Aug 2021 02:17:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuOmE1OTrTQoRt5EMV1jM/DiqpEAl4/wCaGkhvOiaf86k1Ofkr/+zD/EO+nGYqGK5Sa/Oe X-Received: by 2002:a05:6e02:1c02:: with SMTP id l2mr56937ilh.9.1628241422703; Fri, 06 Aug 2021 02:17:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628241422; cv=none; d=google.com; s=arc-20160816; b=IATtBA1DUak/DR/v8A7FoXmU4WlS5QXd8iUejqeIwGCwk0Mikmuymn8bdkMjLTm/6f XljRWRQuSyrASOXQ+vrj7bUAa6wbLCbaB5h+KcyHFgwkTTpAeCO2kbvJzYXwUST71pdI L6KsSIvaGbcn84UyRFApDoUkntpnfslr7a74TnmcVlBPjQ/U0IwkwhGauLHaHRttGk0F ZFvrH4M8at/l1tSshJiMPipdNjJxAMTThEMjrCDs0HBGINeQL+/LIVYuARgTAhYJg3+J Z8EVElDCNqSRSOqF9R5ulqW6kfK63CsYllUTKFavjmsGkIQ4oxOFstt/mmUDa7NjW82Z ez2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=msvlg61+FMMnpmyBPV+pIriFEH/ejI4VCVNLKTM5r+s=; b=c+/ATNTXT1TrPkBvHreXlY7+YNcMO03SuDFbDi37cF2+MUCjpjVYDZ60mw92LKIbKN CndCppBCKp1pLNPd1GBx5hWI6Mk2VHgz7d5D5cV21XsFW4Ke9dSlRJ0TePZd+uMQZtJW pswHP8tWjWnKqCJoOnF6K1StYubg+x+mvHJdtz7EglYLBDY97VRm0RZB25s1lJASi386 dOkQFr1Eva7hg0EycwakkgFx4p99dickIGYDfPs5HTqyYr8UNqjq4gYu4U1AVfLd8lq/ R0Q98tvYIUwxu5TO2MDXzdkSExfveHbiWOOzghmjieOrRVAn3TeBAVOoRpURKB8SYA08 lXaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Yl4jduFw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si379448ioi.55.2021.08.06.02.16.50; Fri, 06 Aug 2021 02:17:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Yl4jduFw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244261AbhHFJPj (ORCPT + 99 others); Fri, 6 Aug 2021 05:15:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244091AbhHFJPh (ORCPT ); Fri, 6 Aug 2021 05:15:37 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AF41C061798; Fri, 6 Aug 2021 02:15:22 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id s13so1965548oie.10; Fri, 06 Aug 2021 02:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=msvlg61+FMMnpmyBPV+pIriFEH/ejI4VCVNLKTM5r+s=; b=Yl4jduFwo0Hq9Oc9EC2SrWqBPAbJkdOaXavmTj2zFJzvEEVKhFnnQvsKW9RqhbzoMH CN01CixRtVkG2x+yZN/LVSJVDRxWx0X1DVfl1RX9O0X/8PCZpTG+L2zP2DnzAypA7x54 ZxSbQdKDFfaf3hsxLvIKPLs+V8y77i0pM3Ja5p0RnUwBCklXEbkhs4yCxzplQ/iqCRIT 89BIHt+EmaJh95mpT+Y0fa+5PJKAGghfkuH5Qqno5K3ihxwHkPrx1Z3liXn76bjskV24 7ET7xf0DFuTTsAyFwMgfU6Yet6b8nOAxWpt72PtV9m3Nsb7llkbBCOCVk0HezbMSg1/S +MKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=msvlg61+FMMnpmyBPV+pIriFEH/ejI4VCVNLKTM5r+s=; b=DjrCUB4hZrvKAOh133RMpwNrXj/cSzytD1jfHox2InHP/+xtup+ApwuKLFQOcWXWOA oT1SjMl/ibvHDOIsVEUKZGcrKIv69lm/vBUxIMMZ3a2/nXQKkPiahOkaJqA51OOgk11e O0CkZgPPVpdbuTqHb/VEfgq+n8O4yqEPi9SOfjl4ZtJweKJfyZXetjKEimppMPBm5JpT pZcJsovukogumEr181OcP795HKKvA2eK5+w75w9Gu5yXOqYeWkHYqyAfVVaxuGCHMGgQ o6F1QPmiWuBCiNIlZqqAnE0Epz1EiQ8CKpej+X1AIvmr5KXM9HBog1xBbHt9XH4JqDe8 Eh6A== X-Gm-Message-State: AOAM533LWosU8n52WJ22H4MtsEVRmPWxz9jCOtwZ1i8Kv0lQbn44q/bh Da6EUL08EK80gyfM2L9uxllseilfl28E46DpK0M= X-Received: by 2002:aca:1817:: with SMTP id h23mr6692129oih.146.1628241321514; Fri, 06 Aug 2021 02:15:21 -0700 (PDT) MIME-Version: 1.0 References: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> From: Sergey Ryazanov Date: Fri, 6 Aug 2021 12:15:10 +0300 Message-ID: Subject: Re: [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() To: Andy Shevchenko Cc: "David S. Miller" , netdev@vger.kernel.org, open list , Loic Poulain , Johannes Berg , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 6, 2021 at 12:00 PM Andy Shevchenko wrote: > Make wwan_create_dev() to return either valid or error pointer, > In some cases it may return NULL. Prevent this by converting > it to the respective error pointer. > > Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem") > Signed-off-by: Andy Shevchenko > --- > v2: rewrote to return error pointer, align callers (Loic) Acked-by: Sergey Ryazanov