Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp301746pxt; Fri, 6 Aug 2021 02:21:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVHAU8LZ7P1geSLuDn13qbefzAP/mMa6rlvTpoGvUazr4tui+lZdz83FuFNjL1sIZ5kK1T X-Received: by 2002:a92:7409:: with SMTP id p9mr431637ilc.281.1628241697707; Fri, 06 Aug 2021 02:21:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628241697; cv=none; d=google.com; s=arc-20160816; b=ygLcEWXfeXfWq0wu6Osd4yvtRPXm7ITXSvbgk6sQ0iW99u5gGD8Kfz5FoNAb5COjru ynJvfLv0gml1BNJAL63uHzwQYWe2+RAs0t9Nb+x5u/QCoSO1TUglrBPgh+29yxabncWl 8yS9YcWVUdLUgcVSUjfuJ3hu91mZcuRNaB0B4Wam76kk/MDxlwT2184OvGxQo9PqXYWW j40Y+s9uu45VBg+RWxXBUOvUrGtTTeZL/2f+Y353CgGXWRc1G9YAXrYlhPdPJkS+5Wob QnRecHL0uUycZbacKpvvhEf+2AIBlL/AFpL27B1k3GeyjCl9nXzD/4v1Px5U0WI5oeD1 TgvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ygoR1r2IFRYwDwdfhf1sP9OP+NDnxs619rIUX49u2gQ=; b=cQp0x3vLfCQjoKxCpJR0C1Fl7bycEb+qNn8FDVPqspoceOWFXfCq5WWna646w3dMP6 ciUjUrm2IYUbfOnRtzOAAOVoP0OfKPkevSkstu/60BjjQw1ad//xxI1pc7V6f2X3vqyk Zxv/LxqKpCuLgh4mEw+fT502ZdWnoX1YPZYCOGu0C97kPssT9KhAXa6mRBLQKG68Hh9m AlFuzTo6tOdFMzXER8elM0RGSoMG99CAKyIwsNQRquwHt91lj2vEU4I+Cu+YdlCIPuca roa2KvomVy4tHh6lJL7rmtXGxyA04kRT/j64eW3vsBOcK4q5SmOk8E5+5h/gPp6KmrDq g+bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dR9/17ho"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si8745628jaj.0.2021.08.06.02.21.25; Fri, 06 Aug 2021 02:21:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dR9/17ho"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244335AbhHFJUP (ORCPT + 99 others); Fri, 6 Aug 2021 05:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244189AbhHFJUP (ORCPT ); Fri, 6 Aug 2021 05:20:15 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D939DC061799 for ; Fri, 6 Aug 2021 02:19:58 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id e5so6267677pld.6 for ; Fri, 06 Aug 2021 02:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ygoR1r2IFRYwDwdfhf1sP9OP+NDnxs619rIUX49u2gQ=; b=dR9/17hohzESs+XXHIXIUHUSbpB1dvL5YxWxEVcBo/Mo/QNHMmXZKj2ngnD+5456fo yiU+tPJba+GEHK0mIbiCvUTI8HZQlA1I/aNIdW26rp9ijU+BjyCpjEA1hTGkzl4wYnkM XNSK39RR84QRQynh0i+OGIhb3PhVtvpY34RbP6f4/M5zWYuoOd9N6OClsnMrhEqO6pdk i6pxK4dvKVkahaB3R79D4mSRb9X95nT4ShW3Sy86BWy1BEwpvdLKujfJWUWcNWrS1SG+ lINJdaomQWETHSsP7TyaL9tzOg0gxn8VAZK1GAum/wG/vfHh/0X37T8mNH8WftC58Xwb g3rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ygoR1r2IFRYwDwdfhf1sP9OP+NDnxs619rIUX49u2gQ=; b=enirTMFvRbgN1eGAq+w6dLiECVkh5hcLHqCXnKRO/A0DQ31URFAg9VZNHdnsk/1BIz vfqY+zpRmgUOhliwgpKkTW7ZJfh1iYzWltaQVmmgnyx8lQ9B/M8SL4ekEQT3UbUQd7Yn L0ik6k0B3EulPPLSJ8HLFSh9sRQMqkzmy0/J5W6If53sYR95rC4/6FoD7e/aLQQbV0H9 xURO4l2eWomGLx9dPaEa7aBTzjrXm1sTtlOI1j4gG8iAgXQObb9tqwUx/EvCvGUSLp4j zNdTbzXnf6EseUjqN3fQdOvnRyIMaeAfETACl5e7HGfXe4QvQzsRKNKSUG9POW906b5N Lmkg== X-Gm-Message-State: AOAM533s/bzC6m2HfSwZXaeP9fJMwsFXKgfUA5LXpBT6my/LLCCjyyrJ U0ltbUShYnX7z7vrhXDuPthKnBeJKxdlpqBKLpk2pA== X-Received: by 2002:a05:6a00:1245:b029:30f:2098:fcf4 with SMTP id u5-20020a056a001245b029030f2098fcf4mr9681880pfi.66.1628241598355; Fri, 06 Aug 2021 02:19:58 -0700 (PDT) MIME-Version: 1.0 References: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> From: Loic Poulain Date: Fri, 6 Aug 2021 11:29:38 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() To: Andy Shevchenko Cc: "David S. Miller" , Sergey Ryazanov , Network Development , open list , Johannes Berg , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Aug 2021 at 11:00, Andy Shevchenko wrote: > > Make wwan_create_dev() to return either valid or error pointer, > In some cases it may return NULL. Prevent this by converting > it to the respective error pointer. > > Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem") > Signed-off-by: Andy Shevchenko Reviewed-by: Loic Poulain