Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 6 Aug 2021 18:09:18 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Robert Foss <robert.foss@linaro.org>,
        Nicolas Boichat <drinkcat@google.com>,
        Andrzej Hajda <a.hajda@samsung.com>
Cc:     Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Hsin-Yi Wang <hsinyi@chromium.org>, Torsten Duwe <duwe@lst.de>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Bernie Liang <bliang@analogixsemi.com>,
        Qilin Wen <qwen@analogixsemi.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        devel@driverdev.osuosl.org
Subject: [PATCH v2] drm/bridge: anx7625: Tune K value for IVO panel
Message-ID: <a02c0a414bd3d0f67bf7d77c10415196743f1c0d.1628244450.git.xji@analogixsemi.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from anxtwsw-Precision-3640-Tower (60.251.58.79) by HK2PR02CA0184.apcprd02.prod.outlook.com (2603:1096:201:21::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Fri, 6 Aug 2021 10:09:24 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 24ba8188-daa6-4b92-5ec6-08d958c24483
X-MS-TrafficTypeDiagnostic: BYAPR04MB5974:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR04MB59747E2864CF52948A7D5AACC7F39@BYAPR04MB5974.namprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CNXH3r7cpBnIzndo7TB2ORKqDRhMAjd4XRRn2A/D3tdssdjiYDdeS2e+pptECDYIxR8nW/iiU1DIyYbslyGfpI+R9kyWt32jl4HgcROwsIYrZNTrdLK8FyD9WVSFpT3m8EaPNiiVG3hsPcorXn+WiDLJD/KoMziOe8U9rNeXmyklADAVGR46ha77ox92f+rn3R0rxi7Z0MPOjVMzyCaJK59aZxVVS4wxR5aLdmmU8jKDV9atEp89swW5f/APSECQQPQF0hJBXr9Dn2jIsiDbhsq4KHAiW+6JePBuRuzSUxavgt8/53tsjLmoDxrKVzKJl1nBkLZgmxAPbX/nV8G3u9nhMIlySbcvDcxWhgzmIiowoAY0s7mbF+EL2qon8YWUayHbwdRQnA8XPBgiyCwSSBReenFzo0/YvEnIsks7irr6IxdIMqdG4noYLhf/TlGnUWA2LjfHQLij8pGuyDquW6zFjhSIYe4AsXakdjVmzOD4iQFDxFkoSRmPPLBkoW84hMC8lTsh1f+V+FG5QSEw0hbJbPMCo7la9S09lJ0yYYDFH1Eq6pJLfrY5WkALECvJ2RTDI1JRaNega7e7S/ZKxPCbbXLco7wNSQIDoO6VqmJccjxhTq5eIdMgM8Nlx2gRGb5N7+TTZRctxPIVxZ91Dhkunvd58aBa6Oa4RorwPVQ9Fu/kv7QL1eZNSrh1iYQALtLr8xyjQ4d8u5PZ4uAFCw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR04MB6739.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(376002)(39840400004)(396003)(136003)(5660300002)(7416002)(6666004)(4326008)(478600001)(6486002)(66476007)(66946007)(66556008)(52116002)(110136005)(2906002)(36756003)(54906003)(8676002)(38350700002)(2616005)(26005)(86362001)(6496006)(83380400001)(316002)(8936002)(38100700002)(55236004)(186003)(956004);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pnjweh9Q3/W06oqIAY4G1kl/bi1IGSxDlRyOUDYlugiWZL7MBKUFFy3jvFEl?=
 =?us-ascii?Q?GQr7oYzx4Toube6nUH9+Af6ZCTZynni3XZBXsrR8xj3TQPacEFeg7ZRdu21y?=
 =?us-ascii?Q?Be79hlNM9t1Ef5Q8/PdlfWFnYXOUNvbGkflBBD4BwDQ0DmDS7K3mc3edtQCs?=
 =?us-ascii?Q?k6nRvfxnWy/Yp75ABhXWv+JlXZ1zF5Ba+kwNCwiOgQZnfUEPS1ZZj9FkRIKC?=
 =?us-ascii?Q?76l71K54b+Ynp3ayQCKxwBiIFZSwDg1l2m7P+pJYMIIZGHBPdB5TT/sj7dTC?=
 =?us-ascii?Q?ukiE5P7A8J2c82uoAAVQpxdc+lO9ZOPcmX4UD/UOMxI4eUILxirukhEORqjF?=
 =?us-ascii?Q?cOn+SlzlSmgmI83rwxidSve6Q9MiX744pb+Kyr91wl5x3IcfqtLxR2NLC6tp?=
 =?us-ascii?Q?A7+oimaNJcs2bNxD2q5TKC1rqSajUhp4lz4BpT+Lva/CyuoliEbS91SqP++K?=
 =?us-ascii?Q?zfB9J7iY+x8+lXSSNZ0u2uD295fkrVykLxratoTNjQLjjHg69RkaaNknJmWl?=
 =?us-ascii?Q?TKLofO7ZRdSXa5E0ygapiOAcZKFP8rNt+K7oPDixEV7iXZRh1f4tIO27w295?=
 =?us-ascii?Q?56GLDjxriE6At3pkU1Ou81kQxS6i0FhPr9qSqdKZ69BArKU/6t1AgtjI3uWu?=
 =?us-ascii?Q?VJto0W1bU/tolHc5irPbhrw1utGDptKdUIkXh3iFVszxFKV71brC2NAtjh8h?=
 =?us-ascii?Q?kpoZATNwimyZL0C76o9k9xL0KinGEPaz1z7sjQiThvyBd8gh6a673/k8c2GN?=
 =?us-ascii?Q?C48kqvSRFdUmcUHbo57RC58qob6XQwBdUTRiW3AC83SpnSOuVKbpS0HXfShL?=
 =?us-ascii?Q?qmiL53oQly+20Mq4/yIWndCexHTu38ksaD6LC0vBDYXSjV3zwZtNX4bNTY0f?=
 =?us-ascii?Q?cZasmaLgv1ttLNyPBEiemgkCmRWfuazlNcyR3pKLY+956zc9AQNwK8ANbUEI?=
 =?us-ascii?Q?5sev3OsD/2Uz5wBh/HkWA+digUcYORYR+7i/0oG202N0uP/oAxN9saAjYee5?=
 =?us-ascii?Q?zokLwf9YIwujfosqN1z7GB6Paa4iHXsebf7lAtTnupmmDpDHj9GAbJjDwz62?=
 =?us-ascii?Q?4iKSSy1ySFGQSwwbQsFer/4xHnioXgVQ7bxTDr6v2z8mzIsIqEDT4I704MCA?=
 =?us-ascii?Q?SfQdB8HDNX20ARfTisMUyoAmDQZtieJsTPMsbSTsYyPQqHpjuixbP+0Z+8U1?=
 =?us-ascii?Q?ALCzTaWBkvDmiZmmD9AFyTgsngwcBKJ9q4HYRPMgV2gh/qVpA2kNyuKBsh97?=
 =?us-ascii?Q?oJDNHxWs9goKLRsHE+t7tKsAoEqKZ3tfZkDAoqnWQkTMGlFvoWYjr5A3W+Z3?=
 =?us-ascii?Q?T2Ljrr+/0bYU6rkr+r/louQf?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24ba8188-daa6-4b92-5ec6-08d958c24483
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2021 10:09:24.8644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iy9+yriqZ7dM2dz6UFM/m0UAmgrdWhJJnFv9+MnSG+H1h31U50hJ055Y2MB32XWlUW/TQmg9KTF20/VJxJHA/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5974
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

IVO panel require less input video clock variation than video clock
variation in DP CTS spec.

This patch decreases the K value of ANX7625 which will shrink eDP Tx
video clock variation to meet IVO panel's requirement.

Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 24 ++++++++++++++++++++---
 drivers/gpu/drm/bridge/analogix/anx7625.h |  4 +++-
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index a3d82377066b..9b9e3984dd38 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -384,6 +384,25 @@ static int anx7625_odfc_config(struct anx7625_data *ctx,
 	return ret;
 }
 
+/*
+ * The MIPI source video data exist large variation (e.g. 59Hz ~ 61Hz),
+ * anx7625 defined K ratio for matching MIPI input video clock and
+ * DP output video clock. Increase K value can match bigger video data
+ * variation. IVO panel has small variation than DP CTS spec, need
+ * decrease the K value.
+ */
+static int anx7625_set_k_value(struct anx7625_data *ctx)
+{
+	struct edid *edid = (struct edid *)ctx->slimport_edid_p.edid_raw_data;
+
+	if (edid->mfg_id[0] == IVO_MID0 && edid->mfg_id[1] == IVO_MID1)
+		return anx7625_reg_write(ctx, ctx->i2c.rx_p1_client,
+					 MIPI_DIGITAL_ADJ_1, 0x3B);
+
+	return anx7625_reg_write(ctx, ctx->i2c.rx_p1_client,
+				 MIPI_DIGITAL_ADJ_1, 0x3D);
+}
+
 static int anx7625_dsi_video_timing_config(struct anx7625_data *ctx)
 {
 	struct device *dev = &ctx->client->dev;
@@ -470,9 +489,8 @@ static int anx7625_dsi_video_timing_config(struct anx7625_data *ctx)
 			MIPI_PLL_N_NUM_15_8, (n >> 8) & 0xff);
 	ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p1_client, MIPI_PLL_N_NUM_7_0,
 			(n & 0xff));
-	/* Diff */
-	ret |= anx7625_reg_write(ctx, ctx->i2c.rx_p1_client,
-			MIPI_DIGITAL_ADJ_1, 0x3D);
+
+	anx7625_set_k_value(ctx);
 
 	ret |= anx7625_odfc_config(ctx, post_divider - 1);
 
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h
index 034c3840028f..6dcf64c703f9 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.h
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.h
@@ -210,7 +210,9 @@
 #define  MIPI_VIDEO_STABLE_CNT           0x0A
 
 #define  MIPI_LANE_CTRL_10               0x0F
-#define  MIPI_DIGITAL_ADJ_1   0x1B
+#define  MIPI_DIGITAL_ADJ_1     0x1B
+#define  IVO_MID0               0x26
+#define  IVO_MID1               0xCF
 
 #define  MIPI_PLL_M_NUM_23_16   0x1E
 #define  MIPI_PLL_M_NUM_15_8    0x1F
-- 
2.25.1