Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp504732pxt; Fri, 6 Aug 2021 07:14:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrUEuz99IWh1/aY/2owUBefpnh3dpWtS0f1/FeU49CMmsOG2zExRrgr55tc14uN4i5+DbS X-Received: by 2002:a92:d848:: with SMTP id h8mr1342753ilq.282.1628259270414; Fri, 06 Aug 2021 07:14:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628259270; cv=none; d=google.com; s=arc-20160816; b=WOdpWOt2J6TXBbUg8Mg9/sY5S1etNCnMFCgPoVvJ/idUV8fF9LVJAzf6S0urycra1C T+yQlHAjOjEP/w6rygMNiQC+AKxgAJx9rDHitUh2EuTbAV183kbflVallkuLOCYomACJ 62Utr+mO9aS4tJ5zEUrdXB63nbJl5tco6PgR4PRvq8QdqsjAt6hlu7B4vIgbMa9OjBFy +U81tiInQ7lPIib+WT0yAJvsDK6pXrbfekBfXijqWGE2u36NbgFPXZjaISxz4M9gSyKH EW2RAPW9hiqdxysl+Blp2wrxLs9BaL+GDhwx50u5IK4J1zhITaxoWBy0eYP6tHZKUmCr n2Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=vromIZfVaRTbVHccIXLwJjG5p8UCfRytvq4A7EoGIIk=; b=wn/AFMd/1Fc0UwG2Gb88iemZM0GSbOXCaKdRUCojkvCyvb1M5KJ1yvp51ba5k3A/ce UBvB1cjTBGF5/Fjz/KuwdSC2aN03hSNznezRo17VxJeht2nTxUyouRWK9TjfBPfm9iWe 66Zw9ZwVOqB8BowJHc/jzLeiWsNwFjLfvneei/k6dsqLwWzUPCd1CkcQhx/VqAmKKF9B q2N68n9yU05/9sQnRIPR4Ln8LfngvkiRILArT/qd6NO/eAsbQ5QTu6xicLUa454cx/L0 DySdrTsk5ZP+kKysWYjD518Fwb8tiYt6Xzrl7JiWOrNFQ3tHMa1XGNuVGcbKUMO5jyhZ P7bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iBGtmRsG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si10177105iov.104.2021.08.06.07.14.18; Fri, 06 Aug 2021 07:14:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iBGtmRsG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbhHFJTC (ORCPT + 99 others); Fri, 6 Aug 2021 05:19:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244300AbhHFJSA (ORCPT ); Fri, 6 Aug 2021 05:18:00 -0400 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E481AC061798; Fri, 6 Aug 2021 02:17:43 -0700 (PDT) Received: by mail-oo1-xc29.google.com with SMTP id f33-20020a4a89240000b029027c19426fbeso2059827ooi.8; Fri, 06 Aug 2021 02:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vromIZfVaRTbVHccIXLwJjG5p8UCfRytvq4A7EoGIIk=; b=iBGtmRsGEszCCemqaXsr04N78m8Fvi8sEQ9KxI7opv/URJjnzjBmK0BNQYCjywzEar 5hKFaBGrhjptD8nwbsog13QAYs2reI4Jsy+dI9hr+J9sBDhE9/9SGQoP3QyJO53qoHo/ xL0x3PqceLEzqGjnH8Rl+5Cn3fV0KcuEa5F9TdwEAhVuqEZVt44m10qt0Sk6xWrwCOxG Hla/wtD/lieIHu8Z4ojYCEMDPFTZaZ3yy+P1K7xjjbNKIvH36ZPoLD/IiUAe7zXfw7nY cxGyBoCcOdHz3yhQdK+r3Ncd64HvgQoABDACA5z8lMBLHjqpHIIdn+zp5DdiGODAMRvu qBug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vromIZfVaRTbVHccIXLwJjG5p8UCfRytvq4A7EoGIIk=; b=JpKZSTP73WOWAHgMmLsKSbhbBNFU6b0OEURb9Fza1+8bDGGJEYDnRAiquazbSAhD/Q 30QdZqqPi/39fh9Kc/nKtnQfzjHhiAmvxd/ALPcEuLxmwqux0bC2Qgba0iNG3i4Vnly8 q4/pcBZEkTMvmPw1WxrK3EVVu/r4ufKfyW08z92cTy9IEhcTsb1+vNR0y5X1Kqer3PJw rSMQ/3U5P5Qt4Ppr1KC3hPRTZKY7PaB3DyKjT9VocevuSonn7J2INbx/KV7bqiR+5lWY 7MnOQ13okUL19vnan7ltGOYPbOTubngxxpfnyzI0fw7Z1iGGLrC4Q2tMHLzCeprEdWEO zaaQ== X-Gm-Message-State: AOAM533TW3ag14U7kf+kQmSs9wHoB7uuSz83Hd+dEWITi/jEOdOFnIUW XrbE43gPXdXrTQlzDmllbkEjRKoInPeCCdxMt5M= X-Received: by 2002:a4a:6c06:: with SMTP id q6mr6054290ooc.71.1628241462739; Fri, 06 Aug 2021 02:17:42 -0700 (PDT) MIME-Version: 1.0 References: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> <20210806085413.61536-2-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210806085413.61536-2-andriy.shevchenko@linux.intel.com> From: Sergey Ryazanov Date: Fri, 6 Aug 2021 12:17:32 +0300 Message-ID: Subject: Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range)) To: Andy Shevchenko Cc: "David S. Miller" , netdev@vger.kernel.org, open list , Loic Poulain , Johannes Berg , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 6, 2021 at 12:00 PM Andy Shevchenko wrote: > ida_alloc_range)) may return other than -ENOMEM error code. > Unshadow it in the wwan_create_port(). > > Signed-off-by: Andy Shevchenko A small nitpick, looks like "ida_alloc_range))" in the description is a typo and should be "ida_alloc_range()". Besides this: Reviewed-by: Sergey Ryazanov