Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp561444pxt; Fri, 6 Aug 2021 08:24:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0rJcGwNQ5jXVLy5LGFqXTi/PAR8yJT7hJVFN6Ssu2oU4LTltLDLNhFDiEW+YLsq44TvMu X-Received: by 2002:a17:906:aed3:: with SMTP id me19mr10065775ejb.187.1628263492378; Fri, 06 Aug 2021 08:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628263492; cv=none; d=google.com; s=arc-20160816; b=hckczqbCjJvifPKBlk0Vaxlv+Mi3CIl345UJnR606pPsolJqMyA+2vThepwZL7qozE pyH4eN/3UfUkW9XQl8Ah5d+nTkeoBxSnA1T3tMS/AfwCLkcDbG7dcdddwdT6pCrjU3vS XhCYrTlumuE3R5GbUL79JwBAvB+I4B0HaNj8g0rKdlDnoV/xv50cP6E9cac5rY24VuxK HsmBn7QlGaEFrjR+MOr33nppZjXP3A27d7ZwqTsN6YSsefVw+2Vq7d2SWgAgBzA5F0e+ oRGMlg77Hu7pJhTJxQIOWh/o3iwyJcWxwtZs99ZWJVdikWTtG971gr6EWlo25Q1NJSjR 1GrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QpcuE6Xf3nDEPx4ouJJKA1Lw/VkQU5tSiR6QM0SDGjs=; b=WMRKB1tuXBFQxCnMYk99lULciptOmhn3mn8IYC4+zsymKqzinZx26ahUxIV5v25blE mKMHS67zxaVpHaE/XAiR7F7lzsP6zI+TznMoQYXlTimidJfI9Dz+/YJMVGTUkF90Cd6j xKXDyWexMYB1w2p7qk6y2wE31yQZGObNCO5Nv6VXXFxLWtRbIqe62H/MV0LCiqyddRwP op1FKIXISKjHwmbGroc/I0c/N1scYdNYW/1ObBGXjm4cnTJmKfB1NsUTLIong40mzZz+ jxjX/lh2evMsg57bYZf+Fglz2/gXo0i2e5bqs9iZzKizoA4feXvTFxdiFzCu1tQJL/Fy WcCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TGxIvA1a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd36si9212590ejc.253.2021.08.06.08.24.29; Fri, 06 Aug 2021 08:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TGxIvA1a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245176AbhHFLA3 (ORCPT + 99 others); Fri, 6 Aug 2021 07:00:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:54254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231700AbhHFLA0 (ORCPT ); Fri, 6 Aug 2021 07:00:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5056B61181; Fri, 6 Aug 2021 11:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628247610; bh=QpcuE6Xf3nDEPx4ouJJKA1Lw/VkQU5tSiR6QM0SDGjs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TGxIvA1adK17UB8Pb8OpkZJguwjCWUPpcMIbWJ55Hj2Gn/epB/L6shK2tky7YwjGq zFnBiULVRqq8kU2wGF/m7I3DIIriIh+wHmBQdfFXuwPcXyPmsvDJhKA8nCCCnVDvQ/ EhEQ+aBwQTMgrHmLrCjEJKSbw7bQz3QCT9Q3x9C7VKPygtqaw2DZZvIgi3cZFg6iYl gXYbLYPL+6JsKYte4VMdPhu4btEmIPpEF0xwZRYMGk0csA6RLr3qlpJDDPB9o/dYza FiqJSghtKO29O4rRJtWx8y5TJUst/caNVm30P9AqnkkPqa91iiqdgY6Fgc/yZHitvw dzv43fOo3x37g== Date: Fri, 6 Aug 2021 11:59:54 +0100 From: Mark Brown To: Ravikumar Kattekola Cc: Peter Geis , Jaehoon Chung , Ulf Hansson , Liam Girdwood , Rob Herring , linux-mmc@vger.kernel.org, Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org Subject: Re: [BUG] mmc_regulator_set_ocr can't cope with regulator-fixed Message-ID: <20210806105954.GV26252@sirena.org.uk> References: <20210805124650.GM26252@sirena.org.uk> <20210805130842.GO26252@sirena.org.uk> <81006771-99bf-a5f9-4001-2cf3dc84f69d@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zvmqw4jX2vbPsMQB" Content-Disposition: inline In-Reply-To: <81006771-99bf-a5f9-4001-2cf3dc84f69d@gmail.com> X-Cookie: MOUNT TAPE U1439 ON B3, NO RING User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zvmqw4jX2vbPsMQB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 06, 2021 at 01:44:45PM +0530, Ravikumar Kattekola wrote: > But, IMO mmc core should check if the voltage can be changed or not >=20 > before trying to do regulator_set_voltage() in mmc_regulator_set_ocr(). It does exactly that in mmc_regulator_get_ocrmask(). --zvmqw4jX2vbPsMQB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmENFikACgkQJNaLcl1U h9CJcAf/dMneLY3//GjYvaXP4Dl2LqP/fc83WqO6E4dJf+Q9FzvqkBneamuQfUYH QpjYRGO3aTuTAdw5sLmDfsZVMgbcMkQMumppkrTKP1QVWOSwHkMCLYeb061mmp5i Uf+FG0NaQ8HGEN/wk6ac3BuDntvg8tj5pPGu3RDU474sIzXDZb0q2FqCMyYlC3dp 78ueiE8XQg4CMrcnwVfZ5nbmB1kM1t83UmkO8N8ZDLpwAWFbtwDm5NzaPSFVhWJV M7hYPYTOW6I+apyCHwArzVNMPMJEV8B5nQm92V6F5AQzqU0s529DKNPjv9YnSnP6 DWoW7yM+miX/2so5WGlNRcexznpX8A== =a6Wc -----END PGP SIGNATURE----- --zvmqw4jX2vbPsMQB--