Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 6 Aug 2021 12:45:41 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Alistair Francis <alistair@alistair23.me>, robh+dt@kernel.org,
        lgirdwood@gmail.com, linux-imx@nxp.com, kernel@pengutronix.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        alistair23@gmail.com
Subject: Re: [PATCH v9 03/12] mfd: simple-mfd-i2c: Save the register client
 data
Message-ID: <20210806114541.GY26252@sirena.org.uk>
References: <20210806091058.141-1-alistair@alistair23.me>
 <20210806091058.141-4-alistair@alistair23.me>
 <YQ0fPEeZGYe7f1cC@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pDtNmxPr5KTxcQ6Z"
Content-Disposition: inline
In-Reply-To: <YQ0fPEeZGYe7f1cC@google.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--pDtNmxPr5KTxcQ6Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 06, 2021 at 12:38:36PM +0100, Lee Jones wrote:
> On Fri, 06 Aug 2021, Alistair Francis wrote:

> > +	i2c_set_clientdata(i2c, regmap);
> > +

> No need to store this here.

> Just do this in the child device:

>      dev_get_regmap(pdev->dev.parent, NULL);

Note that dev_get_regmap() is relatively expensive compared to a simple
driver data reference since it needs to go search for the device to find
the regmap, it's not the end of the world especially in the context of
doing I2C I/O but storing it isn't a terrible idea.

--pDtNmxPr5KTxcQ6Z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmENIOQACgkQJNaLcl1U
h9DxJQf/TuyP2y3UfrP+x/Wbj5TUX4a0xU78jS7hhKqNUubUfUVUt+3e2HWDFn0S
7L/kD0+2R2LgseDvTaEesgsh2pG3zoFdmLUESXJ2jXjNFMEs5ghnl2f6UFN0Xhbq
WhwTOq7czFXuPrsGn/ENBhS4CMZtEy9VyBGADad+9ywJ9mSVrk+G1C3kVL9noefx
TFIMsSOYOyeoFy3SQSGpOuSzvEfc3QT84QLdO0iF3EHyR4pyTaRSbDhMrvCuiQ1v
y4icrwxHH3yH28LcErkBRzsDrwoRrVW5E/a0R3L6cK9niAl5cMxIkvu7w/rg/WqZ
bwM487Xppc5FK6NmjakYEKnrOsmPQA==
=v6hN
-----END PGP SIGNATURE-----

--pDtNmxPr5KTxcQ6Z--