Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1627972461-2627-5-git-send-email-hsin-hsiung.wang@mediatek.com>
References: <1627972461-2627-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1627972461-2627-5-git-send-email-hsin-hsiung.wang@mediatek.com>
Subject: Re: [PATCH v10 4/5] spmi: mediatek: Add support for MT8195
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        Henry Chen <henryc.chen@mediatek.com>
To:     Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>
Date:   Fri, 06 Aug 2021 10:49:19 -0700
Message-ID: <162827215909.1975443.852277412377742323@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Hsin-Hsiung Wang (2021-08-02 23:34:20)
> From: Henry Chen <henryc.chen@mediatek.com>
>=20
> Add spmi support for MT8195.
>=20
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>

Missing Signed-off-by from hsin-hsiung.wang here

> ---
> changes since v9:
> - No change.
> ---
>  drivers/spmi/spmi-mtk-pmif.c | 90 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 90 insertions(+)
>=20
> diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c
> index 94c45d46ab0c..0c320801c9d5 100644
> --- a/drivers/spmi/spmi-mtk-pmif.c
> +++ b/drivers/spmi/spmi-mtk-pmif.c
> @@ -348,6 +427,14 @@ static const struct pmif_data mt6873_pmif_arb =3D {
>         .soc_chan =3D 2,
>  };
> =20
> +static const struct pmif_data mt8195_pmif_arb[] =3D {

This is an array of type pmif_data.

> +       {
> +               .regs =3D mt8195_regs,
> +               .spmimst_regs =3D mt8195_spmi_regs,
> +               .soc_chan =3D 2,
> +       },
> +};
> +
>  static int mtk_spmi_probe(struct platform_device *pdev)
>  {
>         struct pmif *arb;
> @@ -444,6 +531,9 @@ static const struct of_device_id mtk_spmi_match_table=
[] =3D {
>         {
>                 .compatible =3D "mediatek,mt6873-spmi",
>                 .data =3D &mt6873_pmif_arb,

mt6873_pmif_arb is not an array, see the context header above.

How does this work? Has this been tested?

> +       }, {
> +               .compatible =3D "mediatek,mt8195-spmi",
> +               .data =3D &mt8195_pmif_arb,
>         }, {
>                 /* sentinel */
>         },
> --=20
> 2.18.0
>