Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp892232pxt; Fri, 6 Aug 2021 17:10:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwodm8CZAc1QXpfC5h9FCIUWvgOZHEe1BkiomTF7UmnDPccyV0V6b/tc9FrvTasCr7FN2Yb X-Received: by 2002:a05:6638:3048:: with SMTP id u8mr11952694jak.91.1628295047024; Fri, 06 Aug 2021 17:10:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628295047; cv=none; d=google.com; s=arc-20160816; b=tNChqzMn/gXVQnbT0Fjj1Yz6m8FPznQvWhsYcqIXfMdADq6++mtsgDatpQ/MKrT9y2 pMpKT7aYK9c4SAYFNHWvwkJmWfmszgpC+3VRrW2FBHPfapm0Qmqh6vYzgW3dk+dJK8vn DbctNmiLsdRr5Tu5YvR+rXYGVL4KVKaSRQnhnIyWG2975WIs5Q4oPbeXcJ2MQ2LfMIEV 5CqEDTo4hrVxFtRCckKNuTkQBSXt2j8PRRFmFpJmsjcxkbzhx2yX5Cqd8l275Knnx0w7 NFDOEcKbbm81CdOikxjTt1WYrWPpnyPPwfY3ZUyTA6v9ngBPkwLYcVjkQnf33aufJ1u6 UeuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LEXT/WiAaR44NcVyVHwKiakrpHH3+3BmMqeU9Qd7iy4=; b=OQ+7tZT3qBw9yWsWRHGrrzy8ZtfqVap1bhbX8oKW5jrjoTjjHQM6vNLKHHrPaL/PyG Fd086S0ikBgFVu9IAQeKwvu1yAtTUPXWTZViSxMMbAEnN6KNu1I2OyY2EjuMJjXF5sPS X2wKZyDnuXgOtwWE0Q2Ttrn/VSzG+GfUPQxN/0Z8OxJXHuREEi6SiIk2nmHJ3fRfRWaz k8pka92tjumxZV/I5TOG7sv5bLSDN8QieqG8dCUXlF8mym/RDGRkxF40ILdxPXJCVvzo yhLzSM0/xs3RhxWxt73NrJ85rXkMNXlJoHDB8BEGZ6u40ZrLA7wjMZ402DrpshgWGVzw 4A4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si2259358jat.116.2021.08.06.17.10.35; Fri, 06 Aug 2021 17:10:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244465AbhHFUD1 (ORCPT + 99 others); Fri, 6 Aug 2021 16:03:27 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50239 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244463AbhHFUD0 (ORCPT ); Fri, 6 Aug 2021 16:03:26 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 93F4E1BF204; Fri, 6 Aug 2021 20:03:09 +0000 (UTC) From: Miquel Raynal To: Daniel Palmer , miquel.raynal@bootlin.com, richard@nod.at Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mtd: spinand: core: Properly fill the OOB area. Date: Fri, 6 Aug 2021 22:03:08 +0200 Message-Id: <20210806200309.393655-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210617110842.2358461-1-daniel@0x0f.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'df12a75a2be915e7c419707bc71fba0fa7548d81' Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-06-17 at 11:08:42 UTC, Daniel Palmer wrote: > The comment in spinand_write_to_cache_op() says that > spinand_ondie_ecc_prepare_io_req() should 0xff fill the OOB > area but it doesn't. > > This causes the OOB area to get filled with zeros > and anytime the first page in a block the bad block marker > is cleared and it becomes a bad block on the next boot. > > This was observed on Longsys FORSEE branded parts and > might be specific to these parts. > > Signed-off-by: Daniel Palmer Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel