Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com>
 <20210806085413.61536-2-andriy.shevchenko@linux.intel.com>
 <CAHNKnsTPQp16FPuVxY+FtJVOXnSga7zt=K8bhXr2YG15M9Y0eQ@mail.gmail.com> <CAHp75VcbucQ4w1rki2NZvpS7p-z5b582HwWXDMW5G67C7C6f3w@mail.gmail.com>
In-Reply-To: <CAHp75VcbucQ4w1rki2NZvpS7p-z5b582HwWXDMW5G67C7C6f3w@mail.gmail.com>
From:   Sergey Ryazanov <ryazanov.s.a@gmail.com>
Date:   Fri, 6 Aug 2021 23:35:04 +0300
Message-ID: <CAHNKnsQOhpwLFHLbcyLDLDOQjD7uDdsOg4ptVpdVmwWHK01NwQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range))
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        Jakub Kicinski <kuba@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 6, 2021 at 5:20 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Aug 6, 2021 at 5:14 PM Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
>> On Fri, Aug 6, 2021 at 12:00 PM Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>> ida_alloc_range)) may return other than -ENOMEM error code.
>>> Unshadow it in the wwan_create_port().
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> A small nitpick, looks like "ida_alloc_range))" in the description is
>> a typo and should be "ida_alloc_range()". Besides this:
>
> Shall I resend?

Yes, please. And specify the target tree in the subject, please. See
patchwork warning [1, 2]. The first patch is a clear bug fix, so it
should be targeted to the 'net' tree, while the second patch despite
its usefulness could not be considered a bug fix, so it should be
targeted to the 'net-next' tree. Subjects could be like this:

[PATCHv3 net 1/2] wwan: core: Avoid returning NULL from wwan_create_dev()
[PATCHv3 net-next 2/2] wwan: core: Unshadow error code returned by
ida_alloc_range()

Or since the second patch is not depends on the first one and patches
target different trees, patches could be submitted independently:

[PATCHv3 net] wwan: core: Avoid returning NULL from wwan_create_dev()
[PATCHv3 net-next] wwan: core: Unshadow error code returned by ida_alloc_range()


1. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-1-andriy.shevchenko@linux.intel.com/
2. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-2-andriy.shevchenko@linux.intel.com/

-- 
Sergey