Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp1163402pxt; Sat, 7 Aug 2021 02:40:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYrqopIa6yKhVeaX2w+6B8NaMOt/10SCfB855xxGCGhXTUpt7KFrTNpzcPerSQNQbiVJip X-Received: by 2002:a02:ca06:: with SMTP id i6mr13644616jak.29.1628329205537; Sat, 07 Aug 2021 02:40:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628329205; cv=none; d=google.com; s=arc-20160816; b=oY//ZqQ2V1Pbh8UzJ1Qs7cb4wypH9XtgA8BUlM9bZ1OFFnI8KaBy85dkzDnuNqn5kO nxen5NPKsiS6FSK7Z5BPF3AmkaH0kd7WQOHiwWxlRKTzfy80pOcX/MnrAjR/St9Y+WJT SAwzqttlRiCZZGQU2+sPQqqpre4QSAcqrJ0fmxrQCoikqENsMxzQvVwztLPkq+tj+qV1 JlrYeQiBW5zlHhkDpS+gRqoR3yixiseQNoxERZ39GWBKOh3UTP0DU8JTos7cHtHUt88O TooUL3SiH53Bc8nfZ45P243/l8YDLKavUEDE3YbIiH4lzhlzjOQ6xFfpbhcqa6xAo0JH AKYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZovYD+ZoE5cRVmjkGK2Hxl+N6pWuCJlR1bXm0sIg3J8=; b=jgnASHTYOMkOy8AIlttPYj5wvYFbcUCVuyShT1XtbBfb5IpR+v119nF5m/J9Qmfe+W bLNdVddNCMT+G+dpZZJIRujAiS8Lg3TzfeY+DchQ6kCofGJ9AIf6J4b7sv3F+XChUK/m IVKSgn/nc9cy4FMMBVbiD+YVzsGrskT+q+GEdIHTzGmfghRIN+K92U2PixAWi2HVEAtW Ko1jm6xpzT60nvfqZQFc68OL8xBu8F4njZqO6tbA9XjAH2VNFpreOruXNl5IqOMqaexi 0NOwjoBHoUZqWdoEQw98cscxXEqGYmuNj+6IPgdLuIofEoo3w6nm9Z0P4BtGy+8AYUrl O+OA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si12631042jad.82.2021.08.07.02.39.54; Sat, 07 Aug 2021 02:40:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231806AbhHGJgn (ORCPT + 99 others); Sat, 7 Aug 2021 05:36:43 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:16990 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbhHGJgi (ORCPT ); Sat, 7 Aug 2021 05:36:38 -0400 Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GhcZh1gfyzZqkK; Sat, 7 Aug 2021 17:32:44 +0800 (CST) Received: from huawei.com (10.175.124.27) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 7 Aug 2021 17:36:19 +0800 From: Miaohe Lin To: CC: , , , , , , Subject: [PATCH 5/5] mm: gup: use helper PAGE_ALIGNED in populate_vma_page_range() Date: Sat, 7 Aug 2021 17:36:20 +0800 Message-ID: <20210807093620.21347-6-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210807093620.21347-1-linmiaohe@huawei.com> References: <20210807093620.21347-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use helper PAGE_ALIGNED to check if address is aligned to PAGE_SIZE. Minor readability improvement. Signed-off-by: Miaohe Lin --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 8c89e614d4aa..802a3deb50cd 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1471,8 +1471,8 @@ long populate_vma_page_range(struct vm_area_struct *vma, unsigned long nr_pages = (end - start) / PAGE_SIZE; int gup_flags; - VM_BUG_ON(start & ~PAGE_MASK); - VM_BUG_ON(end & ~PAGE_MASK); + VM_BUG_ON(!PAGE_ALIGNED(start)); + VM_BUG_ON(!PAGE_ALIGNED(end)); VM_BUG_ON_VMA(start < vma->vm_start, vma); VM_BUG_ON_VMA(end > vma->vm_end, vma); mmap_assert_locked(mm); -- 2.23.0