Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210806154951.4564-1-andriy.shevchenko@linux.intel.com> <fdf5b050-2c8d-f3f1-f8bd-0dbc616c9bc6@gmail.com>
In-Reply-To: <fdf5b050-2c8d-f3f1-f8bd-0dbc616c9bc6@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 7 Aug 2021 12:46:17 +0300
Message-ID: <CAHp75VfNkinQn1SsTU24THA=0XQZUX1KeAW42TvsCYO0DfadRQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs
 in Makefile
To:     Daniel Scally <djrscally@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Aug 7, 2021 at 3:20 AM Daniel Scally <djrscally@gmail.com> wrote:
> On 06/08/2021 16:49, Andy Shevchenko wrote:
> > The 'objs' is for user space tools, for the kernel modules
> > we should use 'y'.
>
> Oops, now you mention it I remember you saying that for the cio2-bridge
> code too - thanks.

Just for the sake of reference (I spent some time to realize from
where I have got this):
https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#composite-userspace-programs
(Note, that there is the first section with the first "objs" mention)

...

> Reviewed-by: Daniel Scally <djrscally@gmail.com>

Thanks!

-- 
With Best Regards,
Andy Shevchenko